From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/4] ns16550: enable Pericom controller support
Date: Thu, 10 Mar 2016 21:31:41 -0500 [thread overview]
Message-ID: <20160311023140.GA13103@localhost.localdomain> (raw)
In-Reply-To: <56E064E402000078000DAF4D@prv-mh.provo.novell.com>
On Wed, Mar 09, 2016 at 10:01:08AM -0700, Jan Beulich wrote:
> >>> On 09.03.16 at 17:52, <konrad.wilk@oracle.com> wrote:
> > On Tue, Mar 08, 2016 at 01:48:05AM -0700, Jan Beulich wrote:
> >> >>> On 07.03.16 at 23:04, <konrad.wilk@oracle.com> wrote:
> >> > Hmm, if it was some other PCI based serial card like:
> >> >
> >> > 01:05.0 Serial controller: NetMos Technology PCI 9835 Multi-I/O
> >> > Controller (rev 01) (prog-if 02 [16550])
> >> > Subsystem: LSI Logic / Symbios Logic Device 0001
> >> > Flags: medium devsel, IRQ 20
> >> > I/O ports at e050 [size=8]
> >> > I/O ports at e040 [size=8]
> >> > I/O ports at e030 [size=8]
> >> > I/O ports at e020 [size=8]
> >> > I/O ports at e010 [size=8]
> >> > I/O ports at e000 [size=16]
> >> >
> >> > With 'com1=115200,8n1,pci' and 'com2=115200,8n1,pci' then the first loop
> >> > would find the device. The second loop would decrement idx (1) by 1 and
> >> > continue.. which would make it go search for another device.
> >> >
> >> > I hadn't tested this patch on the above device but I believe it used
> >> > to work with the com1 and com2 going throught it - while with the new code
> >> > it won't?
> >>
> >> That's the !bar0 case, and hence the code in the loop over
> >
> > You mean:
> >
> > param += uart_config[i].param;
> > + if ( !param->bar0 )
> > + {
> > + bar_idx = idx;
> > + port_idx = 0;
> > + }
> > ?
> >
> > The device in question (NetMos) is not on the uart_config list at all
> > so we won't get inside this loop.
>
> Well, for devices not on the list it's undetermined anyway whether
> they would happen to work - we just can't get it right for all possible
> cases. Someone truly caring about them working should submit a
Wouldn't your patch cause a regression compared to how it used
to work in earlier version of Xen?
Let me take a peek at the card in question and see if I can hook
up an extra RS232 connector.
> patch adding them to the list.
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-11 2:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 11:22 [PATCH 0/4] ns16550: enable support for Pericom controllers Jan Beulich
2016-02-23 11:28 ` [PATCH 1/4] ns16550: store pointer to config parameters for PCI Jan Beulich
2016-03-07 21:06 ` Konrad Rzeszutek Wilk
2016-02-23 11:28 ` [PATCH 2/4] ns16550: enable Pericom controller support Jan Beulich
2016-03-07 22:04 ` Konrad Rzeszutek Wilk
2016-03-08 8:48 ` Jan Beulich
2016-03-09 16:52 ` Konrad Rzeszutek Wilk
2016-03-09 17:01 ` Jan Beulich
2016-03-11 2:31 ` Konrad Rzeszutek Wilk [this message]
2016-03-11 11:02 ` Jan Beulich
2016-03-22 13:19 ` [PATCH v2 " Jan Beulich
2016-03-28 14:46 ` Konrad Rzeszutek Wilk
2016-02-23 11:30 ` [PATCH 3/4] console: adjust IRQ initialization Jan Beulich
2016-03-07 22:10 ` Konrad Rzeszutek Wilk
2016-02-23 11:30 ` [PATCH RFC 4/4] ns16550: enable use of PCI MSI Jan Beulich
2016-02-29 16:56 ` [PATCH 0/4] ns16550: enable support for Pericom controllers Konrad Rzeszutek Wilk
2016-02-29 17:03 ` Jan Beulich
2016-03-04 13:19 ` Ping: " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311023140.GA13103@localhost.localdomain \
--to=konrad@kernel.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).