From: Daniel Kiper <daniel.kiper@oracle.com>
To: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
Cc: "jgross@suse.com" <jgross@suse.com>,
"grub-devel@gnu.org" <grub-devel@gnu.org>,
"eric.snowberg@oracle.com" <eric.snowberg@oracle.com>,
"arvidjaar@gmail.com" <arvidjaar@gmail.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"cardoe@cardoe.com" <cardoe@cardoe.com>,
"pgnet.dev@gmail.com" <pgnet.dev@gmail.com>,
"roy.franz@linaro.org" <roy.franz@linaro.org>,
"ning.sun@intel.com" <ning.sun@intel.com>,
"david.vrabel@citrix.com" <david.vrabel@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"stefano.stabellini@eu.citrix.com"
<stefano.stabellini@eu.citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"qiaowei.ren@intel.com" <qiaowei.ren@intel.com>,
"richard.l.maliszewski@intel.com"
<richard.l.maliszewski@intel.com>,
"gang.wei@intel.com" <gang.wei@intel.com>,
"fu.wei@linaro.org" <fu.wei@linaro.org>,
"seth.goldberg@oracle.com" <seth>
Subject: Re: [GRUB2 PATCH v4 1/4] i386/relocator: Add grub_relocator64_efi relocator
Date: Tue, 15 Mar 2016 20:59:55 +0100 [thread overview]
Message-ID: <20160315195955.GB31771__25806.9213050932$1458072108$gmane$org@olila.local.net-space.pl> (raw)
In-Reply-To: <CAEaD8JO23MkxBVF7ZqL8pDDz_85Nof1kbMo-RtxMam8S2KOeOg@mail.gmail.com>
On Tue, Mar 15, 2016 at 05:00:33PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> Other than 2 typos (inline). Looks good. Let's give it a day if somebody
> wants to object, then I'll commit it
>
> >
> > movq %rax, %rsp
> >
> > + /*
> > + * Here is grub_relocator64_efi_start() entry point.
> > + * Following code is shared between grub_relocator64_efi_start()
> > + * and grub_relocator64_start().
> > + *
> > + * Think twice before changing anything below!!!
> > + */
> >
> above?
Why? Everything outside of grub_relocator64_efi_start (above
grub_relocator64_efi_start) and grub_relocator64_efi_end (below
grub_relocator64_efi_end) is used by one function. So, we can
quite safely change anything there. However, everything between
grub_relocator64_efi_start (__below__ grub_relocator64_efi_start
label) and grub_relocator64_efi_end is owned by two functions. Hence,
every change should take into account that. Am I missing something?
> > + /* Here grub_relocator64_efi_start() ends. Ufff... */
> > +VARIABLE(grub_relocator64_efi_end)
> > +
> >
> Probably without _start. Comment probably applies even more here than above.
Nope, grub_relocator64_efi_start is entry point, so, grub_relocator64_efi_end
label marks end of grub_relocator64_efi_start() func.
> Are you ok with me moving ends to the same place when comitting? This
If you wish. However, I think that grub_relocator64_efi_start() should
contain only code/data which is really used by it. Otherwise, it could
make some confusion. Why unused code/data is owned by grub_relocator64_efi_start()?
Is by design or by mistake?
> would make the code less error-prone.
I am not convinced that it will be less error-prone then. If we wish
that maybe we should not share code in that way... ;-)))
Daniel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-15 20:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 15:25 [GRUB2 PATCH v4 0/4] multiboot2: Add two extensions Daniel Kiper
2016-03-15 15:25 ` [GRUB2 PATCH v4 1/4] i386/relocator: Add grub_relocator64_efi relocator Daniel Kiper
2016-03-15 16:00 ` Vladimir 'phcoder' Serbinenko
[not found] ` <CAEaD8JO23MkxBVF7ZqL8pDDz_85Nof1kbMo-RtxMam8S2KOeOg@mail.gmail.com>
2016-03-15 19:59 ` Daniel Kiper [this message]
2016-03-15 15:25 ` [GRUB2 PATCH v4 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image Daniel Kiper
2016-03-15 16:03 ` Vladimir 'phcoder' Serbinenko
2016-03-15 23:39 ` Konrad Rzeszutek Wilk
2016-03-15 15:26 ` [GRUB2 PATCH v4 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled Daniel Kiper
2016-03-15 23:46 ` Konrad Rzeszutek Wilk
[not found] ` <20160315234646.GE29495@char.us.oracle.com>
2016-03-16 10:02 ` Daniel Kiper
[not found] ` <20160316100214.GF31771@olila.local.net-space.pl>
2016-03-16 10:14 ` Toomas Soome
[not found] ` <D5F25A44-6157-46FB-B717-A7ED06FD01C8@me.com>
2016-03-16 10:39 ` Vladimir 'phcoder' Serbinenko
2016-03-16 13:06 ` Konrad Rzeszutek Wilk
2016-03-15 15:26 ` [GRUB2 PATCH v4 3/4 - FOR COMMIT] " Daniel Kiper
2016-03-15 16:07 ` [GRUB2 PATCH v4 3/4 - FOR REVIEW ONLY] " Vladimir 'phcoder' Serbinenko
[not found] ` <CAEaD8JP6BJQkrLSN+GgPDqYtiXMgq=A3CnhbVHv9xZ57x4NH6Q@mail.gmail.com>
2016-03-15 18:06 ` Andrei Borzenkov
[not found] ` <56E84F10.5080804@gmail.com>
2016-03-15 18:10 ` Vladimir 'phcoder' Serbinenko
[not found] ` <CAEaD8JMgHphk31781sFpZVcT5+Q+Sj1LGpNfvhr3cbT=+sU1Lg@mail.gmail.com>
2016-03-15 20:59 ` Daniel Kiper
2016-03-15 20:01 ` Daniel Kiper
2016-03-15 15:26 ` [GRUB2 PATCH v4 4/4] multiboot2: Add support for relocatable images Daniel Kiper
2016-03-15 16:27 ` Vladimir 'phcoder' Serbinenko
[not found] ` <CAEaD8JOin-GSP8+kqC3bnS-_boKzvFgV-WoByLrkDOaeNThMGg@mail.gmail.com>
2016-03-15 16:30 ` Vladimir 'phcoder' Serbinenko
[not found] ` <CAEaD8JPS9cbmmS+a0pjCMboGTd-jkwCZp59KYpnEhOgpGva6zw@mail.gmail.com>
2016-03-15 21:42 ` Daniel Kiper
[not found] ` <20160315214221.GE31771@olila.local.net-space.pl>
2016-03-15 23:54 ` Konrad Rzeszutek Wilk
2016-03-16 10:34 ` Daniel Kiper
2016-03-16 10:41 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20160315195955.GB31771__25806.9213050932$1458072108$gmane$org@olila.local.net-space.pl' \
--to=daniel.kiper@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=arvidjaar@gmail.com \
--cc=cardoe@cardoe.com \
--cc=david.vrabel@citrix.com \
--cc=eric.snowberg@oracle.com \
--cc=fu.wei@linaro.org \
--cc=gang.wei@intel.com \
--cc=grub-devel@gnu.org \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=ning.sun@intel.com \
--cc=pgnet.dev@gmail.com \
--cc=phcoder@gmail.com \
--cc=qiaowei.ren@intel.com \
--cc=richard.l.maliszewski@intel.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).