xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Keir Fraser <keir@xen.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH] docs: update FLASK cmd line instructions
Date: Tue, 15 Mar 2016 16:24:27 -0400	[thread overview]
Message-ID: <20160315202427.GI26955@char.us.oracle.com> (raw)
In-Reply-To: <1458002259-22081-1-git-send-email-cardoe@cardoe.com>

On Mon, Mar 14, 2016 at 07:37:39PM -0500, Doug Goldstein wrote:
> The command line instructions for FLASK include a note on how to compile
> Xen with FLASK but the note was out of date after the change to Kconfig.
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> ---
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Tim Deegan <tim@xen.org>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Not sure if you want backticks around `make -C menuconfig`. I also figured
> we should route people towards menuconfig by default. The committer of
> this patch is welcome to change the wording or style in anyway they see
> fit.
> ---
>  docs/misc/xen-command-line.markdown | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
> index ca77e3b..949e210 100644
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -665,8 +665,8 @@ to use the default.
>  > Default: `permissive`
>  Specify how the FLASK security server should be configured.  This option is only
> -available if the hypervisor was compiled with XSM support (which can be enabled
> -by setting XSM\_ENABLE = y in .config).
> +available if the hypervisor was compiled with FLASK support.  This can be
> +enabled by running make -C xen menuconfig and enabling XSM and FLASK.

Would it be better said:

.. "and enabling Common Features|Xen Security Module support (FLux Advanced Security
Kernel support gets enabled automatically)."

>  * `permissive`: This is intended for development and is not suitable for use
>    with untrusted guests.  If a policy is provided by the bootloader, it will be
> -- 
> 2.4.10

Xen-devel mailing list

  reply	other threads:[~2016-03-15 20:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15  0:37 [PATCH] docs: update FLASK cmd line instructions Doug Goldstein
2016-03-15 20:24 ` Konrad Rzeszutek Wilk [this message]
2016-03-15 20:40   ` Doug Goldstein
2016-03-15 20:43     ` Konrad Rzeszutek Wilk
2016-03-17  4:32       ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160315202427.GI26955@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=cardoe@cardoe.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).