xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] xentrace: simplify map_page function in xenctx
Date: Thu, 17 Mar 2016 11:54:41 +0000	[thread overview]
Message-ID: <20160317115441.GA28955@citrix.com> (raw)
In-Reply-To: <56EA9997.6000109@citrix.com>

On Thu, Mar 17, 2016 at 11:48:39AM +0000, George Dunlap wrote:
> On 03/03/16 13:10, Wei Liu wrote:
> > There were several problems:
> > 
> > 1. Variable mapped was set to NULL so the following two "if"s were
> >    useless.
> > 2. Variable previous_mfn was set but never used.
> 
> mapped and previous_mfn are static, which (in this context) means they
> persists across invocations of the function. mapped is only set to NULL
> for the first call. Subsequent calls it's used to unmap the previous
> mapping; and previous_mfn is used to avoid unmap'ing and re-map'ing the
> same mfn.
> 
> This change will cause xenctx to leak virtual address space.
> 

Right. I missed that static, sigh. Ignore this patch please.

Wei.

>  -George
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-03-17 11:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 13:10 Wei Liu
2016-03-17 11:48 ` George Dunlap
2016-03-17 11:54   ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317115441.GA28955@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH] xentrace: simplify map_page function in xenctx' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).