Re: [PATCH v4 05/14] libxl: Load guest BIOS from file

[Anthony PERARD <anthony.perard@citrix.com>]

On Wed, Mar 16, 2016 at 10:27:25AM +0100, Dario Faggioli wrote:
> On Tue, 2016-03-15 at 20:53 -0400, Konrad Rzeszutek Wilk wrote:
> > On Mon, Mar 14, 2016 at 05:55:40PM +0000, Anthony PERARD wrote:
> > > 
> > > --- a/docs/man/xl.cfg.pod.5
> > > +++ b/docs/man/xl.cfg.pod.5
> > > @@ -1121,6 +1121,15 @@ Requires device_model_version=qemu-xen.
> > >  
> > >  =back
> > >  
> > > +=item B<bios_override="PATH">
> > Perhaps 'bios_override_path' ?
> > 
> Or 'bios_path_override' ?
> 
> Wow, a French, an Italian and a Polish arguing about best looking
> English-ish words... This must be a (bad) joke! :-P :-P 

:)

To be honest, I just try to do the same as what is done for
"device_model_override". I even copied over the description, replacing
"binary" by "blob".

Maybe bios_path_override would be a good name, would this name can be
describe as "override bios_path"? At least that would not make someone
beleave that the bios= config option itself is overridden.

> > > +
> > > +Override the path to the blob to be used as BIOS. The blob
> > > provided here MUST
> > Perhaps:
> > 
> > Override the path to search for the B<bios=>?
> > 
> AFAIUI, B<bios=> does not contain an exact file name, but the
> indication of what kind of BIOS we want. Therefore, referencing it
> directly like this may be confusing (IMHO).

That's right, value can only be "rombios" or "seabios" or "ovmf".

> So, maybe something like: "Override the path at which to look for the
> BIOS binary. Such binary MUST be consistent with what has been
> specified in B<bios=>."
> 
> > Or is this the full path including the name?? In which case should it
> > mention that B<bios=> is overriden?
> > 
> If that is the case, indeed.

Yes this new config option is the full path. But it does not override
bios=.

If someone start a guest with this:

bios="seabios"
bios_override="/usr/share/ovmf/ovmf_x64.bin"

it's going to fail.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel