From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: oss-drivers@netronome.com, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Linux 4.5's nfp_net_irq_unmask_msix() vs Xen
Date: Tue, 22 Mar 2016 11:38:46 +0000 [thread overview]
Message-ID: <20160322113846.73575968@jkicinski-Precision-T1700> (raw)
In-Reply-To: <20160322113425.10178be1@jkicinski-Precision-T1700>
On Tue, 22 Mar 2016 11:34:25 +0000, Jakub Kicinski wrote:
> Hello Jan.
>
> On Tue, 22 Mar 2016 05:29:54 -0600, Jan Beulich wrote:
> > All,
> >
> > the new driver homed under drivers/net/ethernet/netronome/nfp/
> > has some direct MSI-X table manipulation which quite clearly is
> > incompatible with Xen. According to the comment preceding the
> > function, bypassing the Linux IRQ subsystem is intentional here.
> > Irrespective of the question of whether that's a good idea, this
> > also bypassing the abstractions allowing MSI to work on Xen
> > clearly needs addressing. Does anyone have any thoughts on how
> > to reasonably achieve this? Calling pci_msi_unmask_irq() would
> > seem to be an option (the symbol at least is exported), but likely
> > isn't intended to be used that way.
>
> Did you check the driver code before sending this? I think you may
> be referring to something which was removed months ago (and never
> upstreamed).
Oh, sorry. I think you just mean unmasking automasked interrupts. Is
that correct? We used to do more MSI-X magic...
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-22 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 11:29 Linux 4.5's nfp_net_irq_unmask_msix() vs Xen Jan Beulich
2016-03-22 11:34 ` Jakub Kicinski
2016-03-22 11:38 ` Jakub Kicinski [this message]
2016-03-22 12:33 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322113846.73575968@jkicinski-Precision-T1700 \
--to=jakub.kicinski@netronome.com \
--cc=JBeulich@suse.com \
--cc=oss-drivers@netronome.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).