xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: jgross@suse.com, xen-devel@lists.xen.org, annie.li@oracle.com,
	Paul.Durrant@citrix.com, David Vrabel <david.vrabel@citrix.com>,
	roger.pau@citrix.com
Subject: Re: [RFC PATCH] blkif.h: document scsi/0x12/0x83 node
Date: Tue, 22 Mar 2016 12:38:38 -0400	[thread overview]
Message-ID: <20160322163838.GC18504@char.us.oracle.com> (raw)
In-Reply-To: <22257.28343.956713.417277@mariner.uk.xensource.com>

On Tue, Mar 22, 2016 at 04:11:35PM +0000, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node"):
> > > I don't think this is a sterile academic conversation which would (if
> > > satisfactorily answered) have no real implications.  Rather, if we
> > > understood the use case properly, there would probably be implications
> > > for whether how this functionality ought to be exposed via the libxl
> > > API; whether blkfront should consume this information by default; and
> > > so on.
> > 
> > Lets take one step back.
> > 
> > What is the problem with documenting an existing use-case in blkif.h?
> > 
> > Regardless of whether it is viewed "legacy" by some folks and by others
> > drivers it is still in use?
> 
> Firstly, if you want to document it then the documentation needs to
> explain what the semantics are supposed to be.  At the moment I'm not
> sure I see a correct and useful set of semantics.  I had a go at
> writing something but several of the things I wrote in it seem to have
> been contradicted by comments from Bob Liu and others.
> 
> It is difficult to write a suitable document.  Ideally the document
> would give an example use case.  But it appears that the only use case
> is super secret!

:-)

> 
> Secondly, apparently this is not regarded as deprecated.  Bob Liu
> says he plans to add support for it to blkfront.

One step at a time. First lets document this XenStore key in blkif.h
so it is know what it does and the semantics of it.

> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-03-22 16:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16  3:09 Bob Liu
2016-03-16  7:16 ` Konrad Rzeszutek Wilk
2016-03-16 12:36 ` Ian Jackson
2016-03-16 13:59   ` Bob Liu
2016-03-16 14:07     ` Paul Durrant
2016-03-17  5:04       ` Bob Liu
2016-03-16 14:32     ` David Vrabel
2016-03-17  5:07       ` Bob Liu
2016-03-17 11:12       ` Ian Jackson
2016-03-17 11:18         ` David Vrabel
2016-03-17 11:20           ` Ian Jackson
2016-03-22 12:55         ` Bob Liu
2016-03-22 13:41           ` David Vrabel
2016-03-22 14:10             ` Konrad Rzeszutek Wilk
2016-03-22 14:38               ` David Vrabel
2016-03-22 14:43                 ` Paul Durrant
2016-03-22 15:09                   ` Ian Jackson
2016-03-22 15:25                     ` Paul Durrant
2016-03-22 16:14                       ` Ian Jackson
2016-03-22 16:50                         ` Konrad Rzeszutek Wilk
2016-03-22 17:39                         ` Paul Durrant
2016-03-22 15:12                 ` Ian Jackson
2016-03-22 15:27                   ` Konrad Rzeszutek Wilk
2016-03-22 16:11                     ` Ian Jackson
2016-03-22 16:38                       ` Konrad Rzeszutek Wilk [this message]
2016-03-22 16:25                     ` Jan Beulich
2016-03-16 14:33     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160322163838.GC18504@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=annie.li@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=jgross@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --subject='Re: [RFC PATCH] blkif.h: document scsi/0x12/0x83 node' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).