From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Xu, Quan" <quan.xu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"Wu, Feng" <feng.wu@intel.com>,
"dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v8 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue
Date: Mon, 28 Mar 2016 10:11:27 -0400 [thread overview]
Message-ID: <20160328141127.GF31349@char.us.oracle.com> (raw)
In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28894B86D211@SHSMSX101.ccr.corp.intel.com>
>
> > > + list_del(&pdev->domain_list);
> > > + pdev->domain = NULL;
> > > + pci_hide_existing_device(pdev);
> > > + break;
> > > + }
> > > + }
> > > +
> > > + pcidevs_unlock();
> > > +
> > > + if ( !is_hardware_domain(d) )
> > > + domain_crash(d);
> >
> > The description said something about 'just throw out a warning' (if the domain
> > owning it is a hardware domain). That seems to be missing?
> >
> >
>
> The warning is in the call path, in queue_invalidate_wait():
> """Queue invalidate wait descriptor timed out."""
Aah, right.
>
> Then, does it make sense?
Yes. I would recommend you modify the commit description so that clueless
folks like me can see it. You could modify the commit description to say:
"just throw out a warning (done in queue_invalidate_wait)."
>
> Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-28 14:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 5:57 [PATCH v8 0/3] VT-d Device-TLB flush issue Quan Xu
2016-03-24 5:57 ` [PATCH v8 2/3] VT-d: Wrap a _sync version for all VT-d flush interfaces Quan Xu
2016-03-24 13:56 ` Dario Faggioli
2016-03-24 15:06 ` Dario Faggioli
2016-03-25 3:11 ` Xu, Quan
2016-03-24 5:57 ` [PATCH v8 1/3] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed Quan Xu
2016-03-24 11:04 ` Dario Faggioli
2016-03-24 11:28 ` Xu, Quan
2016-03-25 20:06 ` Konrad Rzeszutek Wilk
2016-03-28 6:27 ` Xu, Quan
2016-03-28 13:31 ` Konrad Rzeszutek Wilk
2016-04-01 15:03 ` Xu, Quan
2016-03-24 5:57 ` [PATCH v8 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue Quan Xu
2016-03-24 15:38 ` Dario Faggioli
2016-03-25 3:43 ` Xu, Quan
2016-03-25 20:40 ` Konrad Rzeszutek Wilk
2016-03-28 3:44 ` Xu, Quan
2016-03-28 7:45 ` Xu, Quan
2016-03-25 20:31 ` Konrad Rzeszutek Wilk
2016-03-28 3:56 ` Xu, Quan
2016-03-28 14:11 ` Konrad Rzeszutek Wilk [this message]
2016-03-29 1:32 ` Xu, Quan
2016-03-29 14:20 ` Konrad Rzeszutek Wilk
2016-03-29 14:32 ` Xu, Quan
2016-03-24 10:33 ` [PATCH v8 0/3] VT-d Device-TLB flush issue Jan Beulich
2016-03-24 11:11 ` Xu, Quan
2016-04-01 14:47 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328141127.GF31349@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).