From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Davies Subject: Re: [PATCH 3/7] oxenstored: refactor request processing Date: Tue, 29 Mar 2016 10:08:30 +0100 Message-ID: <20160329090829.GE3316@citrix.com> References: <1458237075-13777-1-git-send-email-jonathan.davies@citrix.com> <1458237075-13777-4-git-send-email-jonathan.davies@citrix.com> <56F468A5.9080609@oracle.com> <56F46EFA.9060204@citrix.com> <56F47EEA.3070103@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akpdb-0002t9-IF for xen-devel@lists.xenproject.org; Tue, 29 Mar 2016 09:08:35 +0000 Content-Disposition: inline In-Reply-To: <56F47EEA.3070103@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Boris Ostrovsky Cc: Andrew Cooper , Jon Ludlam , Dave Scott , Euan Harris , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBNYXIgMjQsIDIwMTYgYXQgMDc6NTc6MzBQTSAtMDQwMCwgQm9yaXMgT3N0cm92c2t5 IHdyb3RlOgo+IE9uIDAzLzI0LzIwMTYgMDY6NDkgUE0sIEFuZHJldyBDb29wZXIgd3JvdGU6Cj4g Pk9uIDI0LzAzLzIwMTYgMjI6MjIsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToKPiA+Pk9uIDAzLzE3 LzIwMTYgMDE6NTEgUE0sIEpvbmF0aGFuIERhdmllcyB3cm90ZToKPiA+Pj5FbmNhcHN1bGF0ZSB0 aGUgcmVxdWVzdCBpbiBhIHJlY29yZCB0aGF0IGlzIHBhc3NlZCBmcm9tIGRvX2lucHV0IHRvCj4g Pj4+cHJvY2Vzc19wYWNrZXQgYW5kIGlucHV0X2hhbmRsZV9lcnJvci4KPiA+Pj4KPiA+Pj5UaGlz IHdpbGwgYmUgaGVscGZ1bCB3aGVuIGtlZXBpbmcgdHJhY2sgb2YgdGhlIHJlcXVlc3RzIG1hZGUg YXMgcGFydAo+ID4+Pm9mIGEKPiA+Pj50cmFuc2FjdGlvbi4KPiA+Pj4KPiA+Pj5TaWduZWQtb2Zm LWJ5OiBKb25hdGhhbiBEYXZpZXMgPGpvbmF0aGFuLmRhdmllc0BjaXRyaXguY29tPgo+ID4+PlJl dmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgo+ID4+ PlJldmlld2VkLWJ5OiBKb24gTHVkbGFtIDxqb25hdGhhbi5sdWRsYW1AY2l0cml4LmNvbT4KPiA+ Pj5SZXZpZXdlZC1ieTogRXVhbiBIYXJyaXMgPGV1YW4uaGFycmlzQGNpdHJpeC5jb20+Cj4gPj4+ LS0tCj4gPj4+ICAgdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwgfCAgIDE1ICsrKysr KysrKystLS0tLQo+ID4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA1IGRl bGV0aW9ucygtKQo+ID4+Pgo+ID4+PmRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5zdG9yZWQv cHJvY2Vzcy5tbAo+ID4+PmIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3MubWwKPiA+Pj5p bmRleCA3YTczNjY5Li5jOTJiZWM3IDEwMDY0NAo+ID4+Pi0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0 b3JlZC9wcm9jZXNzLm1sCj4gPj4+KysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3Byb2Nlc3Mu bWwKPiA+Pj5AQCAtMzQ0LDExICszNDQsMTEgQEAgbGV0IGZ1bmN0aW9uX29mX3R5cGUgdHkgPQo+ ID4+PiAgICAgICB8IFhlbmJ1cy5YYi5PcC5JbnZhbGlkICAgICAgICAgICAtPiByZXBseV9hY2sg ZG9fZXJyb3IKPiA+Pj4gICAgICAgfCBfICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLT4g cmVwbHlfYWNrIGRvX2Vycm9yCj4gPj4+ICAgLWxldCBpbnB1dF9oYW5kbGVfZXJyb3IgfmNvbnMg fmRvbXMgfmZjdCB+dHkgfmNvbiB+dCB+cmlkIH5kYXRhID0KPiA+Pj4rbGV0IGlucHV0X2hhbmRs ZV9lcnJvciB+Y29ucyB+ZG9tcyB+ZmN0IH5jb24gfnQgfnJlcSA9Cj4gPj4+ICAgICAgIGxldCBy ZXBseV9lcnJvciBlID0KPiA+Pj4gICAgICAgICAgIFBhY2tldC5FcnJvciBlIGluCj4gPj4+ICAg ICAgIHRyeQo+ID4+Pi0gICAgICAgIGZjdCBjb24gdCBkb21zIGNvbnMgZGF0YQo+ID4+PisgICAg ICAgIGZjdCBjb24gdCBkb21zIGNvbnMgcmVxLlBhY2tldC5kYXRhCj4gPj4+ICAgICAgIHdpdGgK PiA+Pj4gICAgICAgfCBEZWZpbmUuSW52YWxpZF9wYXRoICAgICAgICAgIC0+IHJlcGx5X2Vycm9y ICJFSU5WQUwiCj4gPj4+ICAgICAgIHwgRGVmaW5lLkFscmVhZHlfZXhpc3QgICAgICAgICAtPiBy ZXBseV9lcnJvciAiRUVYSVNUIgo+ID4+PkBAIC0zNzAsNyArMzcwLDEwIEBAIGxldCBpbnB1dF9o YW5kbGVfZXJyb3IgfmNvbnMgfmRvbXMgfmZjdCB+dHkgfmNvbgo+ID4+Pn50IH5yaWQgfmRhdGEg PQo+ID4+PiAgICgqKgo+ID4+PiAgICAqIE5vdGhyb3cgZ3VhcmFudGVlLgo+ID4+PiAgICAqKQo+ ID4+Pi1sZXQgcHJvY2Vzc19wYWNrZXQgfnN0b3JlIH5jb25zIH5kb21zIH5jb24gfnRpZCB+cmlk IH50eSB+ZGF0YSA9Cj4gPj4+K2xldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMg fmNvbiB+cmVxID0KPiA+Pj4rICAgIGxldCB0eSA9IHJlcS5QYWNrZXQudHkgaW4KPiA+Pj4rICAg IGxldCB0aWQgPSByZXEuUGFja2V0LnRpZCBpbgo+ID4+PisgICAgbGV0IHJpZCA9IHJlcS5QYWNr ZXQucmlkIGluCj4gPj4+ICAgICAgIHRyeQo+ID4+PiAgICAgICAgICAgbGV0IGZjdCA9IGZ1bmN0 aW9uX29mX3R5cGUgdHkgaW4KPiA+Pj4gICAgICAgICAgIGxldCB0ID0KPiA+Pj5AQCAtMzc5LDcg KzM4Miw3IEBAIGxldCBwcm9jZXNzX3BhY2tldCB+c3RvcmUgfmNvbnMgfmRvbXMgfmNvbiB+dGlk Cj4gPj4+fnJpZCB+dHkgfmRhdGEgPQo+ID4+PiAgICAgICAgICAgICAgIGVsc2UKPiA+Pj4gICAg ICAgICAgICAgICAgICAgQ29ubmVjdGlvbi5nZXRfdHJhbnNhY3Rpb24gY29uIHRpZAo+ID4+PiAg ICAgICAgICAgICAgIGluCj4gPj4+LSAgICAgICAgbGV0IHJlc3BvbnNlID0gaW5wdXRfaGFuZGxl X2Vycm9yIH5jb25zIH5kb21zIH5mY3QgfnR5IH5jb24KPiA+Pj5+dCB+cmlkIH5kYXRhIGluCj4g Pj4+KyAgICAgICAgbGV0IHJlc3BvbnNlID0gaW5wdXRfaGFuZGxlX2Vycm9yIH5jb25zIH5kb21z IH5mY3QgfmNvbiB+dAo+ID4+Pn5yZXEgaW4KPiA+Pj4gICAgICAgICAgICAgKCogUHV0IHRoZSBy ZXNwb25zZSBvbiB0aGUgd2lyZSAqKQo+ID4+PiAgICAgICAgICAgc2VuZF9yZXNwb25zZSB0eSBj b24gdCByaWQgcmVzcG9uc2UKPiA+Pj5AQCAtNDEyLDExICs0MTUsMTMgQEAgbGV0IGRvX2lucHV0 IHN0b3JlIGNvbnMgZG9tcyBjb24gPQo+ID4+PiAgICAgICBpZiBuZXdwYWNrZXQgdGhlbiAoCj4g Pj4+ICAgICAgICAgICBsZXQgcGFja2V0ID0gQ29ubmVjdGlvbi5wb3BfaW4gY29uIGluCj4gPj4+ ICAgICAgICAgICBsZXQgdGlkLCByaWQsIHR5LCBkYXRhID0gWGVuYnVzLlhiLlBhY2tldC51bnBh Y2sgcGFja2V0IGluCj4gPj4+KyAgICAgICAgbGV0IHJlcSA9IHtQYWNrZXQudGlkOyBQYWNrZXQu cmlkOyBQYWNrZXQudHk7IFBhY2tldC5kYXRhfSBpbgo+ID4+PisKPiA+PkkgdGhpbmsgdGhpcyBj aGFuZ2UgYnJlYWtzIHRoZSBidWlsZCB3aXRoIG9sZGVyIG9jYW1sIHZlcnNpb25zOgo+ID4+Cj4g Pj5yb290QGhhc3dlbGw+IG9jYW1sb3B0IC12Cj4gPj5UaGUgT0NhbWwgbmF0aXZlLWNvZGUgY29t cGlsZXIsIHZlcnNpb24gNC4wMC4xCj4gPj5TdGFuZGFyZCBsaWJyYXJ5IGRpcmVjdG9yeTogL3Vz ci9saWI2NC9vY2FtbAo+ID4+cm9vdEBoYXN3ZWxsPiBvY2FtbG9wdCAtZyAtY2NvcHQgIiAgICAi IC1kdHlwZXMgLUkKPiA+Pi9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xp YnMveGIgLUkKPiA+Pi9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMv bW1hcCAtSQo+ID4+L3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy94 YyAtSQo+ID4+L3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy9ldmVu dGNobiAtY2MgZ2NjIC13IEYKPiA+Pi13YXJuLWVycm9yIEYgLWMgLW8gcHJvY2Vzcy5jbXggcHJv Y2Vzcy5tbAo+ID4+cm9vdEBoYXN3ZWxsPgo+ID4+Cj4gPj4KPiA+PnJvb3RAb3ZzMTA0PiBvY2Ft bG9wdCAtdgo+ID4+VGhlIE9iamVjdGl2ZSBDYW1sIG5hdGl2ZS1jb2RlIGNvbXBpbGVyLCB2ZXJz aW9uIDMuMTEuMgo+ID4+U3RhbmRhcmQgbGlicmFyeSBkaXJlY3Rvcnk6IC91c3IvbGliNjQvb2Nh bWwKPiA+PnJvb3RAb3ZzMTA0PiBvY2FtbG9wdCAtZyAtY2NvcHQgIiAgICAiIC1kdHlwZXMgLUkK PiA+Pi9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMveGIgLUkKPiA+ Pi9yb290L3RtcC94ZW4vdG9vbHMvb2NhbWwveGVuc3RvcmVkLy4uL2xpYnMvbW1hcCAtSQo+ID4+ L3Jvb3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy94YyAtSQo+ID4+L3Jv b3QvdG1wL3hlbi90b29scy9vY2FtbC94ZW5zdG9yZWQvLi4vbGlicy9ldmVudGNobiAtY2MgZ2Nj IC13IEYKPiA+Pi13YXJuLWVycm9yIEYgLWMgLW8gcHJvY2Vzcy5jbXggcHJvY2Vzcy5tbAo+ID4+ RmlsZSAicHJvY2Vzcy5tbCIsIGxpbmUgNDg3LCBjaGFyYWN0ZXJzIDIzLTI0Ogo+ID4+RXJyb3I6 IFN5bnRheCBlcnJvcgo+ID4+cm9vdEBvdnMxMDQ+Cj4gPj4KPiA+PkkgZG9uJ3Qga25vdyBtdWNo IGFib3V0IG9jYW1sIChPSywgSSBrbm93ICpub3RoaW5nKiBhYm91dCBvY2FtbCkgc28gSQo+ID4+ Y2FuJ3Qgc2F5IHdoYXQgZXhhY3RseSBtaWdodCBiZSB3cm9uZy4KPiA+Q291bGQgeW91IHBlcmhh cHMgdHJ5IHRoaXMgaW5zdGVhZD8KPiA+Cj4gPmxldCByZXEgPSB7dGlkID0gUGFja2V0LnRpZDsg cmlkID0gUGFja2V0LnJpZDsgdHkgPSBQYWNrZXQudHk7IGRhdGEgPQo+ID5QYWNrZXQuZGF0YX0g aW4KPiA+Cj4gPkl0IGlzIG1vc3QgbGlrZWx5IHRoYXQgdGhlIG9sZGVyIHZlcnNpb24gb2YgT2Nh bWwgY2FuJ3QgaW5mZXIgdGhlIG9yZGVyCj4gPm9mIGZpZWxkcy4KPiA+Cj4gPn5BbmRyZXcKPiAK PiAKPiBObywgaXQgbm93IGdpdmVzIG1lICJFcnJvcjogVW5ib3VuZCByZWNvcmQgZmllbGQgbGFi ZWwgdGlkIgo+IAo+IC1ib3JpcwoKQW5kcmV3J3MgZ3Vlc3Mgd2FzIGNsb3NlLCBidXQgdGhlIHdy b25nIHdheSBhcm91bmQgLS0gcGxlYXNlIGNvdWxkIHlvdSB0cnkgdGhlCmZvbGxvd2luZyB3aXRo IHRoZSBvbGRlciBjb21waWxlcj8KCmxldCByZXEgPSB7UGFja2V0LnRpZD10aWQ7IFBhY2tldC5y aWQ9cmlkOyBQYWNrZXQudHk9dHk7IFBhY2tldC5kYXRhPWRhdGF9IGluCgpJIHdhcyB1c2luZyBh IHN5bnRhY3RpYyBmZWF0dXJlIG9mIE9DYW1sIGNhbGxlZCAnZmllbGQgcHVubmluZycgd2hpY2gg aXMKZ2VuZXJhbGx5IGNvbnNpZGVyZWQgZ29vZCBwcmFjdGljZSBhbmQgbWFrZXMgZm9yIG1vcmUg cmVhZGFibGUgY29kZS4gSXQgbG9va3MKbGlrZSB0aGlzIGZlYXR1cmUgd2FzIGludHJvZHVjZWQg aW4gT0NhbWwgMy4xMi4wIChkYXRpbmcgZnJvbSAyMDEwKSwgd2hpY2ggaXMKY29uc2lzdGVudCB3 aXRoIEJvcmlzJyBmaW5kaW5ncy4KCldoYXQncyB0aGUgcG9saWN5IGhlcmUgLS0gaXMgdGhlcmUg YSBkZWZpbmVkIHZlcnNpb24gb2YgdGhlIE9DYW1sIGNvbXBpbGVyIHdoaWNoCnRvb2xzL29jYW1s IG5lZWRzIHRvIGJlIGFibGUgdG8gY29tcGlsZSB3aXRoPwoKVGhhbmtzLApKb25hdGhhbgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94 ZW4tZGV2ZWwK