From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
David Vrabel <david.vrabel@citrix.com>,
Toshi Kani <toshi.kani@hp.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <keir@xen.org>, Juergen Gross <jgross@suse.com>,
X86 ML <x86@kernel.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stuart Hayes <stuart.w.hayes@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Yinghai Lu <yinghai@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Prarit Bhargava <prarit@redhat.com>
Subject: Re: [Xen-devel] MTRR on Xen - BIOS use and implications for Linux
Date: Wed, 30 Mar 2016 00:28:15 +0200 [thread overview]
Message-ID: <20160329222815.GB1990@wotan.suse.de> (raw)
In-Reply-To: <1459289681.6393.714.camel@hpe.com>
On Tue, Mar 29, 2016 at 04:14:41PM -0600, Toshi Kani wrote:
> On Tue, 2016-03-29 at 10:22 -0700, Luis R. Rodriguez wrote:
> > On Thu, Mar 17, 2016 at 11:56 AM, Luis R. Rodriguez <mcgrof@kernel.org>
> > wrote:
> > > On Thu, Mar 17, 2016 at 11:13:03AM +0000, David Vrabel wrote:
> > > > On 16/03/16 20:08, Luis R. Rodriguez wrote:
> > > > > Toshi noted a while ago as well that if BIOS/firmware enables MTRR
> > > > > but the kernel does not have it enabled one issue might have been
> > > > > any MTRRs set up by the BIOS and ensuring the mapping is respected,
> >
> > To be clear the requirement expressed here was needing at least to
> > implement get_mtrr() on the Linux Xen guest side, it'd call the
> > already implemented hypercall XENPF_read_memtype in turn. Toshi had
> > hinted this was perhaps needed on the Linux Xen guest side given that
> > the BIOS may have set up MTRRs on its own, so we needed the guest to
> > be able to get the right type for a particular range. More on that
> > below
>
> No, I did not say that. :-) I said it because you mentioned that you
> wanted to disable MTRRs even though BIOS enabled MTRRs.
>
> My point is that the kernel should not change the MTRR setup. That is:
> - If BIOS enables MTRRs, then kernel needs to keep them enabled.
> - If BIOS disables MTRRs, then the kernel needs to keep them disabled.
>
> Therefore, the kernel can keep MTRRs disabled on Xen guests.
Indeed, thanks for the clarification. That knocks this last concern
out of the way. The remaining aspects then are simply optimizations
considerations.
Luis
prev parent reply other threads:[~2016-03-29 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 20:08 MTRR on Xen - BIOS use and implications for Linux Luis R. Rodriguez
2016-03-17 11:13 ` [Xen-devel] " David Vrabel
2016-03-17 18:56 ` Luis R. Rodriguez
2016-03-29 17:22 ` Luis R. Rodriguez
2016-03-29 22:14 ` Toshi Kani
2016-03-29 22:28 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329222815.GB1990@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=keir@xen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=prarit@redhat.com \
--cc=stuart.w.hayes@gmail.com \
--cc=toshi.kani@hp.com \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).