From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
stefano.stabellini@eu.citrix.com, George.Dunlap@eu.citrix.com,
ian.jackson@eu.citrix.com, cyliu@suse.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v5 3/5] libxl: add new pvusb backend "qusb" provided by qemu
Date: Wed, 30 Mar 2016 17:16:34 +0100 [thread overview]
Message-ID: <20160330161634.GN5656@citrix.com> (raw)
In-Reply-To: <56FBE3EC.40509@suse.com>
On Wed, Mar 30, 2016 at 04:34:20PM +0200, Juergen Gross wrote:
> On 30/03/16 16:19, Wei Liu wrote:
> > On Wed, Mar 30, 2016 at 02:05:56PM +0200, Juergen Gross wrote:
> >> Add a new pvusb backend type "qusb" which is provided by qemu. It can
> >> be selected either by specifying the type directly in the configuration
> >> or it is selected automatically by libxl in case there is no "usbback"
> >> driver loaded.
> >>
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> >> ---
> >> V4: bail out in case of usbback_is_loaded() error as requested by
> >> Chun Yan Liu
> >> ---
> > [...]
> >> /* Add usbctrl information to xenstore.
> >> *
> >> - * Adding a usb controller will add a new 'vusb' device in xenstore, and
> >> - * add corresponding frontend, backend information to it. According to
> >> - * "update_json", decide wether to update json config file.
> >> + * Adding a usb controller will add a new 'qusb' or 'vusb' device in xenstore,
> >> + * and add corresponding frontend, backend information to it. According to
> >> + * "update_json", decide whether to update json config file.
> >> */
> >> static int libxl__device_usbctrl_add_xenstore(libxl__gc *gc, uint32_t domid,
> >> libxl_device_usbctrl *usbctrl,
> >> @@ -121,6 +144,15 @@ static int libxl__device_usbctrl_add_xenstore(libxl__gc *gc, uint32_t domid,
> >>
> >> DEVICE_ADD(usbctrl, usbctrls, domid, &usbctrl_saved,
> >> COMPARE_USBCTRL, &d_config);
> >> +
> >> + if (usbctrl->type == LIBXL_USBCTRL_TYPE_QUSB) {
> >> + if (!libxl__query_qemu_backend(gc, domid, usbctrl->backend_domid,
> >> + "qusb", false)) {
> >
> > This needs to be sorted out.
>
> What do you mean?
>
> > And this is maybe a rather dumb question: the xenstore paths for qusb
> > and kernel backend are the same? What is the likelihood that one
> > deviates from the other? Note that this is not suggesting that you
> > over-engineer current code, it's just something that needs clarifying.
>
> There is an existing pvusb kernel backend implementation in kernel-xen
> of openSUSE and SLE. The port of that implementation hasn't been
> accepted in Linux upstream as it was regarded to fit better in qemu.
>
> So the qemu base backend is designed in a way to be compatible to the
> already existing kernel backend. Future enhancements will be made on the
> qemu based backend only (as far as SUSE is involved).
>
> So the frontend related Xenstore paths are the same, while the backend
> paths are different ("vusb" vs. "qusb"). And yes, I've tested the same
> domU with both backends.
>
I forgot to ask -- When you repost, can you add such information to
commit message? Thanks.
>
> Juergen
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-30 16:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 12:05 [PATCH v5 0/5] libxl: add support for qemu base pvusb backend Juergen Gross
2016-03-30 12:05 ` [PATCH v5 1/5] libxl: make libxl__need_xenpv_qemu() operate on domain config Juergen Gross
2016-03-30 13:38 ` Wei Liu
2016-03-30 14:02 ` Juergen Gross
2016-03-30 12:05 ` [PATCH v5 2/5] libxl: add query function for backend support by device model Juergen Gross
2016-03-30 13:44 ` George Dunlap
2016-03-30 13:59 ` Juergen Gross
2016-03-30 13:53 ` Wei Liu
2016-03-30 14:02 ` Juergen Gross
2016-03-30 14:09 ` Wei Liu
2016-03-30 14:11 ` Juergen Gross
2016-03-30 14:26 ` Wei Liu
2016-03-30 15:55 ` Anthony PERARD
2016-03-30 15:59 ` Wei Liu
2016-03-30 16:07 ` Anthony PERARD
2016-03-30 14:10 ` George Dunlap
2016-03-30 14:27 ` Wei Liu
2016-03-30 12:05 ` [PATCH v5 3/5] libxl: add new pvusb backend "qusb" provided by qemu Juergen Gross
2016-03-30 14:19 ` Wei Liu
2016-03-30 14:34 ` Juergen Gross
2016-03-30 14:38 ` Wei Liu
2016-03-30 16:16 ` Wei Liu [this message]
2016-03-30 17:09 ` Juergen Gross
2016-03-30 12:05 ` [PATCH v5 4/5] libxl: add service function to check whether device model is running Juergen Gross
2016-03-30 12:05 ` [PATCH v5 5/5] libxl: check for dynamic device model start required Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330161634.GN5656@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=cyliu@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).