From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 08/10] libxl: improve main_tmem_* return
	codes
Date: Fri, 1 Apr 2016 11:09:15 -0400
Message-ID: <20160401150915.GC22004@char.us.oracle.com>
References: <1459514413-18682-1-git-send-email-paulinaszubarczyk@gmail.com>
 <1459514413-18682-9-git-send-email-paulinaszubarczyk@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <konrad@char.us.oracle.com>) id 1am0hR-0007LU-ED
 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2016 15:09:25 +0000
Content-Disposition: inline
In-Reply-To: <1459514413-18682-9-git-send-email-paulinaszubarczyk@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, George.Dunlap@eu.citrix.com, dario.faggioli@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com
List-Id: xen-devel@lists.xenproject.org

T24gRnJpLCBBcHIgMDEsIDIwMTYgYXQgMDI6NDA6MTFQTSArMDIwMCwgUGF1bGluYSBTenViYXJj
enlrIHdyb3RlOgo+IEZ1bmN0aW9ucyBsaWJ4bF90bWVtX2ZyZWV6ZSgpLCBsaWJ4bF90bWVtX3Ro
YXcoKSwgbGlieGxfdG1lbV9zZXQoKSBhbmQKPiBsaWJ4bF90bWVtX3NoYXJlZF9hdXRoKCkgbG9j
YXRlZCBpbiBsaWJ4bC5jIGZpbGUgcmV0dXJuIEVSUk9SX0ZBSUwvRVJST1JfSU5WQUwgCj4gb3Ig
aW50ZXJuYWwgZXJyb3IgY29kZXMgZnJvbSBsaWJ4YyBsaWJyYXJ5Lgo+IAo+IEltcHJvdmUgbWFp
bl90bWVtXyogcmV0dXJuIGNvZGVzIGJ5IHJldHVybmluZyBFWElUX3tTVUNDRVNTL0ZBSUxVUkV9
Cj4gYWNjb3JkaW5nbHkgdG8gcmV0dXJuIGNvZGVzIG9mIHRob3NlIGZ1bmN0aW9ucy4KPiAKPiBT
aWduZWQtb2ZmLWJ5OiBQYXVsaW5hIFN6dWJhcmN6eWsgPHBhdWxpbmFzenViYXJjenlrQGdtYWls
LmNvbT4KClJldmlld2VkLWJ5OiBLb25yYWQgUnplc3p1dGVrIFdpbGsgPGtvbnJhZC53aWxrQG9y
YWNsZS5jb20+LCBhbGJlaXQKClRoZSBDT0RJTkdfU1RZTEUgc2F5czoKRXZlcnkgaW5kZW50ZWQg
c3RhdGVtZW50IGlzIGJyYWNlZCBhcGFydCBmcm9tIGJsb2NrcyB0aGF0IGNvbnRhaW4ganVzdApv
bmUgc3RhdGVtZW50LiIKCldoaWNoIGlzIG5vdCB2ZXJ5IGNsZWFyLiBJIHRoaW5rIGl0IGlzIG1p
c3NpbmcgYW4gJywnLCB3aGljaCB3b3VsZCBtYWtlIGl0CgpFdmVyeSBpbmRlbnRlZCBzdGF0ZW1l
bnQgaXMgYnJhY2VkLCBhcGFydCBmcm9tIGJsb2NrcyB0aGF0IGNvbnRhaW4ganVzdCBvbmUgc3Rh
dGVtZW50LgoKV2hpY2ggbWVhbnMgdGhhdDoKCj4gLS0tCj4gIHRvb2xzL2xpYnhsL3hsX2NtZGlt
cGwuYyB8IDUxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t
LQo+ICAxIGZpbGUgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCj4g
Cj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYyBiL3Rvb2xzL2xpYnhsL3hs
X2NtZGltcGwuYwo+IGluZGV4IDM4MTI5ZjQuLjUyYzNiOWIgMTAwNjQ0Cj4gLS0tIGEvdG9vbHMv
bGlieGwveGxfY21kaW1wbC5jCj4gKysrIGIvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCj4gQEAg
LTc1MTksNyArNzUxOSw3IEBAIGludCBtYWluX3RtZW1fZnJlZXplKGludCBhcmdjLCBjaGFyICoq
YXJndikKPiAgICAgIGlmICghZG9tICYmIGFsbCA9PSAwKSB7Cj4gICAgICAgICAgZnByaW50Zihz
dGRlcnIsICJZb3UgbXVzdCBzcGVjaWZ5IC1hIG9yIGEgZG9tYWluIGlkLlxuXG4iKTsKPiAgICAg
ICAgICBoZWxwKCJ0bWVtLWZyZWV6ZSIpOwo+IC0gICAgICAgIHJldHVybiAxOwo+ICsgICAgICAg
IHJldHVybiBFWElUX0ZBSUxVUkU7Cj4gICAgICB9Cj4gIAo+ICAgICAgaWYgKGFsbCkKPiBAQCAt
NzUyNyw4ICs3NTI3LDExIEBAIGludCBtYWluX3RtZW1fZnJlZXplKGludCBhcmdjLCBjaGFyICoq
YXJndikKPiAgICAgIGVsc2UKPiAgICAgICAgICBkb21pZCA9IGZpbmRfZG9tYWluKGRvbSk7Cj4g
IAo+IC0gICAgbGlieGxfdG1lbV9mcmVlemUoY3R4LCBkb21pZCk7Cj4gLSAgICByZXR1cm4gMDsK
PiArICAgIGlmIChsaWJ4bF90bWVtX2ZyZWV6ZShjdHgsIGRvbWlkKSA8IDApIHsKPiArICAgICAg
ICByZXR1cm4gRVhJVF9GQUlMVVJFOwo+ICsgICAgfQoKVGhpcyBhbmQgdGhlIG90aGVyIHRocmVl
IGNhbiBkcm9wIHRoZSBicmFjZXMuCgo+ICsKPiArICAgIHJldHVybiBFWElUX1NVQ0NFU1M7Cj4g
IH0KPiAgCj4gIGludCBtYWluX3RtZW1fdGhhdyhpbnQgYXJnYywgY2hhciAqKmFyZ3YpCj4gQEAg
LTc1NDgsNyArNzU1MSw3IEBAIGludCBtYWluX3RtZW1fdGhhdyhpbnQgYXJnYywgY2hhciAqKmFy
Z3YpCj4gICAgICBpZiAoIWRvbSAmJiBhbGwgPT0gMCkgewo+ICAgICAgICAgIGZwcmludGYoc3Rk
ZXJyLCAiWW91IG11c3Qgc3BlY2lmeSAtYSBvciBhIGRvbWFpbiBpZC5cblxuIik7Cj4gICAgICAg
ICAgaGVscCgidG1lbS10aGF3Iik7Cj4gLSAgICAgICAgcmV0dXJuIDE7Cj4gKyAgICAgICAgcmV0
dXJuIEVYSVRfRkFJTFVSRTsKPiAgICAgIH0KPiAgCj4gICAgICBpZiAoYWxsKQo+IEBAIC03NTU2
LDggKzc1NTksMTEgQEAgaW50IG1haW5fdG1lbV90aGF3KGludCBhcmdjLCBjaGFyICoqYXJndikK
PiAgICAgIGVsc2UKPiAgICAgICAgICBkb21pZCA9IGZpbmRfZG9tYWluKGRvbSk7Cj4gIAo+IC0g
ICAgbGlieGxfdG1lbV90aGF3KGN0eCwgZG9taWQpOwo+IC0gICAgcmV0dXJuIDA7Cj4gKyAgICBp
ZiAobGlieGxfdG1lbV90aGF3KGN0eCwgZG9taWQpIDwgMCkgewo+ICsgICAgICAgIHJldHVybiBF
WElUX0ZBSUxVUkU7Cj4gKyAgICB9Cj4gKwo+ICsgICAgcmV0dXJuIEVYSVRfU1VDQ0VTUzsKPiAg
fQo+ICAKPiAgaW50IG1haW5fdG1lbV9zZXQoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+IEBAIC03
NTY4LDYgKzc1NzQsNyBAQCBpbnQgbWFpbl90bWVtX3NldChpbnQgYXJnYywgY2hhciAqKmFyZ3Yp
Cj4gICAgICBpbnQgb3B0X3cgPSAwLCBvcHRfYyA9IDAsIG9wdF9wID0gMDsKPiAgICAgIGludCBh
bGwgPSAwOwo+ICAgICAgaW50IG9wdDsKPiArICAgIGludCByID0gMDsKPiAgCj4gICAgICBTV0lU
Q0hfRk9SRUFDSF9PUFQob3B0LCAiYXc6YzpwOiIsIE5VTEwsICJ0bWVtLXNldCIsIDApIHsKPiAg
ICAgIGNhc2UgJ2EnOgo+IEBAIC03NTkxLDcgKzc1OTgsNyBAQCBpbnQgbWFpbl90bWVtX3NldChp
bnQgYXJnYywgY2hhciAqKmFyZ3YpCj4gICAgICBpZiAoIWRvbSAmJiBhbGwgPT0gMCkgewo+ICAg
ICAgICAgIGZwcmludGYoc3RkZXJyLCAiWW91IG11c3Qgc3BlY2lmeSAtYSBvciBhIGRvbWFpbiBp
ZC5cblxuIik7Cj4gICAgICAgICAgaGVscCgidG1lbS1zZXQiKTsKPiAtICAgICAgICByZXR1cm4g
MTsKPiArICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwo+ICAgICAgfQo+ICAKPiAgICAgIGlm
IChhbGwpCj4gQEAgLTc2MDIsMTcgKzc2MDksMjEgQEAgaW50IG1haW5fdG1lbV9zZXQoaW50IGFy
Z2MsIGNoYXIgKiphcmd2KQo+ICAgICAgaWYgKCFvcHRfdyAmJiAhb3B0X2MgJiYgIW9wdF9wKSB7
Cj4gICAgICAgICAgZnByaW50ZihzdGRlcnIsICJObyBzZXQgdmFsdWUgc3BlY2lmaWVkLlxuXG4i
KTsKPiAgICAgICAgICBoZWxwKCJ0bWVtLXNldCIpOwo+IC0gICAgICAgIHJldHVybiAxOwo+ICsg
ICAgICAgIHJldHVybiBFWElUX0ZBSUxVUkU7Cj4gICAgICB9Cj4gIAo+ICAgICAgaWYgKG9wdF93
KQo+IC0gICAgICAgIGxpYnhsX3RtZW1fc2V0KGN0eCwgZG9taWQsICJ3ZWlnaHQiLCB3ZWlnaHQp
Owo+ICsgICAgICAgIHIgPSBsaWJ4bF90bWVtX3NldChjdHgsIGRvbWlkLCAid2VpZ2h0Iiwgd2Vp
Z2h0KTsKPiAgICAgIGlmIChvcHRfYykKPiAtICAgICAgICBsaWJ4bF90bWVtX3NldChjdHgsIGRv
bWlkLCAiY2FwIiwgY2FwKTsKPiArICAgICAgICByID0gbGlieGxfdG1lbV9zZXQoY3R4LCBkb21p
ZCwgImNhcCIsIGNhcCk7Cj4gICAgICBpZiAob3B0X3ApCj4gLSAgICAgICAgbGlieGxfdG1lbV9z
ZXQoY3R4LCBkb21pZCwgImNvbXByZXNzIiwgY29tcHJlc3MpOwo+ICsgICAgICAgIHIgPSBsaWJ4
bF90bWVtX3NldChjdHgsIGRvbWlkLCAiY29tcHJlc3MiLCBjb21wcmVzcyk7Cj4gIAo+IC0gICAg
cmV0dXJuIDA7Cj4gKyAgICBpZiAociA8IDApIHsKPiArICAgICAgICByZXR1cm4gRVhJVF9GQUlM
VVJFOwo+ICsgICAgfQo+ICsKPiArICAgIHJldHVybiBFWElUX1NVQ0NFU1M7Cj4gIH0KPiAgCj4g
IGludCBtYWluX3RtZW1fc2hhcmVkX2F1dGgoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+IEBAIC03
NjQyLDcgKzc2NTMsNyBAQCBpbnQgbWFpbl90bWVtX3NoYXJlZF9hdXRoKGludCBhcmdjLCBjaGFy
ICoqYXJndikKPiAgICAgIGlmICghZG9tICYmIGFsbCA9PSAwKSB7Cj4gICAgICAgICAgZnByaW50
ZihzdGRlcnIsICJZb3UgbXVzdCBzcGVjaWZ5IC1hIG9yIGEgZG9tYWluIGlkLlxuXG4iKTsKPiAg
ICAgICAgICBoZWxwKCJ0bWVtLXNoYXJlZC1hdXRoIik7Cj4gLSAgICAgICAgcmV0dXJuIDE7Cj4g
KyAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiAgICAgIH0KPiAgCj4gICAgICBpZiAoYWxs
KQo+IEBAIC03NjUzLDE4ICs3NjY0LDIwIEBAIGludCBtYWluX3RtZW1fc2hhcmVkX2F1dGgoaW50
IGFyZ2MsIGNoYXIgKiphcmd2KQo+ICAgICAgaWYgKHV1aWQgPT0gTlVMTCB8fCBhdXRoYXJnID09
IE5VTEwpIHsKPiAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIk5vIHV1aWQgb3IgYXV0aCBzcGVj
aWZpZWQuXG5cbiIpOwo+ICAgICAgICAgIGhlbHAoInRtZW0tc2hhcmVkLWF1dGgiKTsKPiAtICAg
ICAgICByZXR1cm4gMTsKPiArICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwo+ICAgICAgfQo+
ICAKPiAgICAgIGF1dGggPSBzdHJ0b2woYXV0aGFyZywgJmVuZHB0ciwgMTApOwo+ICAgICAgaWYg
KCplbmRwdHIgIT0gJ1wwJykgewo+ICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiSW52YWxpZCBh
dXRoLCB2YWxpZCBhdXRoIGFyZSA8MHwxPi5cblxuIik7Cj4gLSAgICAgICAgcmV0dXJuIDE7Cj4g
KyAgICAgICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiAgICAgIH0KPiAgCj4gLSAgICBsaWJ4bF90
bWVtX3NoYXJlZF9hdXRoKGN0eCwgZG9taWQsIHV1aWQsIGF1dGgpOwo+ICsgICAgaWYgKGxpYnhs
X3RtZW1fc2hhcmVkX2F1dGgoY3R4LCBkb21pZCwgdXVpZCwgYXV0aCkgPCAwKSB7Cj4gKyAgICAg
ICAgcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiArICAgIH0KPiAgCj4gLSAgICByZXR1cm4gMDsKPiAr
ICAgIHJldHVybiBFWElUX1NVQ0NFU1M7Cj4gIH0KPiAgCj4gIGludCBtYWluX3RtZW1fZnJlZWFi
bGUoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+IEBAIC03Njc4LDEwICs3NjkxLDEwIEBAIGludCBt
YWluX3RtZW1fZnJlZWFibGUoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ICAKPiAgICAgIG1iID0g
bGlieGxfdG1lbV9mcmVlYWJsZShjdHgpOwo+ICAgICAgaWYgKG1iID09IC0xKQo+IC0gICAgICAg
IHJldHVybiAtMTsKPiArICAgICAgICByZXR1cm4gRVhJVF9GQUlMVVJFOwo+ICAKPiAgICAgIHBy
aW50ZigiJWRcbiIsIG1iKTsKPiAtICAgIHJldHVybiAwOwo+ICsgICAgcmV0dXJuIEVYSVRfU1VD
Q0VTUzsKPiAgfQo+ICAKPiAgaW50IG1haW5fY3B1cG9vbGNyZWF0ZShpbnQgYXJnYywgY2hhciAq
KmFyZ3YpCj4gLS0gCj4gMS45LjEKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwo+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKPiBYZW4tZGV2ZWxA
bGlzdHMueGVuLm9yZwo+IGh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAoKX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg
bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2
ZWwK