From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: xen-devel@lists.xen.org, minios-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, srn@prgmr.com
Subject: Re: [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483
Date: Fri, 1 Apr 2016 20:26:43 +0200 [thread overview]
Message-ID: <20160401182643.GF3008@var.home> (raw)
In-Reply-To: <1459534621-12514-1-git-send-email-samuel.thibault@ens-lyon.org>
Samuel Thibault, on Fri 01 Apr 2016 20:17:01 +0200, wrote:
> 7c8f3483 introduced a break within a loop in netfront.c such that
> cons and nr_consumed were no longer always being incremented. The
> offset at cons will be processed multiple times with the break in
> place.
>
> This commit reverts to using the "some" variable in the loop condition,
> but avoids ifdefs for the non-libc case. It also renames it to dobreak
> to make its usage clearer.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Tested-by: Sarah Newman <srn@prgmr.com>
Please do not commit this one, but the coming mail.
Samuel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-01 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 18:17 [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483 Samuel Thibault
2016-04-01 18:26 ` Samuel Thibault [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-01 18:26 Samuel Thibault
2016-04-04 10:28 ` Wei Liu
2016-04-25 11:14 ` Wei Liu
2016-03-23 21:26 Sarah Newman
2016-03-25 13:09 ` Wei Liu
2016-03-25 18:33 ` Samuel Thibault
2016-03-25 19:19 ` Sarah Newman
2016-03-25 19:32 ` Samuel Thibault
2016-03-25 19:56 ` Sarah Newman
2016-03-26 20:53 ` Sarah Newman
2016-03-30 13:46 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401182643.GF3008@var.home \
--to=samuel.thibault@ens-lyon.org \
--cc=minios-devel@lists.xenproject.org \
--cc=srn@prgmr.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).