From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: KVM list <kvm@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
X86 ML <x86@kernel.org>,
linux-kernel@vger.kernel.org, xen-devel <Xen-devel@lists.xen.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] x86/extable: Add a comment about early exception handlers
Date: Mon, 4 Apr 2016 18:16:34 +0200 [thread overview]
Message-ID: <20160404161634.GH351__15004.6396920972$1459786674$gmane$org@pd.tnic> (raw)
In-Reply-To: <5f1dcd6919f4a5923959a8065cb2c04d9dac1412.1459784772.git.luto@kernel.org>
On Mon, Apr 04, 2016 at 08:46:22AM -0700, Andy Lutomirski wrote:
> Borislav asked for a comment explaining why all exception handlers are
> allowed early.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> arch/x86/mm/extable.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c
> index 98b5f45d9d79..36fe03bc81ee 100644
> --- a/arch/x86/mm/extable.c
> +++ b/arch/x86/mm/extable.c
> @@ -132,6 +132,20 @@ void __init early_fixup_exception(struct pt_regs *regs, int trapnr)
> if (regs->cs != __KERNEL_CS)
> goto fail;
>
> + /*
> + * The full exception fixup machinery is available as soon as
> + * the early IDT is loaded. This means that it is the
> + * responsibility of extable users to either function correctly
> + * when handlers are invoked early or to simply avoid causing
> + * exceptions before they're ready to handle them.
> + *
> + * This is better than filtering which handlers can be used,
> + * because refusing to call a handler here is guaranteed to
> + * result in a hard-to-debug panic.
> + *
> + * Keep in mind that not all vectors actually get here. Early
> + * fage faults, for example, are special.
> + */
> if (fixup_exception(regs, trapnr))
> return;
>
> --
Thanks!
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next parent reply other threads:[~2016-04-04 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5f1dcd6919f4a5923959a8065cb2c04d9dac1412.1459784772.git.luto@kernel.org>
2016-04-04 16:16 ` Borislav Petkov [this message]
2016-04-13 11:46 ` [tip:x86/asm] x86/extable: Add a comment about early exception handlers tip-bot for Andy Lutomirski
2016-04-04 15:46 [PATCH] " Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20160404161634.GH351__15004.6396920972$1459786674$gmane$org@pd.tnic' \
--to=bp@alien8.de \
--cc=Xen-devel@lists.xen.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).