xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	"Changlong Xie" <xiecl.fnst@cn.fujitsu.com>,
	"Wei Liu" <wei.liu2@citrix.com>,
	"Ian Jackson" <Ian.Jackson@eu.citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 0/3] COLO: only build on Linux
Date: Wed, 6 Apr 2016 11:17:56 +0100	[thread overview]
Message-ID: <20160406101756.GH18120@citrix.com> (raw)
In-Reply-To: <5704654A.3080101@cn.fujitsu.com>

On Wed, Apr 06, 2016 at 09:24:26AM +0800, Wen Congyang wrote:
> On 04/06/2016 04:05 AM, Wei Liu wrote:
> > COLO depends on netlink which is only available on Linux. This series cleans up
> > COLO code and make it only build on Linux. This should fix FreeBSD build.
> > 
> > Congyang and Changlong, please review this series as soon as possible. I also
> > have a question why COLO doesn't use libnl? It is using Linux header directly.
> 
> It is implemented by Yang one year ago. I don't know the reason. We will investigate
> how to use libnl.
> 

It's easy -- change inclusion of linux/netlink.h to netlink/netlink.h. I
already have a series to do that -- this series is actually my second
attempt to fix COLO.

If you can confirm COLO should depend on libnl, I will post my patches.

Wei.

> Thanks
> Wen Congyang
> 
> > 
> > Roger, can you run functional tests on FreeBSD? I don't have FreeBSD Dom0.
> > 
> > Wei.
> > 
> > Wei Liu (3):
> >   libxl: colo: rearrange things in header files
> >   libxl: colo: move netlink related stuff to libxl_colo_proxy.c
> >   libxl: colo: only build COLO on Linux
> > 
> >  tools/libxl/Makefile           |  5 ++++
> >  tools/libxl/libxl_colo.h       | 52 +++++++++++++++++------------------
> >  tools/libxl/libxl_colo_proxy.c | 13 +++++++++
> >  tools/libxl/libxl_internal.h   | 36 ++++++++----------------
> >  tools/libxl/libxl_no_colo.c    | 62 ++++++++++++++++++++++++++++++++++++++++++
> >  5 files changed, 117 insertions(+), 51 deletions(-)
> >  create mode 100644 tools/libxl/libxl_no_colo.c
> > 
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-06 10:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 20:05 Wei Liu
2016-04-05 20:06 ` [PATCH 1/3] libxl: colo: rearrange things in header files Wei Liu
2016-04-06 13:41   ` Ian Jackson
2016-04-05 20:06 ` [PATCH 2/3] libxl: colo: move netlink related stuff to libxl_colo_proxy.c Wei Liu
2016-04-06 13:41   ` Ian Jackson
2016-04-05 20:06 ` [PATCH 3/3] libxl: colo: only build COLO on Linux Wei Liu
2016-04-06 10:24   ` Wei Liu
2016-04-06  1:24 ` [PATCH 0/3] COLO: only build " Wen Congyang
2016-04-06 10:17   ` Wei Liu [this message]
2016-04-06 10:20     ` Wen Congyang
2016-04-06 10:22       ` Wei Liu
2016-04-06  6:19 ` Changlong Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406101756.GH18120@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xiecl.fnst@cn.fujitsu.com \
    --subject='Re: [PATCH 0/3] COLO: only build on Linux' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).