From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v11 1/2] libxl: add support for vscsi
Date: Fri, 8 Apr 2016 12:18:32 +0200 [thread overview]
Message-ID: <20160408101832.GA2811@aepfle.de> (raw)
In-Reply-To: <1460098891-13278-2-git-send-email-olaf@aepfle.de>
On Fri, Apr 08, Olaf Hering wrote:
> +int xlu_vscsi_get_ctrl(XLU_Config *cfg, libxl_ctx *ctx, uint32_t domid,
> + const char *str,
> + libxl_device_vscsictrl *ctrl,
> + libxl_device_vscsidev *dev,
> + libxl_device_vscsictrl **existing)
> + if (found_ctrl == -1) {
> + *existing = NULL;
> +int main_vscsiattach(int argc, char **argv)
> + libxl_device_vscsictrl ctrl, *existing = NULL;
> + existing = xmalloc(sizeof(*existing));
> + libxl_device_vscsictrl_init(existing);
This handling of 'existing' is bogus, I will rework it. Not sure what I
had in mind here...
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-08 10:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 7:01 [PATCH v11 0/2] libxl: add support for pvscsi, iteration 11 Olaf Hering
2016-04-08 7:01 ` [PATCH v11 1/2] libxl: add support for vscsi Olaf Hering
2016-04-08 8:53 ` Juergen Gross
2016-04-08 10:18 ` Olaf Hering [this message]
2016-04-08 12:06 ` Wei Liu
2016-04-08 13:47 ` Ian Jackson
2016-04-08 14:49 ` Wei Liu
2016-04-08 14:16 ` Olaf Hering
2016-04-08 14:23 ` Wei Liu
2016-04-08 15:43 ` Olaf Hering
2016-04-11 12:57 ` Olaf Hering
2016-04-11 13:02 ` Wei Liu
2016-04-08 14:41 ` Wei Liu
2016-04-08 7:01 ` [PATCH v11 2/2] Scripts to create and delete xen-scsiback nodes in Linux target framework Olaf Hering
2016-04-08 11:05 ` Wei Liu
2016-04-08 11:07 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408101832.GA2811@aepfle.de \
--to=olaf@aepfle.de \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).