From: Wei Liu <wei.liu2@citrix.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Wen Congyang <wency@cn.fujitsu.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()
Date: Mon, 11 Apr 2016 13:36:14 +0100 [thread overview]
Message-ID: <20160411123614.GI1346@citrix.com> (raw)
In-Reply-To: <1460377204-12550-1-git-send-email-vkuznets@redhat.com>
Sorry for breaking it!
On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote:
> c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft
> reset as libxl__domain_suspend_device_model() now fails when domid in not set
> in libxl__domain_suspend_state.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
What sort of arrangement is needed to get this tested? Any specific
kernel version etc?
> ---
> tools/libxl/libxl_create.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index f1028bc..f8d5e36 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -1700,7 +1700,7 @@ static int do_domain_soft_reset(libxl_ctx *ctx,
> free(xs_console_mfn);
>
> dss->ao = ao;
> - dss->domid = domid_soft_reset;
> + dss->domid = dss->dsps.domid = domid_soft_reset;
> dss->dsps.dm_savefile = GCSPRINTF(LIBXL_DEVICE_MODEL_SAVE_FILE".%d",
> domid_soft_reset);
>
> --
> 2.5.5
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-11 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 12:20 [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset() Vitaly Kuznetsov
2016-04-11 12:36 ` Wei Liu [this message]
2016-04-11 12:53 ` Vitaly Kuznetsov
2016-04-11 13:09 ` Wei Liu
2016-04-14 17:36 ` Wei Liu
2016-04-15 10:59 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411123614.GI1346@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=vkuznets@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).