From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien.grall@linaro.org>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
bp@alien8.de, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, rusty@rustcorp.com.au, x86@kernel.org,
linux-kernel@vger.kernel.org, luto@amacapital.net,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
konrad.wilk@oracle.com, xen-devel@lists.xensource.com,
lguest@lists.ozlabs.org, andriy.shevchenko@linux.intel.com,
jlee@suse.com, glin@suse.com, matt@codeblueprint.co.uk,
andrew.cooper3@citrix.com, rjw@rjwysocki.net, lenb@kernel.org,
robert.moore@intel.com, lv.zheng@intel.com, toshi.kani@hp.com,
linux-acpi@vger.kernel.org, kozerkov@parallels.com,
josh@joshtriplett.org, joro@8bytes.org, tiwai@suse.de,
sathyanarayanan.kuppuswamy@linux.intel.com, alan@linux.intel.com,
rui.zhang@intel.com, mbizon@freebox.fr, ffainelli@freebox.fr
Subject: Re: [PATCH v1 0/2] x86/init: extend quirk use
Date: Wed, 13 Apr 2016 00:30:12 +0200 [thread overview]
Message-ID: <20160412223012.GO1990@wotan.suse.de> (raw)
In-Reply-To: <570B52EA.60300@linutronix.de>
On Mon, Apr 11, 2016 at 09:31:54AM +0200, Sebastian Andrzej Siewior wrote:
> On 04/09/2016 02:22 AM, Luis R. Rodriguez wrote:
> > What seems a bit odd is CE4100 leaves RTC enabled, can someone
> > confirm if indeed it really needs it, or can it also disable it
> > as with Xen, lguest, and Intel MID ?
>
> So what you do with "x86_platform.legacy.rtc" is to skip
> add_rtc_cmos().
Yeap.
> For ce4100 I added of_have_populated_dt() to skip the probe.
Ah look at that.. x86 using device tree. Wasn't aware.
> If you plan to add this to CE4100 you could remove the
> "of_have_populated_dt()". It was meant to skip the RTC probe on all OF
> platforms but as of now, CE4100 is the only.
Indeed, this would clean up the add_rtc_cmos() path more and make
the semantics required for this a platform specific quirk which can
instead more easily be set by the platform on the generic:
x86_early_init_platform_quirks()
Will go a head and remove this hack as part of the CE4100 patch, and
also add CE4100 to the list of subarchs that need the RTC quirk.
Luis
next prev parent reply other threads:[~2016-04-12 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 0:22 [PATCH v1 0/2] x86/init: extend quirk use Luis R. Rodriguez
2016-04-09 0:22 ` [PATCH v1 1/2] x86/init: disable pnpbios for X86_SUBARCH_INTEL_MID Luis R. Rodriguez
2016-04-13 23:33 ` Luis R. Rodriguez
2016-04-09 0:22 ` [PATCH v1 2/2] x86/init: disable pnpbios for X86_SUBARCH_CE4100 Luis R. Rodriguez
2016-04-11 7:31 ` [PATCH v1 0/2] x86/init: extend quirk use Sebastian Andrzej Siewior
2016-04-12 22:30 ` Luis R. Rodriguez [this message]
2016-04-12 22:44 ` [PATCH v2] x86/init: disable pnpbios and rtc for X86_SUBARCH_CE4100 Luis R. Rodriguez
2016-04-13 23:36 ` [PATCH v1 0/2] x86/init: extend quirk use Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412223012.GO1990@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=alan@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=ffainelli@freebox.fr \
--cc=george.dunlap@citrix.com \
--cc=glin@suse.com \
--cc=hpa@zytor.com \
--cc=jlee@suse.com \
--cc=joro@8bytes.org \
--cc=josh@joshtriplett.org \
--cc=julien.grall@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=kozerkov@parallels.com \
--cc=lenb@kernel.org \
--cc=lguest@lists.ozlabs.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=lv.zheng@intel.com \
--cc=matt@codeblueprint.co.uk \
--cc=mbizon@freebox.fr \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=rui.zhang@intel.com \
--cc=rusty@rustcorp.com.au \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).