From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Kletzander Subject: Re: [libvirt] [PATCH] libxl: use LIBXL_API_VERSION 0x040200 Date: Thu, 14 Apr 2016 10:11:08 +0200 Message-ID: <20160414081108.GH5325@wheatley> References: <1460590625-3805-1-git-send-email-jfehlig@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4180115552723133057==" Return-path: In-Reply-To: <1460590625-3805-1-git-send-email-jfehlig@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jim Fehlig Cc: libvir-list@redhat.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============4180115552723133057== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oyqLL/JqMvClXZi1" Content-Disposition: inline --oyqLL/JqMvClXZi1 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Wed, Apr 13, 2016 at 05:37:05PM -0600, Jim Fehlig wrote: >To ensure the libvirt libxl driver will build with future versions >of Xen where the libxl API may change in incompatible ways, >explicitly use LIBXL_API_VERSION 0x040200. The libxl driver >does use new libxl APIs that have been added since Xen 4.2, but >currently it does not make use of any changes made to existing >APIs such as libxl_domain_create_restore or libxl_set_vcpuaffinity. >The version can be bumped if/when the libxl driver consumes the >changed APIs. > >Further details can be found in the following discussion thread > >https://www.redhat.com/archives/libvir-list/2016-April/msg00178.html >Signed-off-by: Jim Fehlig >--- > src/Makefile.am | 1 + > src/libxl/libxl_conf.h | 12 ------------ > src/libxl/libxl_domain.c | 15 --------------- > 3 files changed, 1 insertion(+), 27 deletions(-) > >diff --git a/src/Makefile.am b/src/Makefile.am >index 08ff301..259a474 100644 >--- a/src/Makefile.am >+++ b/src/Makefile.am >@@ -1311,6 +1311,7 @@ endif ! WITH_DRIVER_MODULES > > libvirt_driver_libxl_impl_la_CFLAGS = \ > $(LIBXL_CFLAGS) \ >+ -DLIBXL_API_VERSION=0x040200 \ Adding it to LIBXL_CFLAGS in configure.ac would make it show after configure, but that's something probably only I would find interesting =) I'm no libxl expert and I don't have it on my system, so I can't try building it, hence only weak ACK from me. If it build for you then it's fine as nobody objects as I see. --oyqLL/JqMvClXZi1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXD1CcAAoJEAgfwp8kF4bdDZwQALBuBa4yQcx4pjXERfC/867Y 0oG4Gxc2PCxUW+DC5MT5N3ZveA4fz2/6O6qvwtDvE6j1xv0Od3ABiZhcqvcSkJW1 VkwSzi5IQimPnyZ6QUW2aaQaaYafTPqrMExPOD9LQ6A55SOMAdrklR/c3NWGJbRk rvEO8r9zMzK9S4mAgbzlg73sIBhqptbMrBuyjjqXMWNRlBU0ky2pKN1dMMIwGWnM OvUhXZFhv54Wu26AfrYu6v7xdTaUMbCJwVDPgTMy8/bv+zPJ8D5yx9cPpYtvqEtu lKqtUnjwJc0hEXr5tp79+lRZp2nIKLYlCcCOJUo+zdHIF3YbwwfUbipa+0iQTM0q P4/h3jSFYcrbHrJieYom4EPiRAkjNelwSLe3GWeBCxby4rrJo13KK6JU28uziLe+ s2MAOb7obEFhaipcB58YIy2dD6DamCn0YZFHLJzP2yGPPZP9dSMayeGNbPlVTiEL r9/6zHAg5+jPiBylLSEssaCP0xod8qwroMR5poUYC8qNyBNRLeffc2sWQTqIFMQ0 JQIjTin7kJXTZ6y0Vd+51TygBbjg3QWn5LaHrpJkIp81PtrjYSPPb3QnGl65BEEG VCiMVGxfQDPfAO8KT7BeBm6mKXGyvWiOxu9L9VISoA3tvKnOTgpUvIZVWxyVKYHF b4VW/JzpVTtojI1yVVAK =pnoy -----END PGP SIGNATURE----- --oyqLL/JqMvClXZi1-- --===============4180115552723133057== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============4180115552723133057==--