From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
LibVirt Development List <libvir-list@redhat.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jim Fehlig <jfehlig@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?
Date: Fri, 15 Apr 2016 11:14:28 +0200 [thread overview]
Message-ID: <20160415091427.GA11031@gmail.com> (raw)
In-Reply-To: <22287.55938.127421.636018@mariner.uk.xensource.com>
On Thu, Apr 14, Ian Jackson wrote:
> Dario Faggioli writes ("Re: [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"):
> > And, in those cases, usage should be gated by the appropriate
> > LIBXL_HAVE_FOOBAR symbol, which I see in the sources (e.g.,
> > for LIBXL_HAVE_NO_SUSPEND_RESUME or LIBXL_HAVE_DOMAIN_NODEAFFINITY) to
> > be the case, so good again. :-)
>
> If libvirt specifies LIBXL_API_VERSION then it does not need to check
> any LIBXL_HAVE_*, since it will actually get an API corresponding to
> the specified API_VERSION.
This cant be true, because otherwise it will be unable to use vscsi and
perhaps usb (and whatever else showed up after 4.2).
Does that also mean that for example things related to LIBXL_HAVE_VSCSI
need to be wrapped in "#if LIBXL_API_VERSION > $whatever"? Maybe I'm
just misunderstand what you are trying to say.
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-15 9:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160405113936.GA18120@citrix.com>
2016-04-12 21:31 ` Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION? Jim Fehlig
[not found] ` <570D6942.8020106@suse.com>
2016-04-12 22:06 ` Wei Liu
2016-04-13 9:09 ` George Dunlap
2016-04-13 9:26 ` [libvirt] " Daniel P. Berrange
[not found] ` <20160413092654.GE8847@redhat.com>
2016-04-13 9:50 ` George Dunlap
2016-04-13 13:28 ` Wei Liu
2016-04-13 23:44 ` Jim Fehlig
[not found] ` <570ED9DF.5070606@suse.com>
2016-06-27 15:33 ` Ian Jackson
2016-06-27 15:54 ` Ian Jackson
2016-06-27 16:03 ` Daniel P. Berrange
2016-06-27 16:12 ` Ian Jackson
2016-06-27 16:17 ` Daniel P. Berrange
2016-06-27 16:35 ` Jim Fehlig
2016-06-27 16:54 ` Ian Jackson
2016-06-28 7:01 ` Jan Beulich
2016-06-28 10:42 ` Ian Jackson
2016-04-13 23:31 ` Jim Fehlig
[not found] ` <570ED6B4.3060102@suse.com>
2016-04-14 7:40 ` Dario Faggioli
[not found] ` <1460619652.13871.130.camel@citrix.com>
2016-04-14 17:59 ` Ian Jackson
2016-04-14 18:05 ` Dario Faggioli
2016-04-15 9:14 ` Olaf Hering [this message]
2016-04-05 11:39 Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415091427.GA11031@gmail.com \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jfehlig@suse.com \
--cc=libvir-list@redhat.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).