xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] build: fix assembler instruction tests again
@ 2016-05-30  9:52 Jan Beulich
  2016-05-31 11:38 ` Roger Pau Monne
  2016-05-31 12:25 ` Wei Liu
  0 siblings, 2 replies; 5+ messages in thread
From: Jan Beulich @ 2016-05-30  9:52 UTC (permalink / raw)
  To: xen-devel
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
	Ian Jackson, Tim Deegan, Roger Pau Monne

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added
$(AFLAGS) here, which results in all of those tests now failing.
Certain items need to be removed for things to work again.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/Config.mk
+++ b/Config.mk
@@ -150,7 +150,8 @@ endif
 # as-insn: Check whether assembler supports an instruction.
 # Usage: cflags-y += $(call as-insn "insn",option-yes,option-no)
 as-insn = $(if $(shell echo 'void _(void) { asm volatile ( $(2) ); }' \
-                       | $(1) $(AFLAGS) -c -x c -o /dev/null - 2>&1),$(4),$(3))
+                       | $(1) $(filter-out -M% %.d -include %/include/xen/config.h,$(AFLAGS)) \
+                              -c -x c -o /dev/null - 2>&1),$(4),$(3))
 
 # as-insn-check: Add an option to compilation flags, but only if insn is
 #                supported by assembler.




[-- Attachment #2: asm-insn-tests.patch --]
[-- Type: text/plain, Size: 935 bytes --]

build: fix assembler instruction tests again

Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added
$(AFLAGS) here, which results in all of those tests now failing.
Certain items need to be removed for things to work again.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/Config.mk
+++ b/Config.mk
@@ -150,7 +150,8 @@ endif
 # as-insn: Check whether assembler supports an instruction.
 # Usage: cflags-y += $(call as-insn "insn",option-yes,option-no)
 as-insn = $(if $(shell echo 'void _(void) { asm volatile ( $(2) ); }' \
-                       | $(1) $(AFLAGS) -c -x c -o /dev/null - 2>&1),$(4),$(3))
+                       | $(1) $(filter-out -M% %.d -include %/include/xen/config.h,$(AFLAGS)) \
+                              -c -x c -o /dev/null - 2>&1),$(4),$(3))
 
 # as-insn-check: Add an option to compilation flags, but only if insn is
 #                supported by assembler.

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] build: fix assembler instruction tests again
  2016-05-30  9:52 [PATCH] build: fix assembler instruction tests again Jan Beulich
@ 2016-05-31 11:38 ` Roger Pau Monne
  2016-05-31 12:25 ` Wei Liu
  1 sibling, 0 replies; 5+ messages in thread
From: Roger Pau Monne @ 2016-05-31 11:38 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
	Ian Jackson, Tim Deegan, xen-devel

On Mon, May 30, 2016 at 03:52:57AM -0600, Jan Beulich wrote:
> Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added
> $(AFLAGS) here, which results in all of those tests now failing.
> Certain items need to be removed for things to work again.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] build: fix assembler instruction tests again
  2016-05-30  9:52 [PATCH] build: fix assembler instruction tests again Jan Beulich
  2016-05-31 11:38 ` Roger Pau Monne
@ 2016-05-31 12:25 ` Wei Liu
  2016-05-31 12:48   ` Jan Beulich
  1 sibling, 1 reply; 5+ messages in thread
From: Wei Liu @ 2016-05-31 12:25 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
	Ian Jackson, Tim Deegan, xen-devel, Roger Pau Monne

On Mon, May 30, 2016 at 03:52:57AM -0600, Jan Beulich wrote:
> Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added
> $(AFLAGS) here, which results in all of those tests now failing.
> Certain items need to be removed for things to work again.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 

Release-acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] build: fix assembler instruction tests again
  2016-05-31 12:25 ` Wei Liu
@ 2016-05-31 12:48   ` Jan Beulich
  2016-05-31 12:53     ` Wei Liu
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Beulich @ 2016-05-31 12:48 UTC (permalink / raw)
  To: Wei Liu
  Cc: Stefano Stabellini, George Dunlap, Andrew Cooper, IanJackson,
	Tim Deegan, xen-devel, Roger Pau Monne

>>> On 31.05.16 at 14:25, <wei.liu2@citrix.com> wrote:
> On Mon, May 30, 2016 at 03:52:57AM -0600, Jan Beulich wrote:
>> Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added
>> $(AFLAGS) here, which results in all of those tests now failing.
>> Certain items need to be removed for things to work again.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> 
> 
> Release-acked-by: Wei Liu <wei.liu2@citrix.com>

Thanks, but - does this also imply an ordinary (REST maintainer) ack
by you?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] build: fix assembler instruction tests again
  2016-05-31 12:48   ` Jan Beulich
@ 2016-05-31 12:53     ` Wei Liu
  0 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2016-05-31 12:53 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Stefano Stabellini, Wei Liu, George Dunlap, Andrew Cooper,
	IanJackson, Tim Deegan, xen-devel, Roger Pau Monne

On Tue, May 31, 2016 at 06:48:48AM -0600, Jan Beulich wrote:
> >>> On 31.05.16 at 14:25, <wei.liu2@citrix.com> wrote:
> > On Mon, May 30, 2016 at 03:52:57AM -0600, Jan Beulich wrote:
> >> Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added
> >> $(AFLAGS) here, which results in all of those tests now failing.
> >> Certain items need to be removed for things to work again.
> >> 
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> 
> > 
> > Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> Thanks, but - does this also imply an ordinary (REST maintainer) ack
> by you?
> 

Oops, I should have been explicit. Sorry.

Acked-by: Wei Liu <wei.liu2@citrix.com>


> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-05-31 12:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-30  9:52 [PATCH] build: fix assembler instruction tests again Jan Beulich
2016-05-31 11:38 ` Roger Pau Monne
2016-05-31 12:25 ` Wei Liu
2016-05-31 12:48   ` Jan Beulich
2016-05-31 12:53     ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).