From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: ross.lagerwall@citrix.com, ian.jackson@eu.citrix.com,
wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/1] tools/xsplice: cleanup unnecessary "j = ARRAY_SIZE(action_options); "
Date: Tue, 31 May 2016 17:02:50 -0400 [thread overview]
Message-ID: <20160531210250.GA22577@char.us.oracle.com> (raw)
In-Reply-To: <1464572762-12143-1-git-send-email-dongli.zhang@oracle.com>
On Mon, May 30, 2016 at 09:46:02AM +0800, Dongli Zhang wrote:
> Local variable "j" would be used only when "i == ARRAY_SIZE(main_options)"
> is true. Thus, it is not necessary to update "j" when "i ==
> ARRAY_SIZE(main_options)" is false.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Wei, it is up to you whether it should go in 4.7 or in 4.8.
This is a cleanup so it has no effect on the code.
> ---
> tools/misc/xen-xsplice.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/misc/xen-xsplice.c b/tools/misc/xen-xsplice.c
> index ddaa079..811dc57 100644
> --- a/tools/misc/xen-xsplice.c
> +++ b/tools/misc/xen-xsplice.c
> @@ -435,8 +435,7 @@ int main(int argc, char *argv[])
> "'xen-xsplice help'\n", argv[1]);
> return 1;
> }
> - } else
> - j = ARRAY_SIZE(action_options);
> + }
>
> xch = xc_interface_open(0,0,0);
> if ( !xch )
> --
> 1.9.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-31 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 1:46 [PATCH 1/1] tools/xsplice: cleanup unnecessary "j = ARRAY_SIZE(action_options); " Dongli Zhang
2016-05-31 21:02 ` Konrad Rzeszutek Wilk [this message]
2016-06-01 10:14 ` Wei Liu
2016-06-09 15:21 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531210250.GA22577@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=dongli.zhang@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).