From: Wei Liu <wei.liu2@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Martin Pohlack <mpohlack@amazon.de>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 for 4.7] xen: Rename of xSplice to livepatch.
Date: Thu, 2 Jun 2016 16:50:32 +0100 [thread overview]
Message-ID: <20160602155032.GA14588@citrix.com> (raw)
In-Reply-To: <20160602153830.GA1783@char.us.oracle.com>
On Thu, Jun 02, 2016 at 11:38:30AM -0400, Konrad Rzeszutek Wilk wrote:
> On Thu, Jun 02, 2016 at 09:25:55AM -0600, Jan Beulich wrote:
> > >>> On 02.06.16 at 17:18, <konrad.wilk@oracle.com> wrote:
> > > On Thu, Jun 02, 2016 at 03:58:37PM +0100, Andrew Cooper wrote:
> > >> On 02/06/16 15:50, Jan Beulich wrote:
> > >> >
> > >> >> --- a/xen/arch/arm/xsplice.c
> > >> >> +++ b/xen/arch/arm/livepatch.c
> > >> >> @@ -4,67 +4,67 @@
> > >> >> #include <xen/errno.h>
> > >> >> #include <xen/init.h>
> > >> >> #include <xen/lib.h>
> > >> >> -#include <xen/xsplice_elf.h>
> > >> >> -#include <xen/xsplice.h>
> > >> >> +#include <xen/livepatch_elf.h>
> > >> >> +#include <xen/livepatch.h>
> > >> >>
> > >> >> -void arch_xsplice_patching_enter(void)
> > >> >> +void arch_livepatching_enter(void)
> > >> > Still "patching"?
> > >>
> > >> This function came from one of my additions to the series. It half of a
> > >> pair of calls around the critical region which is writing new code/data,
> > >> where CR0.WP needs tweaking.
> > >>
> > >> As such, 'patching' was logically distinct from the name 'livepatch' as
> > >> the general namespace of these functions, and referred to the critical
> > >> region of actually changing live memory.
> > >>
> > >> I am at a loss to suggest a better alternative.
> > >
> > > arch_quiescing_start and arch_quiescing_stop ?
> >
> > arch_livepatch_quiesce() / arch_livepatch_revive()?
>
> Fantastic!
>
> For reference the patch.
>
> From c15659cf833a453c27386cb181744ebcf5b0cd1f Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Date: Wed, 1 Jun 2016 20:14:47 -0400
> Subject: [PATCH v3.1 for 4.7] xen: Rename of xSplice to livepatch.
>
> Specifically:
>
> s/\.xsplice/\.livepatch/
> s/XSPLICE/LIVEPATCH/
> s/xsplice/livepatch/
> s/livepatch_patch_func/livepatch_func/
> s/xSplice/Xen Live Patch/
> s/livepatching/livepatch/
> s/arch_livepatch_enter/arch_livepatch_quiesce/
> s/arch_livepatch_exit/arch_livepatch_revive/
>
> And then modify some of the function arguments
> to have two more characters.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> ---
> Cc: Ross Lagerwall <ross.lagerwall@citrix.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <George.Dunlap@eu.citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Tim Deegan <tim@xen.org>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Martin Pohlack <mpohlack@amazon.de>
>
> v2: Ditch the LIVE_PATCH and 'Live Patching' inconsitency.
> Include Ross's email correctly.
> Don't move alphabetically the #include header as it is
> inconsistent
> v3: s/livepatching/livepatch/
> Alter some of the "live patching" or "live patch" to say
> "Live Patch"
> Move in common/Makefile the livepatch entry (it is sorted)
> Move the LIVEPATCH in MAINTAINERS file in the proper location
> (it is sorted). Add Jan's Ack.
> v3.1: s/arch_livepatch_enter/arch_livepatch_quiesce/
> s/arch_livepatch_exit/arch_livepatch_revive/
> ---
> .gitignore | 8 +-
> MAINTAINERS | 20 +-
> docs/misc/{xsplice.markdown => livepatch.markdown} | 184 +++++-----
> tools/flask/policy/policy/modules/xen/xen.te | 2 +-
> tools/libxc/include/xenctrl.h | 32 +-
> tools/libxc/xc_misc.c | 142 ++++----
> tools/misc/Makefile | 4 +-
> tools/misc/{xen-xsplice.c => xen-livepatch.c} | 62 ++--
Acked-by: Wei Liu <wei.liu2@citrix.com>
And
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-02 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 14:05 [PATCH v2 for 4.7] xen: Rename of xSplice to livepatch Konrad Rzeszutek Wilk
2016-06-02 14:50 ` Jan Beulich
2016-06-02 14:58 ` Andrew Cooper
2016-06-02 15:18 ` Konrad Rzeszutek Wilk
2016-06-02 15:25 ` Jan Beulich
2016-06-02 15:38 ` Konrad Rzeszutek Wilk
2016-06-02 15:50 ` Wei Liu [this message]
2016-06-02 15:16 ` Konrad Rzeszutek Wilk
2016-06-03 8:08 ` Ross Lagerwall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602155032.GA14588@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=mpohlack@amazon.de \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).