From: Wei Liu <wei.liu2@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Anthony PERARD <anthony.perard@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config
Date: Tue, 7 Jun 2016 17:46:27 +0100 [thread overview]
Message-ID: <20160607164627.GU25922@citrix.com> (raw)
In-Reply-To: <1465316547.15816.167.camel@citrix.com>
On Tue, Jun 07, 2016 at 06:22:27PM +0200, Dario Faggioli wrote:
> On Tue, 2016-06-07 at 17:03 +0100, Wei Liu wrote:
> > On Tue, Jun 07, 2016 at 03:45:29PM +0100, Anthony PERARD wrote:
> > >
> > > > --- a/tools/libxl/libxl.c
> > > > +++ b/tools/libxl/libxl.c
> > > > @@ -7222,6 +7222,57 @@ void libxl_mac_copy(libxl_ctx *ctx,
> > > > libxl_mac *dst, libxl_mac *src)
> > > > (*dst)[i] = (*src)[i];
> > > > }
> > > >
> > > > +static int libxl__update_avail_vcpus_qmp(libxl__gc *gc, uint32_t
> > > > domid,
> > > > + unsigned int max_vcpus,
> > > > + libxl_bitmap *map)
> > > > +{
> > > > + unsigned int count, i;
> > > > + int rc;
> > > > +
> > > > + /* For QEMU upstream we always need to return the number
> > > > + * of cpus present to QEMU whether they are online or not;
> > > > + * otherwise QEMU won't accept the saved state.
> > > > + */
> > > > + rc = libxl__qmp_query_cpus(gc, domid, &count);
> > > > + if (rc) {
> > > > + LOG(ERROR, "fail to get number of cpus for domain %d",
> > > > domid);
> > > > + goto out;
> > > > + }
> > > > +
> > > > + for (i = 0; i < count; i++)
> > > > + libxl_bitmap_set(map, i);
> > > What if I have cpu 1, 7 and 42 online, but all the other offline?
> > >
> > I have more or less the same question when I wrote this patch. At
> > that
> > time I thought the avail_vcpus was only used for generating -smp
> > option
> > to QEMU.
> >
> > In your example, you will have -smp 3,maxvcpus=$Y. I think the
> > migration
> > should still succeed. Furthermore, the cpu-add operation doesn't
> > care,
> > so it probably won't have visible effect.
> >
> > I agree it would be good to set the exact bits though -- if you can
> > tell
> > me which field to test.
> >
> Perhaps at least mention something about all this either in a comment
> or in the changelog?
>
What would you like to see in a comment? I guess this is now moot
because the exact bits will be set.
Wei.
> Regards,
> Dario
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 16:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 11:23 [PATCH 0/3] libxl: update available vcpus map in retrieve configuration function Wei Liu
2016-06-07 11:24 ` [PATCH 1/3] libxl: introduce libxl__json_array_count Wei Liu
2016-06-07 11:24 ` [PATCH 2/3] libxl: introduce libxl__qmp_query_cpus Wei Liu
2016-06-07 11:24 ` [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config Wei Liu
2016-06-07 14:45 ` Anthony PERARD
2016-06-07 16:03 ` Wei Liu
2016-06-07 16:22 ` Dario Faggioli
2016-06-07 16:46 ` Wei Liu [this message]
2016-06-07 17:05 ` Dario Faggioli
2016-06-07 16:36 ` Anthony PERARD
2016-06-07 16:39 ` Wei Liu
2016-06-14 16:31 ` Ian Jackson
2016-06-14 16:39 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607164627.GU25922@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).