From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> To: Julien Grall <julien.grall@arm.com> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, sstabellini@kernel.org, xen-devel@lists.xen.org Subject: Re: [RFC for-4.8 v2 2/7] xen/arm: Rename and generalize un/map_regions_rw_cache Date: Tue, 7 Jun 2016 22:55:17 +0200 [thread overview] Message-ID: <20160607205517.GD6818@toto> (raw) In-Reply-To: <5755B912.90605@arm.com> On Mon, Jun 06, 2016 at 06:55:30PM +0100, Julien Grall wrote: > Hi Edgar, > > On 03/06/16 14:29, Edgar E. Iglesias wrote: > >From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > >Rename and generalize un/map_regions_rw_cache into > >un/map_regions. > > I would name it map_regions_mattr (or something similar) to stop people > using this helper to map real RAM. Sounds good, I've done it for v3. > > >The new functions take the mapping > >attributes and access permissions as arguments. > > I overlooked it when I reviewed {,un}map_regions_rw_cache. p2m_access_t is > for memaccess to restrict the permission. The helper should always use > d->arch.p2m.default_access. > > Can you fix it in a separate patch and request for backport to Xen 4.7? Yes, I'll do that. Cheers, Edgar > > Regards, > > -- > Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 20:55 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-03 13:29 [RFC for-4.8 v2 0/7] xen/arm: Add support for mapping mmio-sram nodes into dom0 Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 1/7] xen/arm: Add MATTR_MEM_NC for normal non-cacheable memory Edgar E. Iglesias 2016-06-06 17:23 ` Julien Grall 2016-06-07 20:34 ` Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 2/7] xen/arm: Rename and generalize un/map_regions_rw_cache Edgar E. Iglesias 2016-06-06 17:55 ` Julien Grall 2016-06-07 20:55 ` Edgar E. Iglesias [this message] 2016-06-03 13:29 ` [RFC for-4.8 v2 3/7] xen/device-tree: Add __DT_MATCH macros without braces Edgar E. Iglesias 2016-06-06 17:36 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 4/7] xen/device-tree: Make dt_match_node match props Edgar E. Iglesias 2016-06-06 17:39 ` Julien Grall 2016-06-07 20:43 ` Edgar E. Iglesias 2016-06-08 8:44 ` Julien Grall 2016-06-09 16:04 ` Edgar E. Iglesias 2016-06-09 16:23 ` Julien Grall 2016-06-09 16:30 ` Edgar E. Iglesias 2016-06-03 13:29 ` [RFC for-4.8 v2 5/7] xen/arm: domain_build: Plumb for different mapping attributes Edgar E. Iglesias 2016-06-06 18:00 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 6/7] xen/device-tree: Add an mmio-sram bus Edgar E. Iglesias 2016-06-06 18:05 ` Julien Grall 2016-06-08 0:21 ` Edgar E. Iglesias 2016-06-08 8:52 ` Julien Grall 2016-06-03 13:29 ` [RFC for-4.8 v2 7/7] xen/arm: Map mmio-sram nodes as normal un-cached rwx memory Edgar E. Iglesias 2016-06-06 18:08 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160607205517.GD6818@toto \ --to=edgar.iglesias@xilinx.com \ --cc=edgar.iglesias@gmail.com \ --cc=julien.grall@arm.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xen.org \ --subject='Re: [RFC for-4.8 v2 2/7] xen/arm: Rename and generalize un/map_regions_rw_cache' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).