From: Wei Liu <firstname.lastname@example.org> To: Jan Beulich <JBeulich@suse.com> Cc: xen-devel <email@example.com>, Joao Martins <firstname.lastname@example.org>, Wei Liu <email@example.com>, Dario Faggioli <firstname.lastname@example.org>, Andrew Cooper <email@example.com> Subject: Re: [PATCH] x86/time: use correct (local) time stamp in constant-TSC calibration fast path Date: Thu, 9 Jun 2016 13:12:33 +0100 [thread overview] Message-ID: <20160609121233.GL28116@citrix.com> (raw) In-Reply-To: <575976AE02000078000F3695@prv-mh.provo.novell.com> On Thu, Jun 09, 2016 at 06:01:18AM -0600, Jan Beulich wrote: > This looks like a copy and paste mistake in commit 1b6a99892d ("x86: > Simpler time handling when TSC is constant across all power saving > states"), responsible for occasional many-microsecond cross-CPU skew of > what NOW() returns. > > Also improve the correlation between local TSC and stime stamps > obtained at the end of the two calibration handlers: Compute the stime > one from the TSC one, instead of doing another rdtsc() for that > compuation. > > Signed-off-by: Jan Beulich <firstname.lastname@example.org> > --- > As to 4.7 inclusion: This of course looks like a pretty blatant mistake > that has been there for many years (and hence many releases). There's > certainly non-zero risk that I'm overlooking something here (despite > Joao apparently having come to the same conclusion), so I can't really > make up my mind on whether to request this patch to be put there right > away, or rather having linger in -unstable for a while. > Leave it in unstable for a while please. I don't want to delay the release any further. Wei. _______________________________________________ Xen-devel mailing list Xenemail@example.com http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-09 12:12 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-09 12:01 Jan Beulich 2016-06-09 12:10 ` Andrew Cooper 2016-06-09 12:11 ` Joao Martins 2016-06-09 12:57 ` Jan Beulich 2016-06-09 15:00 ` Joao Martins 2016-06-09 15:52 ` Jan Beulich 2016-06-09 18:19 ` Joao Martins 2016-06-10 6:59 ` Jan Beulich 2016-06-10 9:29 ` Jan Beulich 2016-06-10 17:07 ` Joao Martins 2016-06-09 12:12 ` Wei Liu [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160609121233.GL28116@citrix.com \ --firstname.lastname@example.org \ --cc=JBeulich@suse.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] x86/time: use correct (local) time stamp in constant-TSC calibration fast path' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).