xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] exec: Fix qemu_ram_block_from_host for Xen
@ 2016-06-09 15:56 Anthony PERARD
  0 siblings, 0 replies; 2+ messages in thread
From: Anthony PERARD @ 2016-06-09 15:56 UTC (permalink / raw)
  To: qemu-devel
  Cc: Stefano Stabellini, Peter Crosthwaite, xen-devel, Anthony PERARD,
	Paolo Bonzini, Richard Henderson

Since f615f39 (exec: remove ram_addr argument from
qemu_ram_block_from_host), migration under Xen is likely to fail, with a
SEGV of QEMU. But the commit only reveal a bug with the calculation of
the offset value in qemu_ram_block_from_host().

This patch calculates the offset from the ram_addr as
qemu_ram_addr_from_host() will later calculate the ram_addr from the
offset.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 exec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/exec.c b/exec.c
index f2c9e37..f13106d 100644
--- a/exec.c
+++ b/exec.c
@@ -1935,7 +1935,7 @@ RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset,
         ram_addr = xen_ram_addr_from_mapcache(ptr);
         block = qemu_get_ram_block(ram_addr);
         if (block) {
-            *offset = (host - block->host);
+            *offset = ram_addr - block->offset;
         }
         rcu_read_unlock();
         return block;
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] exec: Fix qemu_ram_block_from_host for Xen
       [not found] <20160609155617.6650-1-anthony.perard@citrix.com>
@ 2016-06-13  8:16 ` Paolo Bonzini
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2016-06-13  8:16 UTC (permalink / raw)
  To: Anthony PERARD, qemu-devel
  Cc: Peter Crosthwaite, Stefano Stabellini, Richard Henderson, xen-devel



On 09/06/2016 17:56, Anthony PERARD wrote:
> Since f615f39 (exec: remove ram_addr argument from
> qemu_ram_block_from_host), migration under Xen is likely to fail, with a
> SEGV of QEMU. But the commit only reveal a bug with the calculation of
> the offset value in qemu_ram_block_from_host().
> 
> This patch calculates the offset from the ram_addr as
> qemu_ram_addr_from_host() will later calculate the ram_addr from the
> offset.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  exec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/exec.c b/exec.c
> index f2c9e37..f13106d 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1935,7 +1935,7 @@ RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset,
>          ram_addr = xen_ram_addr_from_mapcache(ptr);
>          block = qemu_get_ram_block(ram_addr);
>          if (block) {
> -            *offset = (host - block->host);
> +            *offset = ram_addr - block->offset;
>          }
>          rcu_read_unlock();
>          return block;
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Feel free to send a pull request yourself!

Thanks, and sorry for the breakage.  Indeed the broken code comes from
commit 422148d3e56c3c9a07c0cf36c1e0a0b76f09c357.

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-13  8:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 15:56 [PATCH] exec: Fix qemu_ram_block_from_host for Xen Anthony PERARD
     [not found] <20160609155617.6650-1-anthony.perard@citrix.com>
2016-06-13  8:16 ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).