Re: compilation fail, xen staging-4.6, vnc.c, qemu-tradintional issues under ubuntu 16.04

[Anthony PERARD <anthony.perard@citrix.com>]

On Fri, Jun 10, 2016 at 03:08:19PM +0100, George Dunlap wrote:
> On Fri, Jun 10, 2016 at 3:00 PM, Anthony PERARD
> <anthony.perard@citrix.com> wrote:
> > On Fri, Jun 10, 2016 at 12:26:21PM +0100, George Dunlap wrote:
> >> On Wed, Mar 30, 2016 at 3:58 PM, Dario Faggioli
> >> <dario.faggioli@citrix.com> wrote:
> >> > Cc-ing some tools, Qemu, and Stubdom/MiniOS people, and dropping xen-
> >> > users (Bcc-ed)...
> >> >
> >> [snip]
> >>
> >> >> vl.c:2784:5: error: ‘g_mem_set_vtable’ is deprecated
> >> >> [-Werror=deprecated-declarations]
> >> >>      g_mem_set_vtable(&mem_trace);
> >> >>
> >> >>
> >> >> I had to apply
> >> >>
> >> >> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01262.html
> >> >>
> >> >> which seemes that only partially been applied (has rejects), but
> >> >> after
> >> >> modifying the sources by hand, it seemes working.
> >>
> >> Anthony / Stefano / Ian, this is still failing two months later:
> >>
> >> vl.c: In function ‘main’:
> >> vl.c:2784:5: error: ‘g_mem_set_vtable’ is deprecated
> >> [-Werror=deprecated-declarations]
> >>      g_mem_set_vtable(&mem_trace);
> >>      ^
> >> In file included from /usr/include/glib-2.0/glib/glist.h:32:0,
> >>                  from /usr/include/glib-2.0/glib/ghash.h:33,
> >>                  from /usr/include/glib-2.0/glib.h:50,
> >>                  from vl.c:59:
> >> /usr/include/glib-2.0/glib/gmem.h:357:6: note: declared here
> >>  void  g_mem_set_vtable (GMemVTable *vtable);
> >>       ^
> >> cc1: all warnings being treated as errors
> >> /root/git/xen.git/tools/qemu-xen-dir/rules.mak:57: recipe for target
> >> 'vl.o' failed
> >
> > # edit tools/Makefile to not compile xentrace
> > ./configure --disable-qemu-traditional --with-extra-qemuu-configure-args='--disable-werror'
> > make
> >
> > Works for me :).
> >
> > Should we add --disable-werror to QEMU when doing a release? Or do we
> > really want to fix compilation warnings in stable branches?
> 
> I think so, yes.  Consider this case, where the new version of glibc
> has this marked as deprecated -- new point releases in particular
> should build without using deprecated functionality.

For this case, we can apply: 98cf48f (trace: remove malloc tracing),
which remove the offending line.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel