xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: jgross@suse.com, grub-devel@gnu.org, eric.snowberg@oracle.com,
	arvidjaar@gmail.com, phcoder@gmail.com, seth.goldberg@oracle.com,
	xen-devel@lists.xenproject.org
Subject: Re: [MULTIBOOT2 DOC PATCH 06/10] multiboot2: Add description of support for relocatable images
Date: Fri, 10 Jun 2016 19:36:34 +0200	[thread overview]
Message-ID: <20160610173634.GE5490__28089.6125980236$1465580457$gmane$org@olila.local.net-space.pl> (raw)
In-Reply-To: <33053e4b-2c66-dc4f-6e5a-bfcb05bde590@citrix.com>

On Thu, Jun 09, 2016 at 10:36:29PM +0100, Andrew Cooper wrote:
> On 09/06/2016 21:30, Daniel Kiper wrote:
> > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> > ---
> >  doc/multiboot.texi |   56 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  doc/multiboot2.h   |   24 ++++++++++++++++++++++
> >  2 files changed, 80 insertions(+)
> >
> > diff --git a/doc/multiboot.texi b/doc/multiboot.texi
> > index 130176a..f1e0e09 100644
> > --- a/doc/multiboot.texi
> > +++ b/doc/multiboot.texi
> > @@ -359,6 +359,7 @@ executable header.
> >  * Console header tags::
> >  * Module alignment tag::
> >  * EFI boot services tag::
> > +* Relocatable header tag::
> >
> >  @end menu
> >
> > @@ -681,6 +682,47 @@ u32     | size = 8          |
> >  This tag indicates that payload supports starting without
> >  terminating boot services.
> >
> > +@node Relocatable header tag
> > +@subsection Relocatable header tag
> > +
> > +@example
> > +@group
> > +        +-------------------+
> > +u16     | type = 10         |
> > +u16     | flags             |
> > +u32     | size = 24         |
> > +u32     | min_addr          |
> > +u32     | max_addr          |
> > +u32     | align             |
> > +u32     | preference        |
> > +        +-------------------+
> > +@end group
> > +@end example
> > +
> > +This tag indicates that image is relocatable.
> > +
> > +The meaning of each field is as follows:
> > +
> > +@table @code
> > +@item min_addr
> > +Lowest possible physical address at which image should be loaded.
> > +Boot loader cannot load any part of image below this address.
>
> "The bootloader".

This and earlier comments show, what I know very well, that a/the
English stuff is huge pain for me. Ehh... It looks that I should
not update any docs... ;-))) Anyway, thank you for your comments!

[...]

> > +struct multiboot_header_tag_relocatable
> > +{
> > +  multiboot_uint16_t type;
> > +  multiboot_uint16_t flags;
> > +  multiboot_uint32_t size;
> > +  multiboot_uint32_t min_addr;
> > +  multiboot_uint32_t max_addr;
>
> 64bit multiboot2 payloads could reasonably expect to be able to have
> themselves relocated about the 4G boundary.

That is true but in general the multiboot2 protocol is 32-bit stuff.
So, I prefer to stay in 32-bit domain. Just in case. If we need to use
full blown 64-bit thing then, IMO, we should introduce new protocol
(e.g. multiboot3) with full 64-bit support, probably compatible with
32-bit stuff to some extent.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-10 17:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1465504244-17175-1-git-send-email-daniel.kiper@oracle.com>
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 01/10] multiboot2: Remove redundant if Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 02/10] multiboot2: Clarify meaning of information request header tag Daniel Kiper
2016-06-09 21:14   ` Andrew Cooper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 03/10] multiboot2: Fix description of EFI boot services tag Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 04/10] multiboot2: Add description of support for EFI boot services Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 05/10] multiboot2: Add description of EFI image handle tags Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 06/10] multiboot2: Add description of support for relocatable images Daniel Kiper
2016-06-09 21:36   ` Andrew Cooper
2016-06-10 17:36     ` Daniel Kiper [this message]
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 07/10] multiboot2: Say that memory maps may not be available on EFI platforms Daniel Kiper
2016-06-09 21:37   ` Andrew Cooper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 08/10] multiboot2: Add C structure alignment and padding consideration section Daniel Kiper
2016-06-09 22:07   ` Andrew Cooper
     [not found]   ` <1c1e54de-2f19-20b6-b8c8-229619b95038@citrix.com>
2016-06-10 17:58     ` Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 09/10] multiboot2: Add me to authors Daniel Kiper
2016-06-09 20:30 ` [MULTIBOOT2 DOC PATCH 10/10] multiboot2: Bump version to 2.0 Daniel Kiper
     [not found] ` <1465504244-17175-2-git-send-email-daniel.kiper@oracle.com>
2016-06-09 21:02   ` [MULTIBOOT2 DOC PATCH 01/10] multiboot2: Remove redundant if Andrew Cooper
     [not found] ` <1465504244-17175-5-git-send-email-daniel.kiper@oracle.com>
2016-06-09 21:31   ` [MULTIBOOT2 DOC PATCH 04/10] multiboot2: Add description of support for EFI boot services Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20160610173634.GE5490__28089.6125980236$1465580457$gmane$org@olila.local.net-space.pl' \
    --to=daniel.kiper@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=arvidjaar@gmail.com \
    --cc=eric.snowberg@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=jgross@suse.com \
    --cc=phcoder@gmail.com \
    --cc=seth.goldberg@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).