xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Denemark <jdenemar@redhat.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: libvir-list@redhat.com, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] tests: fix CPUID detection tests compilation failure
Date: Mon, 13 Jun 2016 12:26:19 +0200	[thread overview]
Message-ID: <20160613102619.GA4460@orkuz.home> (raw)
In-Reply-To: <1465809101-6341-1-git-send-email-wei.liu2@citrix.com>

On Mon, Jun 13, 2016 at 10:11:41 +0100, Wei Liu wrote:
> In 3704b9003 ("tests: Add CPU detection tests"), a macro called
> DO_TEST_CPUID_JSON is added. But it took only two arguments when QEMU
> or YAJL is not set.
> 
> Fix it by adding a third argument. Shouldn't have any effect because
> that macro compiles to nothing.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Jiri Denemark <jdenemar@redhat.com>
> 
> For error: see
> http://logs.test-lab.xenproject.org/osstest/logs/95577/build-amd64-libvirt/5.ts-libvirt-build.log
> ---
>  tests/cputest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/cputest.c b/tests/cputest.c
> index f68a3ec..c374ddf 100644
> --- a/tests/cputest.c
> +++ b/tests/cputest.c
> @@ -700,7 +700,7 @@ mymain(void)
>          }                                                               \
>      } while (0)
>  #else
> -# define DO_TEST_CPUID_JSON(arch, host)
> +# define DO_TEST_CPUID_JSON(arch, host, json)
>  #endif
>  
>  #define DO_TEST_CPUID(arch, host, json)                                 \

Oops, thanks for fixing this. ACK and pushed.

Jirka

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-06-13 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13  9:11 [PATCH] tests: fix CPUID detection tests compilation failure Wei Liu
2016-06-13 10:26 ` Jiri Denemark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160613102619.GA4460@orkuz.home \
    --to=jdenemar@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).