* [PATCH] tests: fix CPUID detection tests compilation failure
@ 2016-06-13 9:11 Wei Liu
2016-06-13 10:26 ` Jiri Denemark
0 siblings, 1 reply; 2+ messages in thread
From: Wei Liu @ 2016-06-13 9:11 UTC (permalink / raw)
To: libvir-list; +Cc: Xen-devel, Jiri Denemark, Wei Liu
In 3704b9003 ("tests: Add CPU detection tests"), a macro called
DO_TEST_CPUID_JSON is added. But it took only two arguments when QEMU
or YAJL is not set.
Fix it by adding a third argument. Shouldn't have any effect because
that macro compiles to nothing.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Jiri Denemark <jdenemar@redhat.com>
For error: see
http://logs.test-lab.xenproject.org/osstest/logs/95577/build-amd64-libvirt/5.ts-libvirt-build.log
---
tests/cputest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/cputest.c b/tests/cputest.c
index f68a3ec..c374ddf 100644
--- a/tests/cputest.c
+++ b/tests/cputest.c
@@ -700,7 +700,7 @@ mymain(void)
} \
} while (0)
#else
-# define DO_TEST_CPUID_JSON(arch, host)
+# define DO_TEST_CPUID_JSON(arch, host, json)
#endif
#define DO_TEST_CPUID(arch, host, json) \
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests: fix CPUID detection tests compilation failure
2016-06-13 9:11 [PATCH] tests: fix CPUID detection tests compilation failure Wei Liu
@ 2016-06-13 10:26 ` Jiri Denemark
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Denemark @ 2016-06-13 10:26 UTC (permalink / raw)
To: Wei Liu; +Cc: libvir-list, Xen-devel
On Mon, Jun 13, 2016 at 10:11:41 +0100, Wei Liu wrote:
> In 3704b9003 ("tests: Add CPU detection tests"), a macro called
> DO_TEST_CPUID_JSON is added. But it took only two arguments when QEMU
> or YAJL is not set.
>
> Fix it by adding a third argument. Shouldn't have any effect because
> that macro compiles to nothing.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Jiri Denemark <jdenemar@redhat.com>
>
> For error: see
> http://logs.test-lab.xenproject.org/osstest/logs/95577/build-amd64-libvirt/5.ts-libvirt-build.log
> ---
> tests/cputest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/cputest.c b/tests/cputest.c
> index f68a3ec..c374ddf 100644
> --- a/tests/cputest.c
> +++ b/tests/cputest.c
> @@ -700,7 +700,7 @@ mymain(void)
> } \
> } while (0)
> #else
> -# define DO_TEST_CPUID_JSON(arch, host)
> +# define DO_TEST_CPUID_JSON(arch, host, json)
> #endif
>
> #define DO_TEST_CPUID(arch, host, json) \
Oops, thanks for fixing this. ACK and pushed.
Jirka
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-13 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-13 9:11 [PATCH] tests: fix CPUID detection tests compilation failure Wei Liu
2016-06-13 10:26 ` Jiri Denemark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).