From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config Date: Tue, 14 Jun 2016 11:47:57 +0100 Message-ID: <20160614104757.GI5666@perard.uk.xensource.com> References: <1465396126-27426-1-git-send-email-wei.liu2@citrix.com> <1465396126-27426-3-git-send-email-wei.liu2@citrix.com> <20160613173936.GG5666@perard.uk.xensource.com> <20160613182153.GC23146@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bClt8-0007DX-9m for xen-devel@lists.xenproject.org; Tue, 14 Jun 2016 10:48:06 +0000 Content-Disposition: inline In-Reply-To: <20160613182153.GC23146@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: Xen-devel , Ian Jackson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBKdW4gMTMsIDIwMTYgYXQgMDc6MjE6NTNQTSArMDEwMCwgV2VpIExpdSB3cm90ZToK PiBPbiBNb24sIEp1biAxMywgMjAxNiBhdCAwNjozOTozNlBNICswMTAwLCBBbnRob255IFBFUkFS RCB3cm90ZToKPiA+IE9uIFdlZCwgSnVuIDA4LCAyMDE2IGF0IDAzOjI4OjQ1UE0gKzAxMDAsIFdl aSBMaXUgd3JvdGU6Cj4gPiA+IC4uLiBiZWNhdXNlIHRoZSBhdmFpbGFibGUgdmNwdSBiaXRtYXAg Y2FuIGNoYW5nZSBkdXJpbmcgZG9tYWluIGxpZmUgdGltZQo+ID4gPiBkdWUgdG8gY3B1IGhvdHBs dWcgYW5kIHVucGx1Zy4KPiA+ID4gCj4gPiA+IEZvciBRRU1VIHVwc3RyZWFtLCB3ZSBpbnRlcnJv Z2F0ZSBRRU1VIGZvciB0aGUgbnVtYmVyIG9mIHZjcHVzLiBGb3IKPiA+ID4gb3RoZXJzLCB3ZSBs b29rIGRpcmVjdGx5IGludG8geGVuc3RvcmUgZm9yIGluZm9ybWF0aW9uLgo+ID4gCj4gPiBJIHRy aWVkIHRvIG1pZ3JhdGUgYSBndWVzdCwgYW5kIGxpYnhsIGFib3J0IGluCj4gPiBsaWJ4bF9yZXRy aWV2ZV9kb21haW5fY29uZmlndXJhdGlvbiB3aXRoaW4gdGhlIHN3aXRjaAo+ID4gKGRldmljZV9t b2RlbF92ZXJzaW9uKS4KPiA+IAo+ID4gCj4gPiA+IFJlcG9ydGVkLWJ5OiBKYW4gQmV1bGljaCA8 amJldWxpY2hAc3VzZS5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFdlaSBMaXUgPHdlaS5saXUy QGNpdHJpeC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgdG9vbHMvbGlieGwvbGlieGwuYyB8IDg3ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ ICAxIGZpbGUgY2hhbmdlZCwgODcgaW5zZXJ0aW9ucygrKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdp dCBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMgYi90b29scy9saWJ4bC9saWJ4bC5jCj4gPiA+IGluZGV4 IDAwNmI4M2YuLjAyNzA2YWIgMTAwNjQ0Cj4gPiA+IC0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMK PiA+ID4gKysrIGIvdG9vbHMvbGlieGwvbGlieGwuYwo+ID4gPiBAQCAtNzIyMiw2ICs3MjIyLDUz IEBAIHZvaWQgbGlieGxfbWFjX2NvcHkobGlieGxfY3R4ICpjdHgsIGxpYnhsX21hYyAqZHN0LCBs aWJ4bF9tYWMgKnNyYykKPiA+ID4gICAgICAgICAgKCpkc3QpW2ldID0gKCpzcmMpW2ldOwo+ID4g PiAgfQo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgaW50IGxpYnhsX191cGRhdGVfYXZhaWxfdmNwdXNf cW1wKGxpYnhsX19nYyAqZ2MsIHVpbnQzMl90IGRvbWlkLAo+ID4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgbWF4X3ZjcHVzLAo+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaWJ4bF9iaXRtYXAgKm1h cCkKPiA+ID4gK3sKPiA+ID4gKyAgICBpbnQgcmM7Cj4gPiA+ICsKPiA+ID4gKyAgICAvKiBGb3Ig UUVNVSB1cHN0cmVhbSB3ZSBhbHdheXMgbmVlZCB0byByZXR1cm4gdGhlIG51bWJlcgo+ID4gPiAr ICAgICAqIG9mIGNwdXMgcHJlc2VudCB0byBRRU1VIHdoZXRoZXIgdGhleSBhcmUgb25saW5lIG9y IG5vdDsKPiA+ID4gKyAgICAgKiBvdGhlcndpc2UgUUVNVSB3b24ndCBhY2NlcHQgdGhlIHNhdmVk IHN0YXRlLgo+ID4gPiArICAgICAqLwo+ID4gPiArICAgIHJjID0gbGlieGxfX3FtcF9xdWVyeV9j cHVzKGdjLCBkb21pZCwgbWFwKTsKPiA+ID4gKyAgICBpZiAocmMpIHsKPiA+ID4gKyAgICAgICAg TE9HKEVSUk9SLCAiZmFpbCB0byBnZXQgbnVtYmVyIG9mIGNwdXMgZm9yIGRvbWFpbiAlZCIsIGRv bWlkKTsKPiA+ID4gKyAgICAgICAgZ290byBvdXQ7Cj4gPiA+ICsgICAgfQo+ID4gPiArCj4gPiA+ ICsgICAgcmMgPSAwOwo+ID4gCj4gPiBUaGUgdmFsdWUgc2hvdWxkIGFscmVhZHkgYmUgMCBhdCB0 aGlzIHBvaW50Lgo+ID4gCj4gCj4gSSB3b3VsZCBsaWtlIHRvIGtlZXAgdGhpcyBhcy1pcyBiZWNh dXNlIHRoaXMgaXMgYW4gaWRpb20gdGhhdCBpcyBzYWZlcgo+IGFnYWluc3QgZnVydGhlciBtb2Rp ZmljYXRpb24gb2YgdGhpcyBmdW5jdGlvbi4KPiAKPiA+ID4gK291dDoKPiA+ID4gKyAgICByZXR1 cm4gcmM7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBpbnQgbGlieGxfX3VwZGF0ZV9h dmFpbF92Y3B1c194ZW5zdG9yZShsaWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBkb21pZCwKPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp bnQgbWF4X3ZjcHVzLAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxpYnhsX2JpdG1hcCAqbWFwKQo+ID4gPiArewo+ID4gPiArICAgIGludCByYzsK PiA+ID4gKyAgICB1bnNpZ25lZCBpbnQgaTsKPiA+ID4gKyAgICBjb25zdCBjaGFyICpkb21wYXRo Owo+ID4gPiArCj4gPiA+ICsgICAgZG9tcGF0aCA9IGxpYnhsX194c19nZXRfZG9tcGF0aChnYywg ZG9taWQpOwo+ID4gPiArICAgIGlmICghZG9tcGF0aCkgewo+ID4gPiArICAgICAgICByYyA9IEVS Uk9SX0ZBSUw7Cj4gPiA+ICsgICAgICAgIGdvdG8gb3V0Owo+ID4gPiArICAgIH0KPiA+ID4gKwo+ ID4gPiArICAgIGZvciAoaSA9IDA7IGkgPCBtYXhfdmNwdXM7IGkrKykgewo+ID4gPiArICAgICAg ICBjb25zdCBjaGFyICpwYXRoID0gR0NTUFJJTlRGKCIlcy9jcHUvJXUvYXZhaWxhYmlsaXR5Iiwg ZG9tcGF0aCwgaSk7Cj4gPiA+ICsgICAgICAgIGNvbnN0IGNoYXIgKmNvbnRlbnQgPSBsaWJ4bF9f eHNfcmVhZChnYywgWEJUX05VTEwsIHBhdGgpOwo+ID4gPiArICAgICAgICBpZiAoIXN0cm5jbXAo Y29udGVudCwgIm9ubGluZSIsIHN0cmxlbigib25saW5lIikpKQo+ID4gCj4gPiBJIGRvbid0IHRo aW5rIHN0cm5jbXAgaXMgdXNlZnVsbCBoZXJlIGFzIG9uZSBvZiB0aGUgYXJndW1lbnQgaXMgYSBw bGFpbgo+ID4gc3RyaW5nLiBPbmUgY291bGQganVzdCB1c2Ugc3RyY21wPwo+ID4gCj4gCj4gRmlu ZSBieSBtZSBvZiBjb3Vyc2UuCj4gCj4gPiA+ICsgICAgICAgICAgICBsaWJ4bF9iaXRtYXBfc2V0 KG1hcCwgaSk7Cj4gPiA+ICsgICAgfQo+ID4gPiArCj4gPiA+ICsgICAgcmMgPSAwOwo+ID4gPiAr b3V0Ogo+ID4gPiArICAgIHJldHVybiByYzsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiAgaW50IGxp YnhsX3JldHJpZXZlX2RvbWFpbl9jb25maWd1cmF0aW9uKGxpYnhsX2N0eCAqY3R4LCB1aW50MzJf dCBkb21pZCwKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs aWJ4bF9kb21haW5fY29uZmlnICpkX2NvbmZpZykKPiA+ID4gIHsKPiA+ID4gQEAgLTcyNzAsNiAr NzMxNyw0NiBAQCBpbnQgbGlieGxfcmV0cmlldmVfZG9tYWluX2NvbmZpZ3VyYXRpb24obGlieGxf Y3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkLAo+ID4gPiAgICAgICAgICBsaWJ4bF9kb21pbmZvX2Rp c3Bvc2UoJmluZm8pOwo+ID4gPiAgICAgIH0KPiA+ID4gIAo+ID4gPiArICAgIC8qIFZDUFVzICov Cj4gPiA+ICsgICAgewo+ID4gPiArICAgICAgICBsaWJ4bF9iaXRtYXAgKm1hcCA9ICZkX2NvbmZp Zy0+Yl9pbmZvLmF2YWlsX3ZjcHVzOwo+ID4gPiArICAgICAgICB1bnNpZ25lZCBpbnQgbWF4X3Zj cHVzID0gZF9jb25maWctPmJfaW5mby5tYXhfdmNwdXM7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICAg bGlieGxfYml0bWFwX2Rpc3Bvc2UobWFwKTsKPiA+ID4gKyAgICAgICAgbGlieGxfYml0bWFwX2lu aXQobWFwKTsKPiA+ID4gKyAgICAgICAgbGlieGxfYml0bWFwX2FsbG9jKENUWCwgbWFwLCBtYXhf dmNwdXMpOwo+ID4gPiArICAgICAgICBsaWJ4bF9iaXRtYXBfc2V0X25vbmUobWFwKTsKPiA+ID4g Kwo+ID4gPiArICAgICAgICBzd2l0Y2ggKGRfY29uZmlnLT5iX2luZm8udHlwZSkgewo+ID4gPiAr ICAgICAgICBjYXNlIExJQlhMX0RPTUFJTl9UWVBFX0hWTToKPiA+ID4gKyAgICAgICAgICAgIHN3 aXRjaCAoZF9jb25maWctPmJfaW5mby5kZXZpY2VfbW9kZWxfdmVyc2lvbikgewo+ID4gPiArICAg ICAgICAgICAgY2FzZSBMSUJYTF9ERVZJQ0VfTU9ERUxfVkVSU0lPTl9RRU1VX1hFTjoKPiA+ID4g KyAgICAgICAgICAgICAgICByYyA9IGxpYnhsX191cGRhdGVfYXZhaWxfdmNwdXNfcW1wKGdjLCBk b21pZCwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIG1heF92Y3B1cywgbWFwKTsKPiA+ID4gKyAgICAgICAgICAgICAgICBicmVhazsKPiA+ ID4gKyAgICAgICAgICAgIGNhc2UgTElCWExfREVWSUNFX01PREVMX1ZFUlNJT05fUUVNVV9YRU5f VFJBRElUSU9OQUw6Cj4gPiA+ICsgICAgICAgICAgICBjYXNlIExJQlhMX0RFVklDRV9NT0RFTF9W RVJTSU9OX05PTkU6Cj4gPiA+ICsgICAgICAgICAgICAgICAgcmMgPSBsaWJ4bF9fdXBkYXRlX2F2 YWlsX3ZjcHVzX3hlbnN0b3JlKGdjLCBkb21pZCwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWF4X3ZjcHVzLCBtYXApOwo+ID4g PiArICAgICAgICAgICAgICAgIGJyZWFrOwo+ID4gPiArICAgICAgICAgICAgZGVmYXVsdDoKPiA+ ID4gKyAgICAgICAgICAgIGFib3J0KCk7Cj4gPiAKPiA+IE1pc3NpbmcgaW5kZW50YXRpb24gZm9y IGFib3J0Lgo+ID4gCj4gCj4gV2lsbCBmaXguCj4gCj4gPiBBbHNvLCB0aGF0IGlzIHdoZXJlIHhs IGFib3J0IG9uIG1pZ3JhdGlvbi4KPiA+IAo+IAo+IEhtbS4uLiAgVGhpcyBtZWFucyB0aGUgZGV2 aWNlIG1vZGVsIHZlcnNpb24gaXMgbm90IHZhbGlkICh1bmtub3duPykuCj4gCj4gQ2FuIHlvdSBw YXN0ZSBpbiB5b3VyIGd1ZXN0IGNvbmZpZz8KCldpdGggYWxsIGNvbW1lbnRlZCBsaW5lIHJlbW92 ZWQ6CgpidWlsZGVyID0gJ2h2bScKbWVtb3J5ID0gNTAwCnZjcHVzID0gMgptYXh2Y3B1cyA9IDYK bmFtZSA9ICJhcmNoIgp2aWYgPSBbICd0eXBlPWlvZW11LG1hYz0wMDoxNjozZTpYWDpYWDpYWCcg XQpkaXNrID0gWwoncGh5Oi9kZXYvdmc0Mi9ndWVzdF9hcmNoNjQsaGRhLHcnLAogJ2ZpbGU6L3Jv b3Qvdm0vaXNvL2FyY2hsaW51eC0yMDE0LjA0LjAxLWR1YWwuaXNvLGhkYzpjZHJvbSxyJywKXQpk ZXZpY2VfbW9kZWxfYXJnc19odm0gPSBbCl0KdXNiZGV2aWNlPSd0YWJsZXQnCmJvb3Q9ImNkIgpz ZXJpYWw9J3B0eScKc2RsID0gMAp2bmMgPSAxCnZuY2xpc3RlbiA9ICcwLjAuMC4wJwp2bmN1bnVz ZWQgPSAxCnNwaWNlPTAKdXVpZCA9ICJYWFhYIgoKCi0tIApBbnRob255IFBFUkFSRAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4t ZGV2ZWwK