From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary
Date: Tue, 14 Jun 2016 15:18:46 +0100 [thread overview]
Message-ID: <20160614141846.GP28116@citrix.com> (raw)
In-Reply-To: <22368.4471.73040.480893@mariner.uk.xensource.com>
On Tue, Jun 14, 2016 at 03:15:19PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary"):
> > On Tue, Jun 14, 2016 at 11:18:16AM +0100, Ian Jackson wrote:
> > > Wei Liu writes ("[PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary"):
> > > > The original code is bogus because the common case is no HA enabled.
> > > > Setting ha variable at the beginning is not very useful.
> > >
> > > This seems like a plausible cleanup but I don't understand why you say
> > > the original code is `bogus'. Is it wrong ? If so you don't say how.
> >
> > What I meant is "the default state should be no HA enabled", hence if we
> > don't move the ha variable into a narrower scope it should have been
> > initialised to NULL first. It is not a bug though.
>
> IC. Perhaps you'd like to clarify the commit message ?
Sure, I will incorporate my reply above to the commit message.
> Whether or not you do,
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Thanks.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-14 14:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 10:52 [PATCH 0/6] xl/libxl: some cleanup / debugging aid patches Wei Liu
2016-06-06 10:52 ` [PATCH 1/6] xl: remus/colo: only initialise ha variable when necessary Wei Liu
2016-06-14 10:18 ` Ian Jackson
2016-06-14 10:23 ` Wei Liu
2016-06-14 14:15 ` Ian Jackson
2016-06-14 14:18 ` Wei Liu [this message]
2016-06-06 10:52 ` [PATCH 2/6] libxl: add emacs block to libxl_linux.c Wei Liu
2016-06-14 10:19 ` Ian Jackson
2016-06-06 10:52 ` [PATCH 3/6] libxl: linux hotplug: clean up get_hotplug_env Wei Liu
2016-06-14 10:20 ` Ian Jackson
2016-06-06 10:52 ` [PATCH 4/6] libxl: debug output for args and env when invoking hotplug script Wei Liu
2016-06-14 10:26 ` Ian Jackson
2016-06-14 12:46 ` Wei Liu
2016-07-02 10:21 ` Wei Liu
2016-07-04 17:06 ` Ian Jackson
2016-07-06 17:23 ` Wei Liu
2016-06-06 10:52 ` [PATCH 5/6] libxl: rename a field in libxl__domain_create_state Wei Liu
2016-06-14 10:27 ` Ian Jackson
2016-06-06 10:52 ` [PATCH 6/6] libxl: log file name in failure in libxl__create_qemu_logfile Wei Liu
2016-06-14 10:28 ` Ian Jackson
2016-06-14 13:10 ` [PATCH 0/6] xl/libxl: some cleanup / debugging aid patches Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614141846.GP28116@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).