xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes
Date: Tue, 14 Jun 2016 15:23:53 +0100	[thread overview]
Message-ID: <20160614142353.GM5666@perard.uk.xensource.com> (raw)
In-Reply-To: <57600DEC.6040405@citrix.com>

On Tue, Jun 14, 2016 at 03:00:12PM +0100, George Dunlap wrote:
> On 14/06/16 14:53, Anthony PERARD wrote:
> > On Tue, Jun 14, 2016 at 11:34:43AM +0100, George Dunlap wrote:
> >> That code might be in qemu-upstream, but it's not in the qemu-xen trees;
> >> if you revert this bit of the patch and try to build with raisin it will
> >> fail.  That's why I even bothered to add these in in the first place;
> >> and why IanC added these runes to tools/Makefile.
> >>
> >> Anthony, can you comment more authoritatively here on what's going on?
> > 
> > Yes, easy, xen-4.7 introduce a new API but qemu-xen-4.7 does not know
> > about it, so qemu-xen will fail to compile. But there are some magic
> > flags that are use to provide an compatible API and can qemu-xen
> > compile.
> > 
> > QEMU have been taught about the new API and will use it, without the
> > magic flags. QEMU will actually ignore the magic flags with a bunch of
> > #undef.
> 
> So wait, I'm confused.  Isn't qemu-xen supposed to be upstream qemu plus
> a handful of patches on top?  Or has there not been a QEMU release since
> the time the new API?

The first release to include the new stuff appear to be 2.6, which have
been released a month ago. So the answer is no.

> Why on earth are we shipping in 4.7 a qemu that
> can't use the new API we define in 4.7?

Who knows...

> >> Would it be possible for 4.7.1 to backport the configure auto-detection
> >> stuff?
> > 
> > I think that would be possible. But backporting the use of the new api
> > will probably be harder. I guess we could just have qemu-xen define the
> > magic flags itself instead of relying on them been given via a configure
> > option.
> 
> Well at this point it's a bit late to import support for the new API
> into qemu-xen-4.7; but it would be good for 4.7.1 to have qemu-xen's
> configure set the necessary flags rather than bodging them in via
> "--extra-cflags" in the Xen makefile.

Yes.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-14 14:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 14:44 [PATCH raisin 0/4] Fixes for 4.6, update to 4.7 George Dunlap
2016-06-13 14:44 ` [PATCH raisin 1/4] components/xen: Actually disable rombios George Dunlap
2016-06-14  9:32   ` Stefano Stabellini
2016-06-13 14:44 ` [PATCH raisin 2/4] config: Separate config urls into a separate file George Dunlap
2016-06-14  9:34   ` Stefano Stabellini
2016-06-13 14:44 ` [PATCH raisin 3/4] Update config-4.6 and config-4.5 to point to stable branches George Dunlap
2016-06-14  9:40   ` Stefano Stabellini
2016-06-14  9:57     ` George Dunlap
2016-06-14 10:01       ` Stefano Stabellini
2016-06-14 10:10         ` George Dunlap
2016-06-15 10:24           ` Stefano Stabellini
2016-06-15 10:38             ` George Dunlap
2016-06-15 10:53               ` Stefano Stabellini
2016-06-15 11:13                 ` George Dunlap
2016-06-15 14:02                   ` Stefano Stabellini
2016-06-15 16:11                     ` George Dunlap
2016-06-13 14:44 ` [PATCH raisin 4/4] Update to 4.7, update qemu and qemu_traditional recipes George Dunlap
2016-06-14  9:46   ` Stefano Stabellini
2016-06-14 10:03     ` George Dunlap
2016-06-14 10:08       ` Stefano Stabellini
2016-06-14 10:17         ` George Dunlap
2016-06-14 10:31           ` Stefano Stabellini
2016-06-14 10:34             ` George Dunlap
2016-06-14 13:53               ` Anthony PERARD
2016-06-14 14:00                 ` George Dunlap
2016-06-14 14:23                   ` Anthony PERARD [this message]
2016-06-14 14:38                     ` George Dunlap
2016-06-15 10:39                 ` Stefano Stabellini
2016-06-15 10:42                   ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614142353.GM5666@perard.uk.xensource.com \
    --to=anthony.perard@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).