xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH XTF] tests: add fep test
Date: Mon, 20 Jun 2016 15:31:29 +0100	[thread overview]
Message-ID: <20160620143129.GQ28116@citrix.com> (raw)
In-Reply-To: <9f7f768a-93c0-167d-365a-5e6be546f8c4@citrix.com>

On Mon, Jun 20, 2016 at 02:43:47PM +0100, Andrew Cooper wrote:
> On 17/06/16 15:21, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> LGTM, although a couple of comments.
> 
> > ---
> >  tests/fep/Makefile | 12 ++++++++++++
> >  tests/fep/main.c   | 31 +++++++++++++++++++++++++++++++
> 
> Please add this to the test index in docs/all-tests.dox
> 

Done.

> >  2 files changed, 43 insertions(+)
> >  create mode 100644 tests/fep/Makefile
> >  create mode 100644 tests/fep/main.c
> >
> > diff --git a/tests/fep/Makefile b/tests/fep/Makefile
> > new file mode 100644
> > index 0000000..8702123
> > --- /dev/null
> > +++ b/tests/fep/Makefile
> > @@ -0,0 +1,12 @@
> > +MAKEFLAGS += -r
> > +ROOT := $(abspath $(CURDIR)/../..)
> > +
> > +include $(ROOT)/build/common.mk
> > +
> > +NAME      := fep
> > +CATEGORY  := utility
> > +TEST-ENVS := $(HVM_ENVIRONMENTS)
> 
> This really doesn't need to be all HVM environments.  FEP is a property
> of the HVM container, not of the running mode of the domain.  hvm32
> would be fine here, and the most simple option.
> 

Done.

> > +
> > +obj-perenv += main.o
> > +
> > +include $(ROOT)/build/gen.mk
> > diff --git a/tests/fep/main.c b/tests/fep/main.c
> > new file mode 100644
> > index 0000000..34a93c0
> > --- /dev/null
> > +++ b/tests/fep/main.c
> > @@ -0,0 +1,31 @@
> > +/**
> > + * @file tests/fep/main.c
> > + * @ref test-fep
> > + *
> > + * @page test-fep FEP
> > + *
> > + * Returns SUCCESS if FEP is available, FAILURE if not.
> 
> This is the content one will find from the test index, and as such,
> should be the most complete.  At the very least, I would add a sentence
> explaining what FEP is.
> 

Sure.

V2 coming soon.

Wei.

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-06-20 14:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 14:21 Wei Liu
2016-06-20 13:43 ` Andrew Cooper
2016-06-20 14:31   ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160620143129.GQ28116@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH XTF] tests: add fep test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).