Re: [PATCH RESEND 04/14] tools: add ACPI tables relevant definitions (and more)

From: Wei Liu <wei.liu2@citrix.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	ian.jackson@eu.citrix.com, peter.huangpeng@huawei.com,
	xen-devel@lists.xen.org, Julien Grall <julien.grall@arm.com>,
	shannon.zhao@linaro.org
Subject: Re: [PATCH RESEND 04/14] tools: add ACPI tables relevant definitions (and more)
Date: Wed, 22 Jun 2016 10:38:47 +0100	[thread overview]
Message-ID: <20160622093847.GA1790@citrix.com> (raw)
In-Reply-To: <576A04D7.5010504@huawei.com>

On Wed, Jun 22, 2016 at 11:24:07AM +0800, Shannon Zhao wrote:
[...]
> > But please make sure the CFLAGS doesn't get modified when it is not
> > necessary.  I would expect the CFLAGS is explicitly altered for a list
> > of files.
> I'm trying to do this. Make the libxl acpi codes compile like below in
> Makefile:
> 
> +libxl_arm_acpi.o: libxl_arm_acpi.c
> +       $(CC) -c $(CFLAGS) -I../../xen/include/ -o $@ libxl_arm_acpi.c
> 
> Add #include <acpi/actbl.h> which includes the tables definitions in
> libxl_arm_acpi.c. But there are a lot of compiling errors like below:
> error: unknown type name 'u8'
> error: unknown type name 'u32'
> Looks like these types are defined in xen/include/asm-arm/types.h. I add
> #include <asm-arm/types.h> in libxl_arm_acpi.c but it still compiles failed.
> In file included from ../../xen/include/asm-arm/types.h:6:0,
>                  from libxl_arm_acpi.c:30:
> ../../xen/include/xen/config.h:10:32: fatal error: generated/autoconf.h:
> No such file or directory
>  #include <generated/autoconf.h>
> 
> Looks like if we try to use the acpi headers under xen/include/acpi like
> this way, tools compilation will depends on hypervisor compilation. I
> think this is not what we want, right?
> 

Hmm... I thought all the ACPI headers are self-contained, but they are
actually not from your description.

But, we do have one precedent -- the libelf header. If you look at
xen/include/xen/libelf.h, the header itself contains define guards to
include the right header. Can you do the same for ACPI header?

Julien wrote:
> You could define our own u8, u32 types in libxc. They are just aliased
> to uint8_t, uint32_t.

I would avoid doing that. I would rather you confine what is necessary
in acpi headers.

Feel free to ask more questions if you're in doubt.

Wei.

> Any suggestion?
> 
> Thanks,
> -- 
> Shannon
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel