From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] libxl: fix an error path that uses uninitialised rc in libxl_set_memory_target Date: Wed, 22 Jun 2016 14:59:34 +0100 Message-ID: <20160622135934.GF1790@citrix.com> References: <1465740590-21337-1-git-send-email-wei.liu2@citrix.com> <576AA79402000078000F7AC6@prv-mh.provo.novell.com> <20160622134704.GE1790@citrix.com> <576AB49402000078000F7B56@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFigu-0005oq-QO for xen-devel@lists.xenproject.org; Wed, 22 Jun 2016 13:59:40 +0000 Content-Disposition: inline In-Reply-To: <576AB49402000078000F7B56@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: George Dunlap , Ian Jackson , Wei Liu , Paulina Szubarczyk , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBKdW4gMjIsIDIwMTYgYXQgMDc6NTM6NTZBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDIyLjA2LjE2IGF0IDE1OjQ3LCA8d2VpLmxpdTJAY2l0cml4LmNvbT4gd3Jv dGU6Cj4gPiBPbiBXZWQsIEp1biAyMiwgMjAxNiBhdCAwNjo1ODoyOEFNIC0wNjAwLCBKYW4gQmV1 bGljaCB3cm90ZToKPiA+PiA+Pj4gT24gMTIuMDYuMTYgYXQgMTY6MDksIDx3ZWkubGl1MkBjaXRy aXguY29tPiB3cm90ZToKPiA+PiA+IC0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiA+PiA+ICsr KyBiL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiA+PiA+IEBAIC00OTI3LDEwICs0OTI3LDEyIEBAIHJl dHJ5X3RyYW5zYWN0aW9uOgo+ID4+ID4gIAo+ID4+ID4gICAgICB0YXJnZXQgPSBsaWJ4bF9feHNf cmVhZChnYywgdCwgR0NTUFJJTlRGKCIlcy9tZW1vcnkvdGFyZ2V0IiwgZG9tcGF0aCkpOwo+ID4+ ID4gICAgICBpZiAoIXRhcmdldCAmJiAhZG9taWQpIHsKPiA+PiA+IC0gICAgICAgIGlmICgheHNf dHJhbnNhY3Rpb25fZW5kKGN0eC0+eHNoLCB0LCAxKSkKPiA+PiA+ICsgICAgICAgIGlmICgheHNf dHJhbnNhY3Rpb25fZW5kKGN0eC0+eHNoLCB0LCAxKSkgewo+ID4+ID4gKyAgICAgICAgICAgIHJj ID0gRVJST1JfRkFJTDsKPiA+PiAKPiA+PiBJJ20gc29ycnkgZm9yIG5vdGljaW5nIHRoaXMgb25s eSBub3cgLSBpcyBFUlJPUl9GQUlMIHRoZSByaWdodCB0aGluZwo+ID4+IHRvIHVzZSBoZXJlLCBj b25zaWRlcmluZyBob3cgdGhpbmdzIHdvcmtlZCBiZWZvcmUgdGhlIGNoYW5nZSB0aGF0Cj4gPj4g aW50cm9kdWNlZCB0aGUgaXNzdWUgZ2V0dGluZyBmaXhlZCBoZXJlPyBJIGhhZCBpbnRlbnRpb25h bGx5IGRlY2lkZWQKPiA+PiB0byB1c2UgRVJST1JfSU5WQUwgaW4gdGhlIHBhdGNoIHZhcmlhbnQg SSBkaWQgc3VibWl0IChhcyBhdCB0aGF0Cj4gPj4gdGltZSBJIHdhc24ndCB5ZXQgYXdhcmUgb2Yg dGhlIG90aGVyIGZpeCBmbG9hdGluZyBhcm91bmQgYWxyZWFkeSkuCj4gPj4gCj4gPiAKPiA+IFdo ZW4gSSB3cm90ZSB0aGlzIHBhdGNoLCBJIHRob3VnaHQgdGhlIHJldHVybiB2YWx1ZSBzaG91bGQg YmUgdGllZCB0bwo+ID4geHNfdHJhbnNhY3Rpb25fZW5kLgo+IAo+IHhzX3RyYW5zYWN0aW9uX2Vu ZCgpIHJldHVybmluZyB6ZXJvIG1lYW5zIHN1Y2Nlc3MgYWZhaWN0Lgo+IAoKLyogRW5kIGEgdHJh bnNhY3Rpb24uCiAqIElmIGFiYW5kb24gaXMgdHJ1ZSwgdHJhbnNhY3Rpb24gaXMgZGlzY2FyZGVk IGluc3RlYWQgb2YgY29tbWl0dGVkLgogKiBSZXR1cm5zIGZhbHNlIG9uIGZhaWx1cmU6IGlmIGVy cm5vID09IEVBR0FJTiwgeW91IGhhdmUgdG8gcmVzdGFydAogKiB0cmFuc2FjdGlvbi4KICovCmJv b2wgeHNfdHJhbnNhY3Rpb25fZW5kKHN0cnVjdCB4c19oYW5kbGUgKmgsIHhzX3RyYW5zYWN0aW9u X3QgdCwKICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBhYm9ydCk7CgpJIHRoaW5rIHlvdSBt aXNyZWFkLgoKV2VpLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRw Oi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK