From: Roger Pau Monne <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible
Date: Thu, 7 Jul 2016 11:44:05 +0200 [thread overview]
Message-ID: <20160707094405.mgv6uykxmqsq4fi2__7106.72968202761$1467884739$gmane$org@mac> (raw)
In-Reply-To: <577E29A902000078000FBF28@prv-mh.provo.novell.com>
On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
> ... as being the simpler variant.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> drivers/block/xen-blkfront.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
> @@ -1825,14 +1825,13 @@ again:
> }
> kfree(path);
> }
> - err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
> - XEN_IO_PROTO_ABI_NATIVE);
> + err = xenbus_write(xbt, dev->nodename, "protocol",
> + XEN_IO_PROTO_ABI_NATIVE);
> if (err) {
> message = "writing protocol";
> goto abort_transaction;
> }
> - err = xenbus_printf(xbt, dev->nodename,
> - "feature-persistent", "%u", 1);
> + err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
AFAICT you forgot to replace xenbus_printf with xenbus_write here.
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next parent reply other threads:[~2016-07-07 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <577E29A902000078000FBF28@prv-mh.provo.novell.com>
2016-07-07 9:44 ` Roger Pau Monne [this message]
[not found] ` <20160707094405.mgv6uykxmqsq4fi2@mac>
2016-07-07 10:00 ` [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible Jan Beulich
2016-07-07 8:06 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20160707094405.mgv6uykxmqsq4fi2__7106.72968202761$1467884739$gmane$org@mac' \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).