From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v5 01/14] libxc: Rework extra module initialisation Date: Fri, 8 Jul 2016 14:26:24 +0100 Message-ID: <20160708132624.GG1729@perard.uk.xensource.com> References: <20160622171545.5304-1-anthony.perard@citrix.com> <20160622171545.5304-2-anthony.perard@citrix.com> <20160707145523.GO416@citrix.com> <20160708105207.GE1729@perard.uk.xensource.com> <20160708112935.GR416@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160708112935.GR416@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBKdWwgMDgsIDIwMTYgYXQgMTI6Mjk6MzZQTSArMDEwMCwgV2VpIExpdSB3cm90ZToK PiBPbiBGcmksIEp1bCAwOCwgMjAxNiBhdCAxMTo1MjowOEFNICswMTAwLCBBbnRob255IFBFUkFS RCB3cm90ZToKPiA+IE9uIFRodSwgSnVsIDA3LCAyMDE2IGF0IDAzOjU1OjIzUE0gKzAxMDAsIFdl aSBMaXUgd3JvdGU6Cj4gPiA+IE9uIFdlZCwgSnVuIDIyLCAyMDE2IGF0IDA2OjE1OjMyUE0gKzAx MDAsIEFudGhvbnkgUEVSQVJEIHdyb3RlOgo+ID4gPiA+IGRpZmYgLS1naXQgYS90b29scy9saWJ4 Yy94Y19kb21faHZtbG9hZGVyLmMgYi90b29scy9saWJ4Yy94Y19kb21faHZtbG9hZGVyLmMKPiA+ ID4gPiBpbmRleCAzMzBkNWU4Li5kYThiOTk1IDEwMDY0NAo+ID4gPiA+IC0tLSBhL3Rvb2xzL2xp YnhjL3hjX2RvbV9odm1sb2FkZXIuYwo+ID4gPiA+ICsrKyBiL3Rvb2xzL2xpYnhjL3hjX2RvbV9o dm1sb2FkZXIuYwo+ID4gPiA+IEBAIC0xMjksOTggKzEyOSw1MiBAQCBzdGF0aWMgZWxmX2Vycm9y c3RhdHVzIHhjX2RvbV9wYXJzZV9odm1fa2VybmVsKHN0cnVjdCB4Y19kb21faW1hZ2UgKmRvbSkK PiA+ID4gPiAgICAgIHJldHVybiByYzsKPiA+ID4gPiAgfQo+ID4gPiA+ICAKPiA+ID4gPiAtc3Rh dGljIGludCBtb2R1bGVzX2luaXQoc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tLAo+ID4gPiA+IC0g ICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCB2ZW5kLCBzdHJ1Y3QgZWxmX2JpbmFyeSAq ZWxmLAo+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCAqbXN0YXJ0X291 dCwgdWludDY0X3QgKm1lbmRfb3V0KQo+ID4gPiA+ICtzdGF0aWMgaW50IG1vZHVsZV9pbml0X29u ZShzdHJ1Y3QgeGNfZG9tX2ltYWdlICpkb20sCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0cnVjdCB4Y19odm1fZmlybXdhcmVfbW9kdWxlICptb2R1bGUsCj4gPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNoYXIgKm5hbWUpCj4gPiA+ID4gIHsKPiA+ID4gPiAt I2RlZmluZSBNT0RVTEVfQUxJR04gMVVMIDw8IDcKPiA+ID4gPiAtI2RlZmluZSBNQl9BTElHTiAg ICAgMVVMIDw8IDIwCj4gPiA+ID4gLSNkZWZpbmUgTUtBTElHTih4LCBhKSAoKCh1aW50NjRfdCko eCkgKyAoYSkgLSAxKSAmIH4odWludDY0X3QpKChhKSAtIDEpKQo+ID4gPiA+IC0gICAgdWludDY0 X3QgdG90YWxfbGVuID0gMCwgb2Zmc2V0MSA9IDA7Cj4gPiA+ID4gKyAgICBzdHJ1Y3QgeGNfZG9t X3NlZyBzZWc7Cj4gPiA+ID4gKyAgICB2b2lkICpkZXN0Owo+ID4gPiA+ICAKPiA+ID4gPiAtICAg IGlmICggZG9tLT5hY3BpX21vZHVsZS5sZW5ndGggPT0gMCAmJiBkb20tPnNtYmlvc19tb2R1bGUu bGVuZ3RoID09IDAgKQo+ID4gPiA+IC0gICAgICAgIHJldHVybiAwOwo+ID4gPiA+IC0KPiA+ID4g PiAtICAgIC8qIEZpbmQgdGhlIHRvdGFsIGxlbmd0aCBmb3IgdGhlIGZpcm13YXJlIG1vZHVsZXMg d2l0aCBhIHJlYXNvbmFibGUgbGFyZ2UKPiA+ID4gPiAtICAgICAqIGFsaWdubWVudCBzaXplIHRv IGFsaWduIGVhY2ggdGhlIG1vZHVsZXMuCj4gPiA+ID4gLSAgICAgKi8KPiA+ID4gPiAtICAgIHRv dGFsX2xlbiA9IE1LQUxJR04oZG9tLT5hY3BpX21vZHVsZS5sZW5ndGgsIE1PRFVMRV9BTElHTik7 Cj4gPiA+ID4gLSAgICBvZmZzZXQxID0gdG90YWxfbGVuOwo+ID4gPiA+IC0gICAgdG90YWxfbGVu ICs9IE1LQUxJR04oZG9tLT5zbWJpb3NfbW9kdWxlLmxlbmd0aCwgTU9EVUxFX0FMSUdOKTsKPiA+ ID4gPiAtCj4gPiA+ID4gLSAgICAvKiBXYW50IHRvIHBsYWNlIHRoZSBtb2R1bGVzIDFNYitjaGFu Z2UgYmVoaW5kIHRoZSBsb2FkZXIgaW1hZ2UuICovCj4gPiA+ID4gLSAgICAqbXN0YXJ0X291dCA9 IE1LQUxJR04oZWxmLT5wZW5kLCBNQl9BTElHTikgKyAoTUJfQUxJR04pOwo+ID4gPiA+IC0gICAg Km1lbmRfb3V0ID0gKm1zdGFydF9vdXQgKyB0b3RhbF9sZW47Cj4gPiA+ID4gLQo+ID4gPiA+IC0g ICAgaWYgKCAqbWVuZF9vdXQgPiB2ZW5kICkKPiA+ID4gPiAtICAgICAgICByZXR1cm4gLTE7Cj4g PiA+ID4gLQo+ID4gPiA+IC0gICAgaWYgKCBkb20tPmFjcGlfbW9kdWxlLmxlbmd0aCAhPSAwICkK PiA+ID4gPiAtICAgICAgICBkb20tPmFjcGlfbW9kdWxlLmd1ZXN0X2FkZHJfb3V0ID0gKm1zdGFy dF9vdXQ7Cj4gPiA+ID4gLSAgICBpZiAoIGRvbS0+c21iaW9zX21vZHVsZS5sZW5ndGggIT0gMCAp Cj4gPiA+ID4gLSAgICAgICAgZG9tLT5zbWJpb3NfbW9kdWxlLmd1ZXN0X2FkZHJfb3V0ID0gKm1z dGFydF9vdXQgKyBvZmZzZXQxOwo+ID4gPiA+ICsgICAgaWYgKCBtb2R1bGUtPmxlbmd0aCApCj4g PiA+ID4gKyAgICB7Cj4gPiA+ID4gKyAgICAgICAgaWYgKCB4Y19kb21fYWxsb2Nfc2VnbWVudChk b20sICZzZWcsIG5hbWUsIDAsIG1vZHVsZS0+bGVuZ3RoKSApCj4gPiA+ID4gKyAgICAgICAgICAg IGdvdG8gZXJyOwo+ID4gPiA+ICsgICAgICAgIGRlc3QgPSB4Y19kb21fc2VnX3RvX3B0cihkb20s ICZzZWcpOwo+ID4gPiA+ICsgICAgICAgIGlmICggZGVzdCA9PSBOVUxMICkKPiA+ID4gPiArICAg ICAgICB7Cj4gPiA+ID4gKyAgICAgICAgICAgIERPTVBSSU5URigiJXM6IHhjX2RvbV9zZWdfdG9f cHRyKGRvbSwgJnNlZykgPT4gTlVMTCIsCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICBf X0ZVTkNUSU9OX18pOwo+ID4gPiA+ICsgICAgICAgICAgICBnb3RvIGVycjsKPiA+ID4gPiArICAg ICAgICB9Cj4gPiA+ID4gKyAgICAgICAgbWVtY3B5KGRlc3QsIG1vZHVsZS0+ZGF0YSwgbW9kdWxl LT5sZW5ndGgpOwo+ID4gPiA+ICsgICAgICAgIG1vZHVsZS0+Z3Vlc3RfYWRkcl9vdXQgPSBzZWcu dnN0YXJ0Owo+ID4gPiA+ICsgICAgICAgIGlmICggbW9kdWxlLT5ndWVzdF9hZGRyX291dCA+IFVJ TlQzMl9NQVggfHwKPiA+ID4gPiArICAgICAgICAgICAgIG1vZHVsZS0+Z3Vlc3RfYWRkcl9vdXQg KyBtb2R1bGUtPmxlbmd0aCA+IFVJTlQzMl9NQVggKQo+ID4gPiA+ICsgICAgICAgIHsKPiA+ID4g PiArICAgICAgICAgICAgRE9NUFJJTlRGKCIlczogTW9kdWxlICVzIHdvdWxkIGJlIGxvYWRlZCBh YnJvdmUgNEdCIiwKPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgIF9fRlVOQ1RJT05fXywg bmFtZSk7Cj4gPiA+ID4gKyAgICAgICAgICAgIGdvdG8gZXJyOwo+ID4gPiA+ICsgICAgICAgIH0K PiA+ID4gCj4gPiA+IE9uZSBxdWVzdGlvbjoKPiA+ID4gCj4gPiA+IENhbiB0aGlzIGNoZWNrIGFs c28gYWNjb3VudCBmb3IgTU1JTyBob2xlIGJlbG93IDRHPyBNYXliZSB1c2UKPiA+ID4gZG9tLT5t bWlvX3NpemU/Cj4gPiAKPiA+IFllcywgSSBndWVzcyBJIGNhbiBjaGVjayBhZ2FpbnN0IGRvbS0+ bW1pb19zdGFydC4gU2hvdWxkIEkgYWxzbyBjaGVjawo+ID4gdGhhdCBtbWlvX3N0YXJ0IGhhdmUg cmVhc29uYWJsZSB2YWx1ZT8gKDw0RywgYW5kIG5vdCAweDApIE9yIGlzCj4gPiBtbWlvX3N0YXJ0 IGlzIGFscmVhZHkgc3VwcG9zZWQgdG8gaGF2ZSBhIGdvb2QgdmFsdWU/Cj4gPiAKPiAKPiBtbWlv X3N0YXJ0IHNob3VsZCBhbHJlYWR5IGhhdmUgYSBzYW5lIHZhbHVlIGhlcmUgLS0gb3IgYXQgbGVh c3QgSSBob3BlCj4gc28uIFRoZSBzYW5pdHkgb2YgbW1pb19zdGFydCBzaG91bGQgYmUgY2hlY2tl ZCB3aGVyZSBpdCBpcyBhc3NpZ25lZC4KCk9rLCBJJ2xsIHVzZSBkb20tPm1taW9fc3RhcnQgaW5z dGVhZCBvZiBVSU5UMzJfTUFYLCBhbmQgcHJvYmFibHkgYWRkIGFuCmFzc2VydCgpIG9uIHRoZSB2 YWx1ZXMgZXhwZWN0ZWQgaW4gbW1pb19zdGFydC4KClRoYW5rcywKCi0tIApBbnRob255IFBFUkFS RAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg==