From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2] libxl: trigger attach events for devices attached before xl devd startup
Date: Mon, 11 Jul 2016 12:53:43 +0200 [thread overview]
Message-ID: <20160711105342.5wss6iznzpazloqo@mac> (raw)
In-Reply-To: <1468233882-9507-1-git-send-email-marmarek@invisiblethingslab.com>
On Mon, Jul 11, 2016 at 12:44:42PM +0200, Marek Marczykowski-Górecki wrote:
> When this daemon is started after creating backend device, that device
> will not be configured.
>
> Racy situation:
> 1. driver domain is started
> 2. frontend domain is started (just after kicking driver domain off)
> 3. device in frontend domain is connected to the backend (as specified
> in frontend domain configuration)
> 4. xl devd is started in driver domain
>
> End result is that backend device in driver domain is not configured
> (like network interface is not enabled), so the device doesn't work.
>
> Fix this by artifically triggering events for devices already present in
> xenstore before xl devd is started. Do this only after xenstore watch is
> already registered, and only for devices not already initialized (in
> XenbusStateInitWait state).
>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Thanks, this looks fine to me:
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-11 10:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 17:35 [PATCH] libxl: trigger attach events for devices attached before xl devd startup Marek Marczykowski-Górecki
2016-07-11 8:31 ` Roger Pau Monné
2016-07-11 8:56 ` Marek Marczykowski-Górecki
2016-07-11 9:43 ` Roger Pau Monné
2016-07-11 9:49 ` Marek Marczykowski-Górecki
2016-07-11 10:00 ` Roger Pau Monné
2016-07-11 10:44 ` [PATCH v2] " Marek Marczykowski-Górecki
2016-07-11 10:53 ` Roger Pau Monné [this message]
2016-07-14 9:36 ` Wei Liu
2016-07-15 23:47 ` [PATCH v3] " Marek Marczykowski-Górecki
2016-07-18 15:31 ` Wei Liu
2016-07-19 13:20 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711105342.5wss6iznzpazloqo@mac \
--to=roger.pau@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=marmarek@invisiblethingslab.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).