From: Christoffer Dall <christoffer.dall@linaro.org>
To: Julien Grall <julien.grall@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
Ian Campbell <ijc@hellion.org.uk>,
xen-devel@lists.xenproject.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] Support for building in a Xen binary
Date: Fri, 15 Jul 2016 12:12:50 +0200 [thread overview]
Message-ID: <20160715101250.GB29219@cbox> (raw)
In-Reply-To: <5784C91C.30709@arm.com>
On Tue, Jul 12, 2016 at 11:40:28AM +0100, Julien Grall wrote:
> Hi Andre,
>
> On 20/06/16 16:09, Andre Przywara wrote:
> >diff --git a/Makefile.am b/Makefile.am
> >index 692d2cc..1a801c0 100644
> >--- a/Makefile.am
> >+++ b/Makefile.am
> >@@ -85,7 +85,6 @@ TEXT_LIMIT := 0x80080000
> > endif
> >
> > LD_SCRIPT := model.lds.S
> >-IMAGE := linux-system.axf
> >
> > FS_OFFSET := 0x10000000
> > FILESYSTEM_START:= $(shell echo $$(($(PHYS_OFFSET) + $(FS_OFFSET))))
> >@@ -108,6 +107,11 @@ CHOSEN_NODE := chosen { \
> > };
> > endif
> >
> >+if XEN
> >+XEN := -DXEN=$(XEN_IMAGE)
> >+XEN_OFFSET := 0x08200000
> >+endif
> >+
> > CPPFLAGS += $(INITRD_FLAGS)
> > CFLAGS += -Iinclude/ -I$(ARCH_SRC)/include/
> > CFLAGS += -Wall -fomit-frame-pointer
> >@@ -117,11 +121,11 @@ LDFLAGS += --gc-sections
> > OFILES += boot_common.o bakery_lock.o platform.o $(GIC) cache.o lib.o
> > OFILES += $(addprefix $(ARCH_SRC),boot.o stack.o $(BOOTMETHOD) utils.o)
> >
> >-all: $(IMAGE)
> >+all: $(IMAGE) $(XIMAGE)
>
> I cannot find where XIMAGE is set. What XIMAGE is used for?
>
I can't remember (it's been ages since I wrote this patch, then
something happened that required a more substantial rewrite of the whole
bootwrapper, which I think was then aborted anyhow, and this got lost
somehow, or something like that, and I've sort of lost momentum here),
but I think the idea was that you would build the normal linux Image
IMAGE, and XIMAGE for the xen image, so that a single build would output
both images so you could test with the same settings if the basic build
worked, and then test with Xen.
-Christoffer
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-15 10:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160620150934.1729-1-andre.przywara@arm.com>
2016-06-20 15:09 ` [PATCH 1/4] Support for building in a Xen binary Andre Przywara
2016-07-12 10:40 ` Julien Grall
2016-07-15 10:12 ` Christoffer Dall [this message]
2016-06-20 15:09 ` [PATCH 2/4] Xen: Support adding DT nodes Andre Przywara
2016-07-12 10:48 ` Julien Grall
2016-06-20 15:09 ` [PATCH 3/4] Xen: Select correct dom0 console Andre Przywara
2016-07-12 10:49 ` Julien Grall
2016-06-20 15:09 ` [PATCH 4/4] Explicitly clean linux-system.axf and xen-system.axf Andre Przywara
2016-07-12 10:58 ` Julien Grall
2016-07-12 10:31 ` [PATCH 0/4] boot-wrapper: arm64: Xen support Julien Grall
2016-08-16 18:01 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715101250.GB29219@cbox \
--to=christoffer.dall@linaro.org \
--cc=andre.przywara@arm.com \
--cc=ijc@hellion.org.uk \
--cc=jean-philippe.brucker@arm.com \
--cc=julien.grall@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).