From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] xl: rename variable pause to pause_after_migration
Date: Wed, 20 Jul 2016 11:34:34 +0100 [thread overview]
Message-ID: <20160720103434.GB28784@citrix.com> (raw)
In-Reply-To: <20160720094319.lrnadlv5ul2n5mjb@mac>
On Wed, Jul 20, 2016 at 11:43:19AM +0200, Roger Pau Monne wrote:
> On Wed, Jul 20, 2016 at 09:30:17AM +0100, Wei Liu wrote:
> > Gcc 4.4.4 complained that the "pause" variable introduced in 22b430e0
> > ("xl: add option to leave domain paused after migration") shadowed
> > pause(2) declaration in unistd.h.
> >
> > Rename "pause" to "pause_after_migration" to fix this issue.
> >
> > Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Thanks, I haven't noticied that it was shadowing pause(2).
My compile test passed. Newer gcc is happy with that. I didn't bother to
look into the differences between different gcc versions though.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-20 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 8:30 [PATCH] xl: rename variable pause to pause_after_migration Wei Liu
2016-07-20 9:43 ` Roger Pau Monne
2016-07-20 10:34 ` Wei Liu [this message]
2016-07-20 12:12 ` Ian Jackson
2016-07-20 15:24 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720103434.GB28784@citrix.com \
--to=wei.liu2@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).