From: Wei Liu <wei.liu2@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: Json config and stubdomain
Date: Mon, 26 Sep 2016 12:01:01 +0100 [thread overview]
Message-ID: <20160926110101.GB2958@citrix.com> (raw)
In-Reply-To: <20160924104245.GT7339@mail-itl>
On Sat, Sep 24, 2016 at 12:42:45PM +0200, Marek Marczykowski-Górecki wrote:
> Hi,
>
> Debugging stubdomain continuation...
> When stubdomain is started, it has no json config created. This results
> in multiple problems:
> - impossible to dynamically attach additional devices
> - starting a domain with more than one PCI device fails
>
> The second one is especially interesting because it look so much
> inconsistent: libxl__device_pci_add_xenstore when called for the first
> device, it immediately calls libxl__create_pci_backend and do not touch
> json config at all. But when called for the next device, it loads json
> config, adds the device there and save it. So it looks like the first
> PCI device will never be saved into json config (when added
> dynamically).
> In case of stubdomain, libxl__device_pci_add_xenstore is called during
> stubdomain startup, so defining two or more PCI devices means domain
> startup fail.
Please see libxl_internal.h, around line 2564. The same logic is used
across all devices.
I think there could be bugs in pci device handling code. I didn't get to
test that because my test box was not capable and the code for pci
device was (and still is) rather irregular compared to other devices.
>
> So, the question is, whether json config should be created and properly
> maintained for stubdomain, or not created at all (assuming all the
> configuration is already handled in the target domain json config)?
Stubdom configuration should be derived. It is considered internal
details.
Wei.
>
> --
> Best Regards,
> Marek Marczykowski-Górecki
> Invisible Things Lab
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-26 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 10:42 Json config and stubdomain Marek Marczykowski-Górecki
2016-09-26 11:01 ` Wei Liu [this message]
2016-09-26 11:40 ` Marek Marczykowski-Górecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926110101.GB2958@citrix.com \
--to=wei.liu2@citrix.com \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).