From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 1/2] lib/gnttab: fix build of gnttab_unimp.c
Date: Mon, 26 Sep 2016 17:49:14 +0100 [thread overview]
Message-ID: <20160926164914.GC16004@citrix.com> (raw)
In-Reply-To: <1474908249-22819-2-git-send-email-roger.pau@citrix.com>
I will change lib to libs in subject line while committing
On Mon, Sep 26, 2016 at 06:44:08PM +0200, Roger Pau Monne wrote:
> Fix the definition of the xengnttab_grant_copy function so it's inline with
in line with
> the prototypes in xengnttab.h.
>
> This unbreaks the tools build on systems that don't have a gnttab device.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/libs/gnttab/gnttab_unimp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libs/gnttab/gnttab_unimp.c b/tools/libs/gnttab/gnttab_unimp.c
> index 829eced..26e4ee1 100644
> --- a/tools/libs/gnttab/gnttab_unimp.c
> +++ b/tools/libs/gnttab/gnttab_unimp.c
> @@ -78,9 +78,9 @@ int xengnttab_unmap(xengnttab_handle *xgt, void *start_address, uint32_t count)
> abort();
> }
>
> -int xengnttab_copy_grant(xengnttab_handle *xgt,
> +int xengnttab_grant_copy(xengnttab_handle *xgt,
> uint32_t count,
> - xengnttab_copy_grant_segment_t *segs)
> + xengnttab_grant_copy_segment_t *segs)
> {
> abort();
> }
> --
> 2.7.4 (Apple Git-66)
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-26 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 16:44 [PATCH 0/2] tools: misc fixes Roger Pau Monne
2016-09-26 16:44 ` [PATCH 1/2] lib/gnttab: fix build of gnttab_unimp.c Roger Pau Monne
2016-09-26 16:49 ` Wei Liu [this message]
2016-09-26 16:44 ` [PATCH 2/2] tools/configure: fix --with-system-{ovmf/seabios} Roger Pau Monne
2016-09-26 16:57 ` Wei Liu
2016-09-26 17:15 ` Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926164914.GC16004@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).