From: Punit Agrawal <punit.agrawal@arm.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
Punit Agrawal <punit.agrawal@arm.com>,
tim@xen.org, julien.grall@arm.com, jbeulich@suse.com,
ian.jackson@eu.citrix.com
Subject: [For Xen-4.10 PATCH v2 0/3] Reduce unnecessary icache maintenance operations
Date: Fri, 26 May 2017 12:14:04 +0100 [thread overview]
Message-ID: <20170526111407.13537-1-punit.agrawal@arm.com> (raw)
Hi,
This series improves the number of icache flushes performed when
allocating memory to a domain. This series was previously posted at
[0] and [1].
Changes
v1 -> v2:
* Updated tags
* Added a comment for icache_invalidate() definition for x86 to
explain why it is empty.
RFC -> v1:
* Fixed coding style issue in Patch 1
* Added reviewed-by tags
* Re-worked Patch 3 to defer icache optimisation only during domain creation
Patch 1 adds a parameter to flush_page_to_ram() to prevent performing
icache maintenance per page. Current calls to flush_page_to_ram() loop
over pages and performing a full icache flush for each page is
excessive.
Patch 2 hoists icache maintenance from flush_page_to_ram() to
p2m_cache_flush().
Patch 3 introduces a new MEMF_ flag to indicate to alloc_heap_pages()
that icache maintenance will be performed by the caller. The icache
maintenance operations are performed in populate_physmap() during
domain creation. As I couldn't find icache maintenance operations for
x86, an empty helper is introduced.
If there are no further comments, please consider for inclusion.
Thanks,
Punit
[0] https://www.mail-archive.com/xen-devel@lists.xen.org/msg108002.html
[1] https://www.mail-archive.com/xen-devel@lists.xen.org/msg102934.html
Punit Agrawal (3):
Allow control of icache invalidations when calling flush_page_to_ram()
arm: p2m: Prevent redundant icache flushes
Avoid excess icache flushes in populate_physmap() before domain has
been created
xen/arch/arm/mm.c | 5 +++--
xen/arch/arm/p2m.c | 4 +++-
xen/common/memory.c | 31 ++++++++++++++++++++++---------
xen/common/page_alloc.c | 2 +-
xen/include/asm-arm/page.h | 2 +-
xen/include/asm-x86/flushtlb.h | 2 +-
xen/include/asm-x86/page.h | 8 ++++++++
xen/include/xen/mm.h | 2 ++
8 files changed, 41 insertions(+), 15 deletions(-)
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next reply other threads:[~2017-05-26 11:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 11:14 Punit Agrawal [this message]
2017-05-26 11:14 ` [For Xen-4.10 PATCH v2 1/3] Allow control of icache invalidations when calling flush_page_to_ram() Punit Agrawal
2017-05-26 11:14 ` [For Xen-4.10 PATCH v2 2/3] arm: p2m: Prevent redundant icache flushes Punit Agrawal
2017-05-26 11:14 ` [For Xen-4.10 PATCH v2 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created Punit Agrawal
2017-05-26 11:51 ` Jan Beulich
2017-06-07 8:38 ` Jan Beulich
2017-06-07 8:59 ` Punit Agrawal
2017-06-07 9:34 ` [For Xen-4.10 PATCH] Ensure invalidate_icache() definition is visible only when !__ASSEMBLY__ Punit Agrawal
2017-06-07 10:37 ` Jan Beulich
2017-06-07 11:19 ` [For Xen-4.10 PATCH v2 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created Andrew Cooper
2017-06-07 11:32 ` Julien Grall
2017-06-07 11:41 ` Punit Agrawal
2017-06-07 12:04 ` [For Xen-4.10 PATCH] memory: Re-introduce an erroneously dropped line Punit Agrawal
2017-06-07 12:13 ` Jan Beulich
2017-06-07 12:16 ` Julien Grall
2017-06-06 16:32 ` [For Xen-4.10 PATCH v2 0/3] Reduce unnecessary icache maintenance operations Julien Grall
2017-06-06 16:36 ` Jan Beulich
2017-06-06 18:51 ` Stefano Stabellini
2017-06-07 9:46 ` Punit Agrawal
2017-06-07 17:46 ` Stefano Stabellini
2017-06-07 17:47 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526111407.13537-1-punit.agrawal@arm.com \
--to=punit.agrawal@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).