From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 4/4] Makefile: Provide way to ship livepatch test files
Date: Wed, 7 Jun 2017 11:07:30 -0400 [thread overview]
Message-ID: <20170607150730.GD676@char.us.oracle.com> (raw)
In-Reply-To: <1496847092-18838-5-git-send-email-ian.jackson@eu.citrix.com>
On Wed, Jun 07, 2017 at 03:51:32PM +0100, Ian Jackson wrote:
> In the toplevel Makefile, provide build-tests and install-tests
> targets which descend into xen/test. (dist-tests is provided
> automatically by the pattern rule, as is the convention here.)
>
> We have to set BASEDIR ourselves, and use these curious runes, because
> the convention in Makefiles under xen/ is to "make -f Rules.mk" with
> BASEDIR set and to expect Rules.mk to reinvoke the per-directory
> Makefile. (This is really very strange.) Normally this invocation
> pattern is organised by the machinery in xen/Makefile (which sets
> BASEDIR) and Rules.mk, but we need to invoke it from outside that
> context.
>
> In theory it would be nice to have a pattern rule %-tests. But this
> is not the style in the rest of the toplevel Makefile; and doing that
> might interfere with the dist-% pattern rule.
>
> None of this is invoked by default. If install-tests or dist-tests is
> requested, the livepatches (the only current output from xen/tests)
> are shipped in DESTDIR/usr/lib/debug/xen-livepatch/.
>
> This allows CI systems such as osstest which are trying to consume
> this to arrange for the files to be built, and output, without them
> having to have special knowledge of the details of Xen's build syste.
>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
> Makefile | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 2ff33df..0b5f57d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -144,6 +144,17 @@ tools/firmware/ovmf-dir-force-update:
> install-docs:
> $(MAKE) -C docs install
>
> +# We only have build-tests install-tests, not uninstall-tests etc.
> +.PHONY: build-tests
> +build-tests: build-xen
> + export BASEDIR=$(XEN_ROOT)/xen; \
> + $(MAKE) -f $$BASEDIR/Rules.mk -C xen/test build
> +
> +.PHONY: install-tests
> +install-tests: install-xen
> + export BASEDIR=$(XEN_ROOT)/xen; \
> + $(MAKE) -f $$BASEDIR/Rules.mk -C xen/test install
> +
> # build xen and the tools and place them in the install
> # directory. 'make install' should then copy them to the normal system
> # directories
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-07 15:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 14:51 [PATCH for-4.9 0/4] Makefiles: Provide way to ship livepatch tests Ian Jackson
2017-06-07 14:51 ` [PATCH 1/4] xen/test/livepatch/Makefile: Install in DESTDIR/usr/lib/debug/xen-livepatch Ian Jackson
2017-06-07 15:04 ` Konrad Rzeszutek Wilk
2017-06-07 14:51 ` [PATCH 2/4] xen/test/livepatch: Regularise Makefiles Ian Jackson
2017-06-07 15:05 ` Konrad Rzeszutek Wilk
2017-06-07 14:51 ` [PATCH 3/4] xen/test/livepatch: Add xen_nop.livepatch to .gitignore Ian Jackson
2017-06-07 15:06 ` Konrad Rzeszutek Wilk
2017-06-07 15:20 ` Jan Beulich
2017-06-07 14:51 ` [PATCH 4/4] Makefile: Provide way to ship livepatch test files Ian Jackson
2017-06-07 15:07 ` Konrad Rzeszutek Wilk [this message]
2017-06-07 15:58 ` Andrew Cooper
2017-06-07 15:07 ` [PATCH for-4.9 0/4] Makefiles: Provide way to ship livepatch tests Konrad Rzeszutek Wilk
2017-06-07 15:22 ` Jan Beulich
2017-06-07 15:31 ` Wei Liu
2017-06-07 15:53 ` [PATCH for-4.9 0/4] Makefiles: Provide way to ship livepatch tests [and 1 more messages] Ian Jackson
2017-06-09 12:41 ` [PATCH for-4.9 0/4] Makefiles: Provide way to ship livepatch tests Julien Grall
2017-06-09 14:31 ` Ian Jackson
2017-06-14 10:28 ` Julien Grall
2017-06-19 12:59 ` Ian Jackson
2017-06-19 13:03 ` Andrew Cooper
2017-06-19 14:23 ` [PATCH for-4.9] xen/test/Makefile: Fix clean target, broken by pattern rule Ian Jackson
2017-06-19 14:55 ` Konrad Rzeszutek Wilk
2017-06-19 20:14 ` Konrad Rzeszutek Wilk
2017-06-20 10:37 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607150730.GD676@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).