Re: [RFC PATCH v3 11/24] ARM: fdt: Export and introduce new fdt functions

From: Wei Liu <wei.liu2@citrix.com>
To: vijay.kilari@gmail.com
Cc: tim@xen.org, kevin.tian@intel.com, sstabellini@kernel.org,
	wei.liu2@citrix.com, George.Dunlap@eu.citrix.com,
	andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	julien.grall@arm.com, jbeulich@suse.com,
	Vijaya Kumar K <Vijaya.Kumar@cavium.com>
Subject: Re: [RFC PATCH v3 11/24] ARM: fdt: Export and introduce new fdt functions
Date: Tue, 18 Jul 2017 16:29:35 +0100	[thread overview]
Message-ID: <20170718152935.i3pt7yirgrzaecqy@citrix.com> (raw)
In-Reply-To: <1500378106-2620-12-git-send-email-vijay.kilari@gmail.com>

On Tue, Jul 18, 2017 at 05:11:33PM +0530, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@cavium.com>
> 
> Introduce new api device_tree_type_matches() to check for
> device type. Also export device_tree_get_u32() and
> device_tree_node_compatible()
> 
> These functions are later used for parsing NUMA information.
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@cavium.com>
> ---
> v3: Export device_tree_node_compatible() instead of
>     device_tree_node_matches()
> ---
>  xen/arch/arm/bootfdt.c      | 20 ++++++++++++++++----
>  xen/include/asm-arm/setup.h |  5 +++++
>  2 files changed, 21 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index ea188a0..6e8251b 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -31,8 +31,8 @@ static bool_t __init device_tree_node_matches(const void *fdt, int node,
>          && (name[match_len] == '@' || name[match_len] == '\0');
>  }
>  
> -static bool_t __init device_tree_node_compatible(const void *fdt, int node,
> -                                                 const char *match)
> +bool_t __init device_tree_node_compatible(const void *fdt, int node,
> +                                          const char *match)

While you're changing the code please change bool_t to bool

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel