xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>, Doug Goldstein <cardoe@cardoe.com>,
	osstest-admin@xenproject.org, Julien Grall <julien.grall@arm.com>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [xen-unstable-smoke bisection] complete build-arm64-xsm
Date: Wed, 14 Mar 2018 10:54:47 +0000	[thread overview]
Message-ID: <20180314105447.3tjfpeek535lxtbq@citrix.com> (raw)
In-Reply-To: <04f8a92f-0e9f-a256-8d6f-127457a4d114@citrix.com>

On Wed, Mar 14, 2018 at 09:01:10AM +0000, Andrew Cooper wrote:
> On 14/03/2018 07:59, Jan Beulich wrote:
> >>>> On 14.03.18 at 03:29, <osstest-admin@xenproject.org> wrote:
> >> branch xen-unstable-smoke
> >> xenbranch xen-unstable-smoke
> >> job build-arm64-xsm
> >> testid xen-build
> >>
> >> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
> >> Tree: xen git://xenbits.xen.org/xen.git
> >>
> >> *** Found and reproduced problem changeset ***
> >>
> >>   Bug is in tree:  xen git://xenbits.xen.org/xen.git
> >>   Bug introduced:  b43501451733193b265de30fd79a764363a2a473
> >>   Bug not present: eef83fd2af0d4c78afec34c199c977fc97d8a0b3
> >>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/120707/ 
> >>
> >>
> >>   commit b43501451733193b265de30fd79a764363a2a473
> >>   Author: Doug Goldstein <cardoe@cardoe.com>
> >>   Date:   Mon Mar 12 23:06:51 2018 -0500
> >>   
> >>       tools: detect appropriate debug optimization level
> >>       
> >>       When building debug use -Og as the optimization level if its available,
> >>       otherwise retain the use of -O0. -Og has been added by GCC to enable all
> >>       optimizations that to not affect debugging while retaining full
> >>       debugability.
> >>       
> >>       Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> >>       Acked-by: Wei Liu <wei.liu2@citrix.com>
> > Sadly altering optimization levels always has the potential of
> > triggering issues like this:
> >
> > xc_dom_arm.c: In function 'meminit':
> > xc_dom_arm.c:446:5: error: 'p2m_size' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >      for ( pfn = 0; pfn < p2m_size; pfn++ )
> >      ^
> > cc1: all warnings being treated as errors
> > /home/osstest/build.120709.build-arm64-xsm/xen/tools/libxc/../../tools/Rules.mk:230: recipe for target 'xc_dom_arm.o' failed
> > make[5]: *** [xc_dom_arm.o] Error 1
> 
> We really should be build testing things at all optimisation levels.  We
> should be ashamed that -O3 gives build failures in most of our major
> components.  (This is yet another item on my TODO list which I've not
> had time to complete.)

I agree with your opinion in general.

In this particular case, I think the compiler is to be blamed. p2m_size
should have been initialised in a previous loop by the time the code
comes to the place gcc complained.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-03-14 10:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14  2:29 [xen-unstable-smoke bisection] complete build-arm64-xsm osstest service owner
2018-03-14  7:59 ` Jan Beulich
2018-03-14  9:01   ` Andrew Cooper
2018-03-14 10:54     ` Wei Liu [this message]
2018-03-14 13:42       ` Doug Goldstein
  -- strict thread matches above, loose matches on Subject: below --
2023-06-08  7:13 osstest service owner
2022-09-30  0:06 osstest service owner
2021-07-06 20:34 osstest service owner
2021-05-18 19:57 osstest service owner
2021-02-02  4:17 osstest service owner
2021-01-15 20:46 osstest service owner
2020-10-24  2:26 osstest service owner
2020-05-29 15:11 osstest service owner
2019-05-21 18:46 osstest service owner
2018-10-09 21:55 osstest service owner
2018-04-13  1:17 osstest service owner
2018-04-06  1:15 osstest service owner
2018-03-08  7:03 osstest service owner
2018-01-27  3:32 osstest service owner
2018-01-25 21:47 osstest service owner
2018-01-17  2:07 osstest service owner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314105447.3tjfpeek535lxtbq@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=julien.grall@arm.com \
    --cc=osstest-admin@xenproject.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).