From: Cornelia Huck <cohuck@redhat.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: kvm@vger.kernel.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Filippo Sironi <sironi@amazon.de>,
linux-kernel@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
xen-devel <xen-devel@lists.xenproject.org>,
vasu.srinivasan@oracle.com
Subject: Re: [PATCH] KVM: Start populating /sys/hypervisor with KVM entries
Date: Tue, 9 Oct 2018 19:50:57 +0200 [thread overview]
Message-ID: <20181009195057.2dc8fd7b.cohuck__16945.6447860741$1539107391$gmane$org@redhat.com> (raw)
In-Reply-To: <61740f41-c7e3-edaf-68ac-2e4c4a99523b@oracle.com>
On Tue, 9 Oct 2018 12:21:46 -0400
Boris Ostrovsky <boris.ostrovsky@oracle.com> wrote:
> On 10/9/18 6:41 AM, Christian Borntraeger wrote:
> >
> >
> > On 10/09/2018 11:54 AM, Filippo Sironi wrote:
> >> Start populating /sys/hypervisor with KVM entries when we're running on
> >> KVM. This is to replicate functionality that's available when we're
> >> running on Xen.
> >>
> >> Let's start with /sys/hypervisor/uuid, which users prefer over
> >> /sys/devices/virtual/dmi/id/product_uuid as a way to recognize a virtual
> >> machine, since it's also available when running on Xen HVM and on Xen PV
> >> and, on top of that doesn't require root privileges by default.
> >
> > Can you make this an arch hook? On s390 it is possible to get the uuid with
> > the stsi instruction.
> > See
> > https://git.kernel.org/pub/scm/virt/kvm/kvm.git/tree/arch/s390/kernel/sysinfo.c#n248
> >
> >
> > We do use uuid_t, but we can certainly return a char*.
>
>
> I would suggest having a top-level sys-hypervisor.c that will create
> common files that all hypervisors should have (uuid, type, version, etc)
> and then have hypervisor- and/or arch-specific hooks.
I think we really need *both* hypervisor- and arch-specific hooks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-10-09 17:51 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1539078879-4372-1-git-send-email-sironi@amazon.de>
[not found] ` <c81b65ba-c562-1869-483b-aee5229501e0@de.ibm.com>
2018-10-09 16:21 ` [PATCH] KVM: Start populating /sys/hypervisor with KVM entries Boris Ostrovsky
[not found] ` <61740f41-c7e3-edaf-68ac-2e4c4a99523b@oracle.com>
2018-10-09 17:50 ` Cornelia Huck [this message]
2019-05-14 15:16 ` [Xen-devel] " Filippo Sironi
2019-05-14 15:16 ` [Xen-devel] [PATCH v2 1/2] " Filippo Sironi
2019-05-14 15:26 ` Christian Borntraeger
2019-05-14 16:09 ` Sironi, Filippo
2019-05-14 16:09 ` [Xen-devel] " Sironi, Filippo
2019-05-14 16:31 ` Christian Borntraeger
2019-05-14 16:31 ` [Xen-devel] " Christian Borntraeger
2019-05-14 22:08 ` Sironi, Filippo
2019-05-14 22:08 ` [Xen-devel] " Sironi, Filippo
2019-05-14 15:26 ` Christian Borntraeger
2019-05-16 13:50 ` [Xen-devel] " Alexander Graf
2019-05-16 14:02 ` Andrew Cooper
2019-05-16 14:02 ` [Xen-devel] " Andrew Cooper
2019-05-16 14:08 ` Alexander Graf
2019-05-16 14:08 ` [Xen-devel] " Alexander Graf
2019-05-16 15:02 ` Boris Ostrovsky
2019-05-16 15:14 ` Sironi, Filippo
2019-05-16 15:14 ` [Xen-devel] " Sironi, Filippo
2019-05-16 15:02 ` Boris Ostrovsky
2019-05-17 15:41 ` [Xen-devel] " Sironi, Filippo
2019-05-31 9:06 ` Alexander Graf
2019-05-31 9:12 ` Raslan, KarimAllah
2019-05-31 9:26 ` Alexander Graf
2019-05-31 9:26 ` Alexander Graf
2019-05-31 9:38 ` [Xen-devel] " Marc Zyngier
2019-05-31 9:38 ` Marc Zyngier
2019-05-31 9:12 ` Raslan, KarimAllah
2019-05-31 9:06 ` Alexander Graf
2019-05-17 15:41 ` Sironi, Filippo
2019-05-16 13:50 ` Alexander Graf
2019-05-14 15:16 ` Filippo Sironi
2019-05-14 15:16 ` [Xen-devel] [PATCH v2 2/2] KVM: x86: Implement the arch-specific hook to report the VM UUID Filippo Sironi
2019-05-16 13:56 ` Alexander Graf
2019-05-16 15:25 ` Sironi, Filippo
2019-05-16 15:33 ` Alexander Graf
2019-05-16 16:40 ` Boris Ostrovsky
2019-05-16 17:41 ` Sironi, Filippo
2019-05-16 17:49 ` Alexander Graf
2019-05-16 17:49 ` Alexander Graf
2019-05-16 17:41 ` Sironi, Filippo
2019-05-16 16:40 ` Boris Ostrovsky
2019-05-16 15:33 ` Alexander Graf
2019-05-16 15:25 ` Sironi, Filippo
2019-05-16 13:56 ` Alexander Graf
2019-05-14 15:16 ` Filippo Sironi
2019-05-14 15:16 ` KVM: Start populating /sys/hypervisor with KVM entries Filippo Sironi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20181009195057.2dc8fd7b.cohuck__16945.6447860741$1539107391$gmane$org@redhat.com' \
--to=cohuck@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@de.ibm.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sironi@amazon.de \
--cc=vasu.srinivasan@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).