From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions... Date: Wed, 28 Nov 2018 17:34:47 +0100 Message-ID: <20181128163447.GF4222@dhcp-200-186.str.redhat.com> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-15-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gS2nb-0007AE-Dx for xen-devel@lists.xenproject.org; Wed, 28 Nov 2018 16:34:51 +0000 Content-Disposition: inline In-Reply-To: <20181121151211.15997-15-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Stefano Stabellini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Anthony Perard , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org QW0gMjEuMTEuMjAxOCB1bSAxNjoxMiBoYXQgUGF1bCBEdXJyYW50IGdlc2NocmllYmVuOgo+IC4u LmFuZCB3aXJlIGluIHRoZSBkYXRhcGxhbmUuCj4gCj4gVGhpcyBwYXRjaCBhZGRzIHRoZSByZW1h aW5pbmcgY29kZSB0byBtYWtlIHRoZSB4ZW4tcWRpc2sgWGVuRGV2aWNlCj4gZnVuY3Rpb25hbC4g VGhlIHBhcmFtZXRlcnMgdGhhdCBhIGJsb2NrIGZyb250ZW5kIGV4cGVjdHMgdG8gZmluZCBhcmUK PiBwb3B1bGF0ZWQgaW4gdGhlIGJhY2tlbmQgeGVuc3RvcmUgYXJlYSwgYW5kIHRoZSAncmluZy1y ZWYnIGFuZAo+ICdldmVudC1jaGFubmVsJyB2YWx1ZXMgc3BlY2lmaWVkIGluIHRoZSBmcm9udGVu ZCB4ZW5zdG9yZSBhcmVhIGFyZQo+IG1hcHBlZC9ib3VuZCBhbmQgdXNlZCB0byBzZXQgdXAgdGhl IGRhdGFwbGFuZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWwuZHVycmFu dEBjaXRyaXguY29tPgo+IC0tLQo+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5p QGtlcm5lbC5vcmc+Cj4gQ2M6IEFudGhvbnkgUGVyYXJkIDxhbnRob255LnBlcmFyZEBjaXRyaXgu Y29tPgo+IENjOiBLZXZpbiBXb2xmIDxrd29sZkByZWRoYXQuY29tPgo+IENjOiBNYXggUmVpdHog PG1yZWl0ekByZWRoYXQuY29tPgo+IC0tLQo+ICBody9ibG9jay94ZW4tcWRpc2suYyAgICAgICB8 IDE0MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaHcv eGVuL3hlbi1idXMuYyAgICAgICAgICAgfCAgMTIgKystLQo+ICBpbmNsdWRlL2h3L3hlbi94ZW4t YnVzLmggICB8ICAgOCArKysKPiAgaW5jbHVkZS9ody94ZW4veGVuLXFkaXNrLmggfCAgMTIgKysr Kwo+ICA0IGZpbGVzIGNoYW5nZWQsIDE2NiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9ody9ibG9jay94ZW4tcWRpc2suYyBiL2h3L2Jsb2NrL3hlbi1xZGlz ay5jCj4gaW5kZXggMzVmN2I3MDQ4MC4uOGM4ODM5MzgzMiAxMDA2NDQKPiAtLS0gYS9ody9ibG9j ay94ZW4tcWRpc2suYwo+ICsrKyBiL2h3L2Jsb2NrL3hlbi1xZGlzay5jCj4gQEAgLTksNiArOSwx MCBAQAo+ICAjaW5jbHVkZSAicWFwaS92aXNpdG9yLmgiCj4gICNpbmNsdWRlICJody9ody5oIgo+ ICAjaW5jbHVkZSAiaHcveGVuL3hlbi1xZGlzay5oIgo+ICsjaW5jbHVkZSAic3lzZW11L2Jsb2Nr ZGV2LmgiCj4gKyNpbmNsdWRlICJzeXNlbXUvYmxvY2stYmFja2VuZC5oIgo+ICsjaW5jbHVkZSAi c3lzZW11L2lvdGhyZWFkLmgiCj4gKyNpbmNsdWRlICJkYXRhcGxhbmUveGVuLXFkaXNrLmgiCj4g ICNpbmNsdWRlICJ0cmFjZS5oIgo+ICAKPiAgc3RhdGljIGNoYXIgKnhlbl9xZGlza19nZXRfbmFt ZShYZW5EZXZpY2UgKnhlbmRldiwgRXJyb3IgKiplcnJwKQo+IEBAIC0yMyw2ICsyNywxMSBAQCBz dGF0aWMgdm9pZCB4ZW5fcWRpc2tfcmVhbGl6ZShYZW5EZXZpY2UgKnhlbmRldiwgRXJyb3IgKipl cnJwKQo+ICB7Cj4gICAgICBYZW5RZGlza0RldmljZSAqcWRpc2tkZXYgPSBYRU5fUURJU0tfREVW SUNFKHhlbmRldik7Cj4gICAgICBYZW5RZGlza1ZkZXYgKnZkZXYgPSAmcWRpc2tkZXYtPnZkZXY7 Cj4gKyAgICBCbG9ja0NvbmYgKmNvbmYgPSAmcWRpc2tkZXYtPmNvbmY7Cj4gKyAgICBEcml2ZUlu Zm8gKmRpbmZvOwo+ICsgICAgYm9vbCBpc19jZHJvbTsKPiArICAgIHVuc2lnbmVkIGludCBpbmZv Owo+ICsgICAgaW50NjRfdCBzaXplOwo+ICAKPiAgICAgIGlmICghdmRldi0+dmFsaWQpIHsKPiAg ICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJ2ZGV2IHByb3BlcnR5IG5vdCBzZXQiKTsKPiBAQCAt MzAsMTMgKzM5LDEzNCBAQCBzdGF0aWMgdm9pZCB4ZW5fcWRpc2tfcmVhbGl6ZShYZW5EZXZpY2Ug KnhlbmRldiwgRXJyb3IgKiplcnJwKQo+ICAgICAgfQo+ICAKPiAgICAgIHRyYWNlX3hlbl9xZGlz a19yZWFsaXplKHZkZXYtPmRpc2ssIHZkZXYtPnBhcnRpdGlvbik7Cj4gKwo+ICsgICAgaWYgKCFj b25mLT5ibGspIHsKPiArICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJkcml2ZSBwcm9wZXJ0eSBu b3Qgc2V0Iik7Cj4gKyAgICAgICAgcmV0dXJuOwo+ICsgICAgfQo+ICsKPiArICAgIGlmICghYmxr X2lzX2luc2VydGVkKGNvbmYtPmJsaykpIHsKPiArICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJk ZXZpY2UgbmVlZHMgbWVkaWEsIGJ1dCBkcml2ZSBpcyBlbXB0eSIpOwo+ICsgICAgICAgIHJldHVy bjsKPiArICAgIH0KCkhtLCB0aGUgY29kZSBiZWxvdyBzdWdnZXN0cyB0aGF0IHlvdSBzdXBwb3J0 IENELVJPTXMuIERvbid0IHlvdSB3YW50IHRvCnN1cHBvcnQgbWVkaWEgY2hhbmdlIGFzIHdlbGwg dGhlbj8gV2hpY2ggd291bGQgbWVhbiB0aGF0IHlvdSBuZWVkIHRvCnN1cHBvcnQgZW1wdHkgZHJp dmVzLgoKPiArICAgIGlmICghYmxrY29uZl9hcHBseV9iYWNrZW5kX29wdGlvbnMoY29uZiwgYmxr X2lzX3JlYWRfb25seShjb25mLT5ibGspLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBmYWxzZSwgZXJycCkpIHsKPiArICAgICAgICByZXR1cm47Cj4gKyAgICB9Cj4g Kwo+ICsgICAgaWYgKCFibGtjb25mX2dlb21ldHJ5KGNvbmYsIE5VTEwsIDY1NTM1LCAyNTUsIDI1 NSwgZXJycCkpIHsKPiArICAgICAgICByZXR1cm47Cj4gKyAgICB9Cj4gKwo+ICsgICAgZGluZm8g PSBibGtfbGVnYWN5X2RpbmZvKGNvbmYtPmJsayk7Cj4gKyAgICBpc19jZHJvbSA9IChkaW5mbyAm JiBkaW5mby0+bWVkaWFfY2QpOwoKSXQncyBjYWxsZWQgbGVnYWN5IGZvciBhIHJlYXNvbi4gRG9u J3QgdXNlIHRoaXMgaW4gbmV3IGRldmljZXMuCgpUaGUgcHJvcGVyIHdheSBpcyB0byBoYXZlIHR3 byBkaWZmZXJlbnQgZGV2aWNlcyBmb3IgaGFyZCBkaXNrcyBhbmQgQ0RzCihsaWtlIHNjc2ktaGQg YW5kIHNjc2ktY2QpLgoKS2V2aW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94 ZW4tZGV2ZWw=